Re: [DOCS] Clarification suggestion for 46.4 chapter.
On 17.08.2012 05:07, Bruce Momjian wrote:
On Mon, Dec 5, 2011 at 02:53:22PM +0300, Dmitriy Igrishin wrote:
Hey,
The section 46.4 describes the base data types used in messages.
http://www.postgresql.org/docs/9.1/static/protocol-message-types.html
According to section 46.5
http://www.postgresql.org/docs/9.1/static/protocol-message-formats.html
there are cases when Int32 can be negative (e.g. see DataRow(B) message
description.)
Thus, I would like to suggest to change the description of Int(i)
from
"An n-bit integer in network byte order ..."
to
"An n-bit signed integer in network byte order ..."
OK, documentation updated.
Actually, in some cases the integers are signed, and in others unsigned.
For example, in a Bind('F') message, the number of parameters is an
Int16 according to the docs, but it is treated as unsigned. The maximum
number of parameters is 65535.
The sentence used to be factually correct, when it didn't mention
whether they're signed or unsigned. If we want to do better than that,
we'd need to go through all the mentions of IntN in the docs and
explicitly say which ones are signed and which ones unsigned. Perhaps
use Uint16 or Uint32 for the unsigned ones.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] somewhat wrong archive_command example
On 8/15/12 9:13 PM, Bruce Momjian wrote:
Few more suggestions/nitpicks:
1.) IMO it's more logical to put the test for whether the $ARCHIVE
directory exists before the test whether ${ARCHIVE}/${FILE} exists.
2.) I think the error code reporting here is not sound:
cp ${FULLPATH} ${ARCHIVE}/${FILE}
if [ $? -ne 0 ] ; then
echo $0 Archive copy of ${FILE} failed with error $? >&2
at least on my OS X machine, that echo produces a message like
"./local_backup_script.sh Archive copy of failed with error 0", I
guess since $? gets reset to 0 after that if-statement. You can use a
temporary variable like $ERRCODE=$? to get around this.
I have made all the suggestions posted and would like to add the
attached script to our documentation as a simple example.
Btw., is anyone else concerned about using plain cp for this? If the cp
fails half-way, it leaves a partial file around, but subsequent file
existence checks will find the file OK and skip it.
I have occasionally used some combination of mktemp + cp + mv, which
seems to work around this problem.
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] Would like to contribute a section to docs for 9.3. Where to start?
On 8/15/12 5:33 AM, Chris Travers wrote: So here is a very rough draft. I would be interested in feedback as to inaccuracies or omissions. I would like to get the technical side right before going into an editorial phase. Any feedback on the technical side? [citation needed] Seriously, if we are trying to justify our use of seemingly standard academic terms, we should have some references to where those are defined or at least discussed. Otherwise we are just begging the question: PostgreSQL is object-relational because we say so. -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] somewhat wrong archive_command example
On 17-08-2012 16:51, Peter Eisentraut wrote: > Btw., is anyone else concerned about using plain cp for this? If the cp fails > half-way, it leaves a partial file around, but subsequent file existence > checks will find the file OK and skip it. > I've already faced this problem (with cp and scp). > I have occasionally used some combination of mktemp + cp + mv, which seems to > work around this problem. > That's what rsync uses, no? Your suggestion or rsync seem safe options to me. But if you insist on an academic example using cp, at least comment that it can fail in some cases. -- Euler Taveira de Oliveira - Timbira http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] Would like to contribute a section to docs for 9.3. Where to start?
On Fri, Aug 17, 2012 at 1:03 PM, Peter Eisentraut wrote: > On 8/15/12 5:33 AM, Chris Travers wrote: > >> So here is a very rough draft. I would be interested in feedback as to >> inaccuracies or omissions. I would like to get the technical side right >> before going into an editorial phase. >> >> Any feedback on the technical side? >> > > [citation needed] > > Seriously, if we are trying to justify our use of seemingly standard > academic terms, we should have some references to where those are defined > or at least discussed. Otherwise we are just begging the question: > PostgreSQL is object-relational because we say so. > Good point. I found two interesting resources quickly which seem on point: http://infolab.usc.edu/csci585/Spring2010/den_ar/ordb.pdf which appears to be chapter 1 of http://www.amazon.com/Object-Relational-Database-Development-Plumbers-CD-ROM/dp/0130194603 and http://db.cs.berkeley.edu/papers/Informix/www.informix.com/informix/corpinfo/zines/whitpprs/illuswp/wave.htm But this doesn't really get us beyond the "because we say so" given the connection between Informix and PostgreSQL. It really looks to me like Postges was given the name Object-Relational by Stonebreaker as a way of saying "here's what I am trying to play around with" and the databases which describe themselves in these terms seem either inspired by or forks of Postgres ;-). Best Wishes, Chris Travers
