Re: [DOCS] [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote: > Minor corrections: > > First block: " > In the first section of this chapter, we > describe how to set configuration parameters" > > - remove the comma > > Second Block: > - placement of the colon inside or outside of the emphasis tag is inconsistent > (string, unit, enum are inside; boolean and numeric are outside) > - units: "An numeric value..." -> maybe "An unadorned numeric value... > > Third block: > "Hash marks (#) designate the remainder of lines as > comments." -> "...designate the remainder of the line as a comment." I read > this at first as "remaining lines [in the file] ... " > > "To embed a single quote in a parameter value, write either two quotes > (preferred) or backslash-quote." -> remove the comma > "Querying this view is the sames as" -> "the same as" I agree all of the above are improvements, and changed. > "In addition to setting global defaults or attaching" <- add a comma after > "defaults" I didn't like this change as it causes too many comma phrases. Attaches are the changes since yesterday's patch. The full patch is at: ftp://momjian.us/postgresql/mypatches/config.diff -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + commit 01cbe3a4949664f3b001a7d3be7990d37fc8a291 Author: Bruce Momjian Date: Wed Sep 10 15:49:06 2014 -0400 dummy commit diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml new file mode 100644 index 156c264..4a97855 *** a/doc/src/sgml/config.sgml --- b/doc/src/sgml/config.sgml *** *** 10,16 There are many configuration parameters that affect the behavior of !the database system. In the first section of this chapter, we describe how to interact with configuration parameters. The subsequent sections discuss each parameter in detail. --- 10,16 There are many configuration parameters that affect the behavior of !the database system. In the first section of this chapter we describe how to interact with configuration parameters. The subsequent sections discuss each parameter in detail. *** *** 31,37 !Boolean: Values can be written as on, off, true, --- 31,37 !Boolean: Values can be written as on, off, true, *** *** 54,61 !Numeric (integer and floating point): Do not use !single-quotes (unless otherwise required) or thousand separators. --- 54,62 !Numeric (integer and floating point): Do !not use single-quotes (unless otherwise required) or thousand !separators. *** *** 64,71 Numeric or String with Unit (Memory & Time): These have an implicit unit, which is either kilobytes, blocks (typically eight kilobytes), !milliseconds, seconds, or minutes. An numeric value !will use the default, which can be found by referencing pg_settings.unit. For convenience, a different unit can also be specified explicitly via a string value. It is case-sensitive and may include whitespace between --- 65,72 Numeric or String with Unit (Memory & Time): These have an implicit unit, which is either kilobytes, blocks (typically eight kilobytes), !milliseconds, seconds, or minutes. A unadorned numeric !value will use the default, which can be found by referencing pg_settings.unit. For convenience, a different unit can also be specified explicitly via a string value. It is case-sensitive and may include whitespace between *** log_destination = 'syslog' *** 123,134 search_path = '"$user", public' shared_buffers = 128MB ! One parameter is specified per line. The equal sign between name ! and value is optional. Whitespace is insignificant and blank ! lines are ignored. Hash marks (#) designate the ! remainder of lines as comments. Parameter values that are not simple identifiers or numbers must be single-quoted. To embed a single ! quote in a parameter value, write either two quotes (preferred) or backslash-quote. --- 124,135 search_path = '"$user", public' shared_buffers = 128MB ! One parameter is specified per line. The equal sign between name and ! value is optional. Whitespace is insignificant and blank lines are ! ignored. Hash marks (#) designate the remainder ! of the line as a comment. Parameter values that are not simple identifiers or numbers must be single-quoted. To embed a single ! quote in a parameter value write either two quotes (preferre
[DOCS] NULL as a (pseudo-)value not described?
As far as I can tell, the un-value NULL is not described anywhere in the doc as being something that can be assigned to a column. E.g. : . not listed as a constant (well that's reasonable as it isn't) . not listed as an expression (is NULL an expression?) . not explicitly listed under the INSERT and UPDATE commands as a valid syntactic unit as an alternative to an expression (If it is not an expression) I do see it listed as a valid keyword but there is no description there. To put it another way, the following syntax is apparently not permitted : UPDATE my_nullable_table SET nullable_col = NULL; (I am not referring to other null-related constructs such as IS NULL, IFNULL etc) I have to assume I'm missing something? Or is it that NULL is so, well, null, that it cannot be described? John -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian wrote: > On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote: > > > "In addition to setting global defaults or attaching" <- add a comma > after > > "defaults" > > I didn't like this change as it causes too many comma phrases. > > Attaches are the changes since yesterday's patch. The full patch is at: > > ftp://momjian.us/postgresql/mypatches/config.diff > > At minimum the word "setting" in that paragraph needs to be made plural. ", you can pass settings to PostgreSQL..." I'm not particularly fond of the overly long preamble burying the "shell facilities" - and the resultant comma separating the two - but cannot think of anything better. Not having the transition makes it too short and curt. The proposed second comma helped to at least break it up but it too doesn't sound all that great. I'm good for just making the plural fix and calling it a day. David J.
Re: [DOCS] [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
On Wed, Sep 10, 2014 at 08:09:30PM -0400, David Johnston wrote: > On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian wrote: > > On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote: > > > "In addition to setting global defaults or attaching" <- add a comma > after > > "defaults" > > I didn't like this change as it causes too many comma phrases. > > Attaches are the changes since yesterday's patch. The full patch is at: > > ftp://momjian.us/postgresql/mypatches/config.diff > > > > At minimum the word "setting" in that paragraph needs to be made plural. ", > you can pass settings to PostgreSQL..." Oh, good point, fixed. > I'm not particularly fond of the overly long preamble burying the "shell > facilities" - and the resultant comma separating the two - but cannot think of > anything better. Not having the transition makes it too short and curt. The > proposed second comma helped to at least break it up but it too doesn't sound > all that great. > > I'm good for just making the plural fix and calling it a day. Modified patch applied to head and 9.4. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] NULL as a (pseudo-)value not described?
johnlumby wrote > As far as I can tell, > the un-value NULL is not described anywhere in the doc > as being something that can be assigned to a column. > > E.g. : > . not listed as a constant (well that's reasonable as it isn't) > . not listed as an expression (is NULL an expression?) > . not explicitly listed under the INSERT and UPDATE commands > as a valid syntactic unit as an alternative to an expression > (If it is not an expression) > > I do see it listed as a valid keyword but there is no description there. > > To put it another way, the following syntax is apparently not permitted > : > UPDATE my_nullable_table SET nullable_col = NULL; > > (I am not referring to other null-related constructs such as IS NULL, > IFNULL etc) > > I have to assume I'm missing something? > Or is it that NULL is so, well, null, that it cannot be described? http://www.postgresql.org/docs/9.4/static/ddl-default.html To your point: null is a constant/literal as defined in http://www.postgresql.org/docs/9.4/static/sql-expressions.html#SYNTAX-EXPRESS-EVAL and so can appear in the defined expression area and so your example is explicitly allowed. http://www.postgresql.org/docs/9.4/static/bookindex.html#AEN167062 (under "N") Pseudo-type has a specific meaning is PostgreSQL which null does not conform to. Having brought this to attention why did you go looking for it and where, in order, did you look? I'll agree that it seems that a previous recognition that null can always used as a valid data value is assumed much like it is assumed that 1000 is a valid value for an integer. David J. -- View this message in context: http://postgresql.1045698.n5.nabble.com/NULL-as-a-pseudo-value-not-described-tp5818521p5818543.html Sent from the PostgreSQL - docs mailing list archive at Nabble.com. -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
