[DOCS] pg_logical_slot_get_changes needs clarification

2016-12-05 Thread finzelj
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.4/static/functions-admin.html
Description:

It is not obvious from reading the description for function
pg_logical_slot_get_changes that it is a "destructive" function, and 
this
bit me.  I was not clearly aware that this function consumes the replication
stream such that it's no longer available if I use it to look at the logical
stream, i.e., I MUST use the peek function for that purpose.

This is more clear in the full examples of logical decoding.  Also, it says
in the "peek" function that 
the peek function does not consume changes like the get function - but that
should be stated clearly in the get function description.

The name of the function itself is part of the problem: "get" does not
normally indicate "destroy" as well

Thanks!
BecauseThere should b

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


[DOCS] Grammar error

2017-03-06 Thread finzelj
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.5/static/wal-configuration.html
Description:

On the 9.5/wal-configuration page, there is a grammar error:

"so it accommodates peak usage rather average usage to some extent"

It should be "rather **than** average usage", I believe.

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


[DOCS] Confused about a statement in WAL configs

2017-07-31 Thread finzelj
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.6/static/wal-configuration.html
Description:

In this section:

"At checkpoint time, all dirty data pages are flushed to disk and a special
checkpoint record is written to the log file. (The change records were
previously flushed to the WAL files.)"

I am confused by what the part in parenthesis means by "previously".  
This
may only reflect my ignorance, but I don't know if "previously" 
means "in
previous versions of Postgres" or "before the checkpoint" or 
something
else.

Mostly because of this, I don't understand what this statement means.  Thank
you.

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs