Re: [HACKERS] Connection string parameter 'replication' in documentation

2015-10-05 Thread Takashi Ohnishi
Thanks for your answer:)

>This is introduced by the commit 5a991ef, which allows logical
>decoding via walsender interface. The paramter replication has
>been there far from the commit intentionary as an 'undocumented
>paramter'. This is, I suppose, because it is treated as a part of
>the replication ptorocol, not a matter of ordinary clients at
>all.

Ah, this is intentional!

>Since it has no meaning out of the context of replication agents,
>it seems reasonable that the parameter is not documented in the
>section.

I see.
But, if this parameter is for logical decoding,  I think it is better that
"46.3. Streaming Replication Protocol Interface" tells about this.


>Instead, the comment for libpqrcv_connect@libpqwalreceiver.c has
>become outedated by the commit.
>
>> * We use the expand_dbname parameter to process the connection string (or
>> * URI), and pass some extra options. The deliberately undocumented
>> * parameter "replication=true" makes it a replication connection. The
>
>This should be synced with the document.

Agreed.

--
Takashi Ohnishi

2015-10-05 19:07 GMT+09:00 Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp>:

> Hello,
>
> At Fri, 2 Oct 2015 23:13:24 +0900, Takashi Ohnishi <bwtak...@gmail.com>
> wrote in 

[HACKERS] Connection string parameter 'replication' in documentation

2015-10-02 Thread Takashi Ohnishi
Hi,

I found that it can be set like 'replication = true' in connection
parameter as documentation says in  "50.3. Streaming Replication Protocol",
but this parameter is not denoted in "31.1.2. Parameter Key Words".

How about adding notation about this paramter in 31.1.2.?
Attached is a patch for that.

Regards,

=
Takashi Ohnishi


connect-parameter-replication.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers