Re: [HACKERS] Alias to rollback keyword
On Wed, Mar 31, 2010 at 10:34:41PM -0400, Bruce Momjian wrote: > Matthew Altus wrote: > > Hey, > > > > After dealing with a production fault and having to rollback all the time, > > I > > kept typing a different word instead of rollback. So I created a patch to > > accept this word as an alias for rollback. Obviously it's not part of the > > sql > > standard, but could be a nice extension for postgresql. See the patch for > > more details. > > Applied. Hmm, a careful review of the patch leads me to believe that this is one of the few times that a keyword might benefit from localization. Seems l10n efforts in this area have mostly focused on the filtering case, but I'm sure we can repurose such lists. Licensing might be an issue. Clearly this needs to be controlled by the client locale, not the server. Any need for a guc? Ross -- Ross Reedstrom, Ph.D. reeds...@rice.edu Systems Engineer & Admin, Research Scientistphone: 713-348-6166 The Connexions Project http://cnx.orgfax: 713-348-3665 Rice University MS-375, Houston, TX 77005 GPG Key fingerprint = F023 82C8 9B0E 2CC6 0D8E F888 D3AE 810E 88F0 BEDE -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Alias to rollback keyword
Robert Haas wrote: > On Wed, Mar 31, 2010 at 10:34 PM, Bruce Momjian wrote: > > Matthew Altus wrote: > >> Hey, > >> > >> After dealing with a production fault and having to rollback all the time, > >> I > >> kept typing a different word instead of rollback. ?So I created a patch to > >> accept this word as an alias for rollback. ?Obviously it's not part of the > >> sql > >> standard, but could be a nice extension for postgresql. ?See the patch for > >> more details. > > > > Applied. > > You know, I was about to write a rant about this, until I realized > what day it will be soon (or already is, UTC). CVS is GMT-based. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Alias to rollback keyword
On Wed, Mar 31, 2010 at 10:34 PM, Bruce Momjian wrote: > Matthew Altus wrote: >> Hey, >> >> After dealing with a production fault and having to rollback all the time, I >> kept typing a different word instead of rollback. So I created a patch to >> accept this word as an alias for rollback. Obviously it's not part of the >> sql >> standard, but could be a nice extension for postgresql. See the patch for >> more details. > > Applied. You know, I was about to write a rant about this, until I realized what day it will be soon (or already is, UTC). ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Alias to rollback keyword
Matthew Altus wrote: > Hey, > > After dealing with a production fault and having to rollback all the time, I > kept typing a different word instead of rollback. So I created a patch to > accept this word as an alias for rollback. Obviously it's not part of the > sql > standard, but could be a nice extension for postgresql. See the patch for > more details. Applied. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Alias to rollback keyword
On Mar 31, 2010, at 5:42 PM, Matthew Altus wrote: > After dealing with a production fault and having to rollback all the time, I > kept typing a different word instead of rollback. So I created a patch to > accept this word as an alias for rollback. Obviously it's not part of the > sql > standard, but could be a nice extension for postgresql. See the patch for > more details. +100 Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Alias to rollback keyword
Hey,
After dealing with a production fault and having to rollback all the time, I
kept typing a different word instead of rollback. So I created a patch to
accept this word as an alias for rollback. Obviously it's not part of the sql
standard, but could be a nice extension for postgresql. See the patch for
more details.
Cheers
Matt
diff -U5 -r postgresql-8.4.2.orig/src/include/parser/kwlist.h postgresql-8.4.2/src/include/parser/kwlist.h
--- postgresql-8.4.2.orig/src/include/parser/kwlist.h 2009-04-06 18:12:53.0 +0930
+++ postgresql-8.4.2/src/include/parser/kwlist.h 2010-04-01 10:55:46.0 +1030
@@ -55,10 +55,11 @@
PG_KEYWORD("begin", BEGIN_P, UNRESERVED_KEYWORD)
PG_KEYWORD("between", BETWEEN, TYPE_FUNC_NAME_KEYWORD)
PG_KEYWORD("bigint", BIGINT, COL_NAME_KEYWORD)
PG_KEYWORD("binary", BINARY, TYPE_FUNC_NAME_KEYWORD)
PG_KEYWORD("bit", BIT, COL_NAME_KEYWORD)
+PG_KEYWORD("bollocks", ROLLBACK, UNRESERVED_KEYWORD)
PG_KEYWORD("boolean", BOOLEAN_P, COL_NAME_KEYWORD)
PG_KEYWORD("both", BOTH, RESERVED_KEYWORD)
PG_KEYWORD("by", BY, UNRESERVED_KEYWORD)
PG_KEYWORD("cache", CACHE, UNRESERVED_KEYWORD)
PG_KEYWORD("called", CALLED, UNRESERVED_KEYWORD)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
