Re: [HACKERS] Minor typo in syncrep.c
Amit Langote wrote: > On 2016/02/03 17:50, Amit Langote wrote: > > Attached patch removes an extraneous word in the comment above > > I kept reading and found one place in a comment within the function where > a word is most probably missing, Attached fixes it. Pushed both, thanks. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Minor typo in syncrep.c
Attached patch removes an extraneous word in the comment above SyncRepReleaseWaiters() in syncrep.c - * Other policies are possible, which would change what we do here and what + * Other policies are possible, which would change what we do here and * perhaps also which information we store as well. Thanks, Amit diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c index 7f85b88..d945c71 100644 --- a/src/backend/replication/syncrep.c +++ b/src/backend/replication/syncrep.c @@ -406,7 +406,7 @@ SyncRepGetSynchronousStandby(void) * Update the LSNs on each queue based upon our latest state. This * implements a simple policy of first-valid-standby-releases-waiter. * - * Other policies are possible, which would change what we do here and what + * Other policies are possible, which would change what we do here and * perhaps also which information we store as well. */ void -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Minor typo in syncrep.c
On 2016/02/03 17:50, Amit Langote wrote: > Attached patch removes an extraneous word in the comment above I kept reading and found one place in a comment within the function where a word is most probably missing, Attached fixes it. /* * If this WALSender is serving a standby that is not on the list of - * potential standbys then we have nothing to do. If we are still starting - * up, still running base backup or the current flush position is still - * invalid, then leave quickly also. + * potential sync standbys then we have nothing to do. If we are still + * starting up, still running base backup or the current flush position + * is still invalid, then leave quickly also. Thanks, Amit diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c index 7f85b88..c44161b 100644 --- a/src/backend/replication/syncrep.c +++ b/src/backend/replication/syncrep.c @@ -419,9 +419,9 @@ SyncRepReleaseWaiters(void) /* * If this WALSender is serving a standby that is not on the list of - * potential standbys then we have nothing to do. If we are still starting - * up, still running base backup or the current flush position is still - * invalid, then leave quickly also. + * potential sync standbys then we have nothing to do. If we are still + * starting up, still running base backup or the current flush position + * is still invalid, then leave quickly also. */ if (MyWalSnd->sync_standby_priority == 0 || MyWalSnd->state < WALSNDSTATE_STREAMING || -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
