Re: Looking for Bill Huang; was [HACKERS] Personal Copyright Notices
Bruce Momjian wrote: > Bruce Momjian wrote: > > Some more _personalized_ copyright noticed have crept into our source > > tree: > > > > /src/tutorial/basics.sourceCopyright (c) 1994, Andrew Yu, > > University of California > > /contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by > > Mark L. Woodward > > /src/port/rint.c Copyright (c) 1999, repas AEG Automation GmbH > > /contrib/isn/isn.c Copyright (c) 2004-2006, Germn Mndez Bravo > > (Kronuz) > > /contrib/isn/isn.h Copyright (c) 2004-2006, Germn Mndez Bravo > > (Kronuz) > > /src/backend/utils/mb/Unicode/UCS_to_GB18030.plCopyright 2002 by Bill > > Huang > > I have now dealt with all of these except the last one: > > > The UCS_to_GB18030.pl is a Perl script with this at the top: > > > > # Copyright 2002 by Bill Huang > > Does anyone know how to contact Bill Huang? Based on this posting: > > http://archives.postgresql.org/pgsql-announce/2002-06/msg3.php > > he lives in Japan and worked for Red Hat, and a Japan phone number is > listed that I did not try. I did try emailing him at > bill_huan...@ybb.ne.jp and hu...@redhat.com but both emails returned > failure messages. > > The perl file is 100 lines so it is possible to rewrite it if necessary. > This same file was mentioned in 2007 so I think we should just find a > solution to this: > > http://archives.postgresql.org/pgsql-hackers/2007-03/msg01446.php I have been able to remove this last personal copyright thanks to Andreas 'ads' Scherbaum, who rewrote the perl script using another perl script from the same directory that was created before the offending file. Patch attached. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/backend/utils/mb/Unicode/UCS_to_GB18030.pl === RCS file: /cvsroot/pgsql/src/backend/utils/mb/Unicode/UCS_to_GB18030.pl,v retrieving revision 1.5 diff -c -c -r1.5 UCS_to_GB18030.pl *** src/backend/utils/mb/Unicode/UCS_to_GB18030.pl 7 Mar 2005 04:30:52 - 1.5 --- src/backend/utils/mb/Unicode/UCS_to_GB18030.pl 16 Feb 2010 20:34:11 - *** *** 1,23 #! /usr/bin/perl # ! # Copyright 2002 by Bill Huang # ! # $PostgreSQL: pgsql/src/backend/utils/mb/Unicode/UCS_to_GB18030.pl,v 1.5 2005/03/07 04:30:52 momjian Exp $ # # Generate UTF-8 <--> GB18030 code conversion tables from ! # map files provided by Unicode organization. ! # Unfortunately it is prohibited by the organization ! # to distribute the map files. So if you try to use this script, ! # you have to obtain ISO10646-GB18030.TXT from ! # the organization's ftp site. ! # ! # ISO10646-GB18030.TXT format: ! # GB18030 code in hex ! # UCS-2 code in hex ! # # and Unicode name (not used in this script) require "ucs2utf.pl"; # first generate UTF-8 --> GB18030 table $in_file = "ISO10646-GB18030.TXT"; --- 1,19 #! /usr/bin/perl # ! # Copyright (c) 2007-2010, PostgreSQL Global Development Group # ! # $Id$ # # Generate UTF-8 <--> GB18030 code conversion tables from ! # "ISO10646-GB18030.TXT" ! # ! # file format: ! # GB18030 hex code ! # UCS-2 hex code require "ucs2utf.pl"; + # first generate UTF-8 --> GB18030 table $in_file = "ISO10646-GB18030.TXT"; *** *** 45,50 --- 41,47 } close( FILE ); + # # first, generate UTF8 --> GB18030 table # *** *** 66,71 --- 63,69 print FILE "};\n"; close(FILE); + # # then generate GB18030 --> UTF8 table # -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Greg Stark wrote: > On Fri, Feb 5, 2010 at 3:24 AM, Bruce Momjian wrote: > > Bruce Momjian wrote: > >> The intagg copyright is on a _Makefile_: > >> > >> ? ? ? # Makefile for integer aggregator > >> ? ? ? # Copyright (C) 2001 Digital Music Network. > >> ? ? ? # by Mark L. Woodward > >> ? ? ? # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 > >> 19:58:45 tgl Exp $ > >> > >> Seems we either have to contact the author or rewrite the file. > > > > I have rewritten the above file from scratch to enable removal of the > > copyright mention. > > > > Uhm, you rewrote it and it turned out byte-for-byte identical except > for the removed copyright comments? Actually the file is trivial > enough -- it's just our standard pgxs template with the two filenames > inserted -- that that's plausible. I think that indicates that it > wasn't really something copyrightable to begin with. Right, I copied /contrib/intarray/Makefile and modified it. If it turns out identical, so be it. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
On Fri, Feb 5, 2010 at 3:24 AM, Bruce Momjian wrote: > Bruce Momjian wrote: >> The intagg copyright is on a _Makefile_: >> >> # Makefile for integer aggregator >> # Copyright (C) 2001 Digital Music Network. >> # by Mark L. Woodward >> # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 >> 19:58:45 tgl Exp $ >> >> Seems we either have to contact the author or rewrite the file. > > I have rewritten the above file from scratch to enable removal of the > copyright mention. > Uhm, you rewrote it and it turned out byte-for-byte identical except for the removed copyright comments? Actually the file is trivial enough -- it's just our standard pgxs template with the two filenames inserted -- that that's plausible. I think that indicates that it wasn't really something copyrightable to begin with. -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: Looking for Bill Huang; was [HACKERS] Personal Copyright Notices
Bruce Momjian wrote: > Some more _personalized_ copyright noticed have crept into our source > tree: > > /src/tutorial/basics.source Copyright (c) 1994, Andrew Yu, University of > California > /contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by > Mark L. Woodward > /src/port/rint.c Copyright (c) 1999, repas AEG Automation GmbH > /contrib/isn/isn.c Copyright (c) 2004-2006, Germn Mndez Bravo > (Kronuz) > /contrib/isn/isn.h Copyright (c) 2004-2006, Germn Mndez Bravo > (Kronuz) > /src/backend/utils/mb/Unicode/UCS_to_GB18030.plCopyright 2002 by Bill > Huang I have now dealt with all of these except the last one: > The UCS_to_GB18030.pl is a Perl script with this at the top: > > # Copyright 2002 by Bill Huang Does anyone know how to contact Bill Huang? Based on this posting: http://archives.postgresql.org/pgsql-announce/2002-06/msg3.php he lives in Japan and worked for Red Hat, and a Japan phone number is listed that I did not try. I did try emailing him at bill_huan...@ybb.ne.jp and hu...@redhat.com but both emails returned failure messages. The perl file is 100 lines so it is possible to rewrite it if necessary. This same file was mentioned in 2007 so I think we should just find a solution to this: http://archives.postgresql.org/pgsql-hackers/2007-03/msg01446.php -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Bruce Momjian wrote: > > The ISN copyright looks like this: > >* Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) >* Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group > > Interestingly, he mentions himself and PGDG both in the copyright, which > makese this less of an issue. Looking at the ISN code, it appears he > was the creator of the original file: > > revision 1.1 > date: 2006/09/09 04:07:52; author: tgl; state: Exp; > Add contrib/isn module for ISBN/ISSN/EAN13/etc product numbers, and > remove the old isbn_issn module which is about to be obsoleted by EAN13. > contrib/isn is by Germn Mndez Bravo. Our thanks to Garrett A. > Wollman for having written the original isbn_issn module. > > and he asked about his copyright mention as part of the patch > discussion: > > http://archives.postgresql.org/pgsql-hackers/2006-09/msg00794.php > > I never saw the issue actually addressed and the copyright line was committed. > Do people think it is acceptable? I received email permission from German Mendez Bravo to just mention him as the /contrib/isn author, and remove the "copyright" word. Change commited. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Bruce Momjian wrote: > The intagg copyright is on a _Makefile_: > > # Makefile for integer aggregator > # Copyright (C) 2001 Digital Music Network. > # by Mark L. Woodward > # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 19:58:45 > tgl Exp $ > > Seems we either have to contact the author or rewrite the file. I have rewritten the above file from scratch to enable removal of the copyright mention. > --- > > The rint.c file is again tiny: > > * rint.c > *rint() implementation > * > * Copyright (c) 1999, repas AEG Automation GmbH > > Perhaps that just needs to be rewritten. I received a new rint() version from Nathan Wagner that is simpler and replaced the old rint() code with Nathan's and removed the copyright mention. Patch attached. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/port/rint.c === RCS file: /cvsroot/pgsql/src/port/rint.c,v retrieving revision 1.2 diff -c -c -r1.2 rint.c *** src/port/rint.c 29 Nov 2003 19:52:13 - 1.2 --- src/port/rint.c 5 Feb 2010 03:20:25 - *** *** 3,11 * rint.c * rint() implementation * - * Copyright (c) 1999, repas AEG Automation GmbH - * - * * IDENTIFICATION * $PostgreSQL: pgsql/src/port/rint.c,v 1.2 2003/11/29 19:52:13 pgsql Exp $ * --- 3,8 *** *** 18,37 double rint(double x) { ! double f, ! n = 0.; ! ! f = modf(x, &n); ! ! if (x > 0.) ! { ! if (f > .5) ! n += 1.; ! } ! else if (x < 0.) ! { ! if (f < -.5) ! n -= 1.; ! } ! return n; } --- 15,19 double rint(double x) { ! return (x > 0.0) ? floor(x + 0.5) : ceil(x - 0.5); } -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Dave Page wrote: > On Tue, Feb 2, 2010 at 8:20 PM, Bruce Momjian wrote: > >> > Seems we either have to contact the author or rewrite the file. > >> > >> Why? Even if the text is removed, he will still own the copyright, as > >> is the case for any patch submitted because we don't have any form of > >> copyright assignment. > > > > True, but their names on these files is bound to confuse legal folks > > looking at the code. ?I got a private email about these copyrights last > > week from a _very_ large company, which is how they came to my > > attention. > > I'm not saying we shouldn't remove the text, but there's no need to > rewrite the code. Well, for the ones where the file is 6 lines, it might be worth re-writing if we can't contact the authors. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
On Tue, Feb 2, 2010 at 8:20 PM, Bruce Momjian wrote: >> > Seems we either have to contact the author or rewrite the file. >> >> Why? Even if the text is removed, he will still own the copyright, as >> is the case for any patch submitted because we don't have any form of >> copyright assignment. > > True, but their names on these files is bound to confuse legal folks > looking at the code. I got a private email about these copyrights last > week from a _very_ large company, which is how they came to my > attention. I'm not saying we shouldn't remove the text, but there's no need to rewrite the code. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Dave Page wrote: > On Tue, Feb 2, 2010 at 6:48 PM, Bruce Momjian wrote: > > > The intagg copyright is on a _Makefile_: > > > > ? ? ? ?# Makefile for integer aggregator > > ? ? ? ?# Copyright (C) 2001 Digital Music Network. > > ? ? ? ?# by Mark L. Woodward > > ? ? ? ?# $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 > > 19:58:45 tgl Exp $ > > > > Seems we either have to contact the author or rewrite the file. > > Why? Even if the text is removed, he will still own the copyright, as > is the case for any patch submitted because we don't have any form of > copyright assignment. True, but their names on these files is bound to confuse legal folks looking at the code. I got a private email about these copyrights last week from a _very_ large company, which is how they came to my attention. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
On Tue, Feb 2, 2010 at 6:48 PM, Bruce Momjian wrote: > The intagg copyright is on a _Makefile_: > > # Makefile for integer aggregator > # Copyright (C) 2001 Digital Music Network. > # by Mark L. Woodward > # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 > 19:58:45 tgl Exp $ > > Seems we either have to contact the author or rewrite the file. Why? Even if the text is removed, he will still own the copyright, as is the case for any patch submitted because we don't have any form of copyright assignment. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Greg Stark wrote: > So based on our discussion of last week my understanding is that as long as > these people are content to release the code under the same license then > these statements don't change anything since they're included in the > Postgresql global development group anyways. Yes, I believe that is correct. However, it is confusing to have their copyrights mentioned in our code, so ideally the copyrights would be removed. --- > > greg > > On 2 Feb 2010 19:39, "Bruce Momjian" wrote: > > Some more _personalized_ copyright noticed have crept into our source > tree: > > /src/tutorial/basics.sourceCopyright (c) 1994, Andrew Yu, University of > California > /contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by > Mark L. Woodward > /src/port/rint.c Copyright (c) 1999, repas AEG Automation > GmbH > /contrib/isn/isn.c Copyright (c) 2004-2006, Germn Mndez Bravo > (Kronuz) > /contrib/isn/isn.h Copyright (c) 2004-2006, Germn Mndez Bravo > (Kronuz) > /src/backend/utils/mb/Unicode/UCS_to_GB18030.plCopyright 2002 by Bill > Huang > > Does anyone have contacts to the other people listed? Ideally we can > get them to send the list an email stating their copyright notice can be > removed. > > Below is a summary of each item: > > > I received permission from Andrew Yu to remove a copyright he had on > another file in 2007: > >http://archives.postgresql.org/pgsql-hackers/2007-03/msg01528.php > > I have emailed him to get approval to remove this mention also. > > --- > > The intagg copyright is on a _Makefile_: > ># Makefile for integer aggregator ># Copyright (C) 2001 Digital Music Network. ># by Mark L. Woodward ># $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 > 19:58:45 tgl Exp $ > > Seems we either have to contact the author or rewrite the file. > > --- > > The rint.c file is again tiny: > > * rint.c > *rint() implementation > * > * Copyright (c) 1999, repas AEG Automation GmbH > > Perhaps that just needs to be rewritten. > > --- > > The ISN copyright looks like this: > > * Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) > * Portions Copyright (c) 1996-2010, PostgreSQL Global Development > Group > > Interestingly, he mentions himself and PGDG both in the copyright, which > makese this less of an issue. Looking at the ISN code, it appears he > was the creator of the original file: > >revision 1.1 >date: 2006/09/09 04:07:52; author: tgl; state: Exp; >Add contrib/isn module for ISBN/ISSN/EAN13/etc product numbers, and >remove the old isbn_issn module which is about to be obsoleted by > EAN13. >contrib/isn is by Germn Mndez Bravo. Our thanks to Garrett > A. >Wollman for having written the original isbn_issn module. > > and he asked about his copyright mention as part of the patch > discussion: > >http://archives.postgresql.org/pgsql-hackers/2006-09/msg00794.php > > I never saw the issue actually addressed and the copyright line was > committed. > Do people think it is acceptable? > > --- > > The UCS_to_GB18030.pl is a Perl script with this at the top: > ># Copyright 2002 by Bill Huang > > -- > Bruce Momjian http://momjian.us > EnterpriseDB http://enterprisedb.com > > + If your life is a hard drive, Christ can be your backup. + > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
Bruce Momjian wrote: > > I received permission from Andrew Yu to remove a copyright he had on > another file in 2007: > > http://archives.postgresql.org/pgsql-hackers/2007-03/msg01528.php > > I have emailed him to get approval to remove this mention also. I received an email reply from Andrew Yu stating it is OK to remove his copyright, so I have done so in CVS HEAD and 8.4.X. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Personal Copyright Notices
So based on our discussion of last week my understanding is that as long as these people are content to release the code under the same license then these statements don't change anything since they're included in the Postgresql global development group anyways. greg On 2 Feb 2010 19:39, "Bruce Momjian" wrote: Some more _personalized_ copyright noticed have crept into our source tree: /src/tutorial/basics.sourceCopyright (c) 1994, Andrew Yu, University of California /contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by Mark L. Woodward /src/port/rint.c Copyright (c) 1999, repas AEG Automation GmbH /contrib/isn/isn.c Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) /contrib/isn/isn.h Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) /src/backend/utils/mb/Unicode/UCS_to_GB18030.plCopyright 2002 by Bill Huang Does anyone have contacts to the other people listed? Ideally we can get them to send the list an email stating their copyright notice can be removed. Below is a summary of each item: I received permission from Andrew Yu to remove a copyright he had on another file in 2007: http://archives.postgresql.org/pgsql-hackers/2007-03/msg01528.php I have emailed him to get approval to remove this mention also. --- The intagg copyright is on a _Makefile_: # Makefile for integer aggregator # Copyright (C) 2001 Digital Music Network. # by Mark L. Woodward # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 19:58:45 tgl Exp $ Seems we either have to contact the author or rewrite the file. --- The rint.c file is again tiny: * rint.c *rint() implementation * * Copyright (c) 1999, repas AEG Automation GmbH Perhaps that just needs to be rewritten. --- The ISN copyright looks like this: * Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group Interestingly, he mentions himself and PGDG both in the copyright, which makese this less of an issue. Looking at the ISN code, it appears he was the creator of the original file: revision 1.1 date: 2006/09/09 04:07:52; author: tgl; state: Exp; Add contrib/isn module for ISBN/ISSN/EAN13/etc product numbers, and remove the old isbn_issn module which is about to be obsoleted by EAN13. contrib/isn is by Germn Mndez Bravo. Our thanks to Garrett A. Wollman for having written the original isbn_issn module. and he asked about his copyright mention as part of the patch discussion: http://archives.postgresql.org/pgsql-hackers/2006-09/msg00794.php I never saw the issue actually addressed and the copyright line was committed. Do people think it is acceptable? --- The UCS_to_GB18030.pl is a Perl script with this at the top: # Copyright 2002 by Bill Huang -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Personal Copyright Notices
Some more _personalized_ copyright noticed have crept into our source tree: /src/tutorial/basics.sourceCopyright (c) 1994, Andrew Yu, University of California /contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by Mark L. Woodward /src/port/rint.c Copyright (c) 1999, repas AEG Automation GmbH /contrib/isn/isn.c Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) /contrib/isn/isn.h Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) /src/backend/utils/mb/Unicode/UCS_to_GB18030.plCopyright 2002 by Bill Huang Does anyone have contacts to the other people listed? Ideally we can get them to send the list an email stating their copyright notice can be removed. Below is a summary of each item: I received permission from Andrew Yu to remove a copyright he had on another file in 2007: http://archives.postgresql.org/pgsql-hackers/2007-03/msg01528.php I have emailed him to get approval to remove this mention also. --- The intagg copyright is on a _Makefile_: # Makefile for integer aggregator # Copyright (C) 2001 Digital Music Network. # by Mark L. Woodward # $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10 2008/11/14 19:58:45 tgl Exp $ Seems we either have to contact the author or rewrite the file. --- The rint.c file is again tiny: * rint.c *rint() implementation * * Copyright (c) 1999, repas AEG Automation GmbH Perhaps that just needs to be rewritten. --- The ISN copyright looks like this: * Copyright (c) 2004-2006, Germn Mndez Bravo (Kronuz) * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group Interestingly, he mentions himself and PGDG both in the copyright, which makese this less of an issue. Looking at the ISN code, it appears he was the creator of the original file: revision 1.1 date: 2006/09/09 04:07:52; author: tgl; state: Exp; Add contrib/isn module for ISBN/ISSN/EAN13/etc product numbers, and remove the old isbn_issn module which is about to be obsoleted by EAN13. contrib/isn is by Germn Mndez Bravo. Our thanks to Garrett A. Wollman for having written the original isbn_issn module. and he asked about his copyright mention as part of the patch discussion: http://archives.postgresql.org/pgsql-hackers/2006-09/msg00794.php I never saw the issue actually addressed and the copyright line was committed. Do people think it is acceptable? --- The UCS_to_GB18030.pl is a Perl script with this at the top: # Copyright 2002 by Bill Huang -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers