[HACKERS] Possibly a comment typo in xlogrecord.h
Hello, The comment before declaration of XLogRecordBlockHeader says * 'data_length' is the length of the payload data associated with this, * and includes the possible full-page image, and rmgr-specific data. It IIUC, data_length does not include associated full page image length. Attached patch changes the comment as follows: - * and includes the possible full-page image, and rmgr-specific data. It - * does not include the XLogRecordBlockHeader struct itself. + * and includes the rmgr-specific data. It does not include the possible + * full page image and XLogRecordBlockHeader struct itself. Thank you, Rahila Syed correct_comment_typo_XLogRecordBlockHeader.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Possibly a comment typo in xlogrecord.h
On 12/16/2014 12:44 PM, Rahila Syed wrote: Hello, The comment before declaration of XLogRecordBlockHeader says * 'data_length' is the length of the payload data associated with this, * and includes the possible full-page image, and rmgr-specific data. It IIUC, data_length does not include associated full page image length. Attached patch changes the comment as follows: - * and includes the possible full-page image, and rmgr-specific data. It - * does not include the XLogRecordBlockHeader struct itself. + * and includes the rmgr-specific data. It does not include the possible + * full page image and XLogRecordBlockHeader struct itself. Thanks, fixed! I also reworded the comment slightly, hopefully it's more readable now. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
