Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-21 Thread Vadim Mikheev

> >  Nope.  Still fails...
> > 
> > You should've said that the OIDs are now just off-by-one from where they
> > were before, instead of off by several thousand.  That I'm willing to
> > accept as an implementation change ;-)  I've updated the expected file.
^^
I hope for it -:)

> Actually, pg_shadow' oid for DBA inserted by initdb is 2 now - I'm fixing
> this now...

Fixed.

Vadim





Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-21 Thread Vadim Mikheev

> >  Nope.  Still fails...
> > 
> > You should've said that the OIDs are now just off-by-one from where they
> > were before, instead of off by several thousand.  That I'm willing to
> > accept as an implementation change ;-)  I've updated the expected file.
^^
I hope for it -:)

> Actually, pg_shadow' oid for DBA inserted by initdb is 2 now - I'm fixing
> this now...

Fixed.

Vadim





Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Vadim Mikheev

> >> Larry Rosenman <[EMAIL PROTECTED]> writes:
>  Nope.  Still fails...
> 
> You should've said that the OIDs are now just off-by-one from where they
> were before, instead of off by several thousand.  That I'm willing to
> accept as an implementation change ;-)  I've updated the expected file.

Actually, pg_shadow' oid for DBA inserted by initdb is 2 now - I'm fixing
this now...

Vadim





Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Larry Rosenman

Yeah, I shoulda said off by one...  Tom fixed the 
expected file :-) 

LER

* Vadim Mikheev <[EMAIL PROTECTED]> [001121 00:01]:
> > Nope.  Still fails...
> 
> I know, but looks better, eh? -:)
> 
> > 
> > *** ./expected/opr_sanity.out Tue Nov 14 13:32:58 2000
> > --- ./results/opr_sanity.out Mon Nov 20 20:27:46 2000
> > ***
> > *** 482,489 
> > (p2.pronargs = 1 AND p1.aggbasetype = 0)));
> > oid  | aggname | oid |   proname   
> >   ---+-+-+-
> > !  16998 | max | 768 | int4larger
> > !  17012 | min | 769 | int4smaller
> >   (2 rows)
> >   
> >   -- Cross-check finalfn (if present) against its entry in pg_proc.
> > --- 482,489 
> > (p2.pronargs = 1 AND p1.aggbasetype = 0)));
> > oid  | aggname | oid |   proname   
> >   ---+-+-+-
> > !  16997 | max | 768 | int4larger
> > !  17011 | min | 769 | int4smaller
> >   (2 rows)
> >   
> >   -- Cross-check finalfn (if present) against its entry in pg_proc.
> > 
> > ==
> > 
> > * [EMAIL PROTECTED] <[EMAIL PROTECTED]> [001120 20:11]:
> > >   Date: Monday, November 20, 2000 @ 21:11:06
> > > Author: vadim
> > > 
> > > Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/access/transam
> > >  from 
>hub.org:/home/projects/pgsql/tmp/cvs-serv62721/src/backend/access/transam
> > > 
> > > Modified Files:
> > > xlog.c 
> > > 
> > > -  Log Message  -
> > > 
> > > Init ShmemVariableCache in BootStrapXLOG()
> > > (should fix OID bootstraping).
> > 
> > -- 
> > Larry Rosenman  http://www.lerctr.org/~ler
> > Phone: +1 972-414-9812 (voice) Internet: [EMAIL PROTECTED]
> > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
> > 

-- 
Larry Rosenman  http://www.lerctr.org/~ler
Phone: +1 972-414-9812 (voice) Internet: [EMAIL PROTECTED]
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749



Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Vadim Mikheev

> Nope.  Still fails...

I know, but looks better, eh? -:)

> 
> *** ./expected/opr_sanity.out Tue Nov 14 13:32:58 2000
> --- ./results/opr_sanity.out Mon Nov 20 20:27:46 2000
> ***
> *** 482,489 
> (p2.pronargs = 1 AND p1.aggbasetype = 0)));
> oid  | aggname | oid |   proname   
>   ---+-+-+-
> !  16998 | max | 768 | int4larger
> !  17012 | min | 769 | int4smaller
>   (2 rows)
>   
>   -- Cross-check finalfn (if present) against its entry in pg_proc.
> --- 482,489 
> (p2.pronargs = 1 AND p1.aggbasetype = 0)));
> oid  | aggname | oid |   proname   
>   ---+-+-+-
> !  16997 | max | 768 | int4larger
> !  17011 | min | 769 | int4smaller
>   (2 rows)
>   
>   -- Cross-check finalfn (if present) against its entry in pg_proc.
> 
> ==
> 
> * [EMAIL PROTECTED] <[EMAIL PROTECTED]> [001120 20:11]:
> >   Date: Monday, November 20, 2000 @ 21:11:06
> > Author: vadim
> > 
> > Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/access/transam
> >  from hub.org:/home/projects/pgsql/tmp/cvs-serv62721/src/backend/access/transam
> > 
> > Modified Files:
> > xlog.c 
> > 
> > -  Log Message  -
> > 
> > Init ShmemVariableCache in BootStrapXLOG()
> > (should fix OID bootstraping).
> 
> -- 
> Larry Rosenman  http://www.lerctr.org/~ler
> Phone: +1 972-414-9812 (voice) Internet: [EMAIL PROTECTED]
> US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
> 




Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Larry Rosenman

* Tom Lane <[EMAIL PROTECTED]> [001120 22:34]:
> >> Larry Rosenman <[EMAIL PROTECTED]> writes:
>  Nope.  Still fails...
> 
> You should've said that the OIDs are now just off-by-one from where they
> were before, instead of off by several thousand.  That I'm willing to
> accept as an implementation change ;-)  I've updated the expected file.
Sorry.  Wasn't sure... We now pass
> 
>   regards, tom lane
-- 
Larry Rosenman  http://www.lerctr.org/~ler
Phone: +1 972-414-9812 (voice) Internet: [EMAIL PROTECTED]
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749



Re: [HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Tom Lane

>> Larry Rosenman <[EMAIL PROTECTED]> writes:
 Nope.  Still fails...

You should've said that the OIDs are now just off-by-one from where they
were before, instead of off by several thousand.  That I'm willing to
accept as an implementation change ;-)  I've updated the expected file.

regards, tom lane



[HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Larry Rosenman

* Tom Lane <[EMAIL PROTECTED]> [001120 21:27]:
> Larry Rosenman <[EMAIL PROTECTED]> writes:
> > Nope.  Still fails...
> 
> Did you initdb?
Yes.
> 
>   regards, tom lane
-- 
Larry Rosenman  http://www.lerctr.org/~ler
Phone: +1 972-414-9812 (voice) Internet: [EMAIL PROTECTED]
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749



[HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Tom Lane

Larry Rosenman <[EMAIL PROTECTED]> writes:
> Nope.  Still fails...

Did you initdb?

regards, tom lane



[HACKERS] Re: [COMMITTERS] pgsql/src/backend/access/transam (xlog.c)

2000-11-20 Thread Larry Rosenman


Nope.  Still fails...

*** ./expected/opr_sanity.out   Tue Nov 14 13:32:58 2000
--- ./results/opr_sanity.outMon Nov 20 20:27:46 2000
***
*** 482,489 
(p2.pronargs = 1 AND p1.aggbasetype = 0)));
oid  | aggname | oid |   proname   
  ---+-+-+-
!  16998 | max | 768 | int4larger
!  17012 | min | 769 | int4smaller
  (2 rows)
  
  -- Cross-check finalfn (if present) against its entry in pg_proc.
--- 482,489 
(p2.pronargs = 1 AND p1.aggbasetype = 0)));
oid  | aggname | oid |   proname   
  ---+-+-+-
!  16997 | max | 768 | int4larger
!  17011 | min | 769 | int4smaller
  (2 rows)
  
  -- Cross-check finalfn (if present) against its entry in pg_proc.

==

* [EMAIL PROTECTED] <[EMAIL PROTECTED]> [001120 20:11]:
>   Date: Monday, November 20, 2000 @ 21:11:06
> Author: vadim
> 
> Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/access/transam
>  from hub.org:/home/projects/pgsql/tmp/cvs-serv62721/src/backend/access/transam
> 
> Modified Files:
>   xlog.c 
> 
> -  Log Message  -
> 
> Init ShmemVariableCache in BootStrapXLOG()
> (should fix OID bootstraping).

-- 
Larry Rosenman  http://www.lerctr.org/~ler
Phone: +1 972-414-9812 (voice) Internet: [EMAIL PROTECTED]
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749