[HACKERS] Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti
On Fri, Apr 4, 2014 at 10:32 AM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: In checkpoint, move the check for in-progress xacts out of critical section. GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical section. I thought I covered this case with the exemption for the checkpointer, but CreateCheckPoint is also called from the startup process. This commit un-broke make check, which you might have wanted to run before committing, but make -C src/test/isolation check is still broken. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti
On 04/04/2014 06:06 PM, Robert Haas wrote: On Fri, Apr 4, 2014 at 10:32 AM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: In checkpoint, move the check for in-progress xacts out of critical section. GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical section. I thought I covered this case with the exemption for the checkpointer, but CreateCheckPoint is also called from the startup process. This commit un-broke make check, which you might have wanted to run before committing, but make -C src/test/isolation check is still broken. Yeah.. Fixed now. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
