Re: [HACKERS] Release notes of 9.0~9.3 mentioning recovery_min_apply_delay incorrectly

2016-01-02 Thread Tom Lane 
Michael Paquier  writes:
> This is obviously incorrect because recovery_min_apply_delay has been only
> introduced in 9.4. The culprit is visibly the commit message of 8049839 and
> others that mentioned the parameter, though the patch applied does nothing
> about it. Please see attached a patch to fix that.

Good catch!  That's on me I guess for not checking what the patch had done
in the back branches.

I didn't like simply deleting any description of the patch's effects, though.
Instead I made it talk about recovery_target_xid, which does exist in all
those branches.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Release notes of 9.0~9.3 mentioning recovery_min_apply_delay incorrectly

2016-01-02 Thread Michael Paquier 
Hi all,

While doing a git grep on recovery_min_apply_delay I noticed the following:
$ git grep recovery_min_apply -- *release*.sgml
src/sgml/release-9.0.sgml:  that recovery_min_apply_delay
failed to delay application
src/sgml/release-9.1.sgml:  that recovery_min_apply_delay
failed to delay application
src/sgml/release-9.2.sgml:  that recovery_min_apply_delay
failed to delay application
src/sgml/release-9.3.sgml:  that recovery_min_apply_delay
failed to delay application
src/sgml/release-9.4.sgml:  Avoid busy-waiting with short
recovery_min_apply_delay

This is obviously incorrect because recovery_min_apply_delay has been only
introduced in 9.4. The culprit is visibly the commit message of 8049839 and
others that mentioned the parameter, though the patch applied does nothing
about it. Please see attached a patch to fix that.
Regards,
-- 
Michael
diff --git a/doc/src/sgml/release-9.0.sgml b/doc/src/sgml/release-9.0.sgml
index ef8eb1c..de6550f 100644
--- a/doc/src/sgml/release-9.0.sgml
+++ b/doc/src/sgml/release-9.0.sgml
@@ -1493,12 +1493,6 @@
   Fix several cases where recovery logic improperly ignored WAL records
   for COMMIT/ABORT PREPARED (Heikki Linnakangas)
  
-
- 
-  The most notable oversight was
-  that recovery_min_apply_delay failed to delay application
-  of a two-phase commit.
- 
 
 
 
diff --git a/doc/src/sgml/release-9.1.sgml b/doc/src/sgml/release-9.1.sgml
index fde6b61..ef2e849 100644
--- a/doc/src/sgml/release-9.1.sgml
+++ b/doc/src/sgml/release-9.1.sgml
@@ -1663,12 +1663,6 @@ Branch: REL9_0_STABLE [9d6af7367] 2015-08-15 11:02:34 -0400
   Fix several cases where recovery logic improperly ignored WAL records
   for COMMIT/ABORT PREPARED (Heikki Linnakangas)
  
-
- 
-  The most notable oversight was
-  that recovery_min_apply_delay failed to delay application
-  of a two-phase commit.
- 
 
 
 
diff --git a/doc/src/sgml/release-9.2.sgml b/doc/src/sgml/release-9.2.sgml
index 4bfede5..72203fb 100644
--- a/doc/src/sgml/release-9.2.sgml
+++ b/doc/src/sgml/release-9.2.sgml
@@ -1848,12 +1848,6 @@ Branch: REL9_2_STABLE [6b700301c] 2015-02-17 16:03:00 +0100
   Fix several cases where recovery logic improperly ignored WAL records
   for COMMIT/ABORT PREPARED (Heikki Linnakangas)
  
-
- 
-  The most notable oversight was
-  that recovery_min_apply_delay failed to delay application
-  of a two-phase commit.
- 
 
 
 
diff --git a/doc/src/sgml/release-9.3.sgml b/doc/src/sgml/release-9.3.sgml
index 1ac6abe..a1a7781 100644
--- a/doc/src/sgml/release-9.3.sgml
+++ b/doc/src/sgml/release-9.3.sgml
@@ -2413,12 +2413,6 @@ Branch: REL9_0_STABLE [804983961] 2014-07-29 11:58:17 +0300
   Fix several cases where recovery logic improperly ignored WAL records
   for COMMIT/ABORT PREPARED (Heikki Linnakangas)
  
-
- 
-  The most notable oversight was
-  that recovery_min_apply_delay failed to delay application
-  of a two-phase commit.
-