Re: [HACKERS] Schedule for 8.1 feature freeze
Bruce Momjian wrote:
Andrew Dunstan wrote:
There is also the tiny patch to trap lexical warnings I submitted not
long ago still outstanding.
OK, I missed that one. I see it at:
http://archives.postgresql.org/pgsql-patches/2005-06/msg00280.php
I applied the attached patch from the following URL. The URL does not
have separate file names for the regression tests so I did not add
those.
Thanks.
--
Bruce Momjian| http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
Index: src/pl/plperl/GNUmakefile
===
RCS file: /cvsroot/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.22
retrieving revision 1.23
diff -c -r1.22 -r1.23
*** src/pl/plperl/GNUmakefile 24 May 2005 17:07:41 - 1.22
--- src/pl/plperl/GNUmakefile 6 Jul 2005 22:33:39 - 1.23
***
*** 1,5
# Makefile for PL/Perl
! # $PostgreSQL: pgsql/src/pl/plperl/GNUmakefile,v 1.22 2005/05/24 17:07:41 tgl
Exp $
subdir = src/pl/plperl
top_builddir = ../../..
--- 1,5
# Makefile for PL/Perl
! # $PostgreSQL: pgsql/src/pl/plperl/GNUmakefile,v 1.23 2005/07/06 22:33:39
momjian Exp $
subdir = src/pl/plperl
top_builddir = ../../..
***
*** 37,43
SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS)
REGRESS_OPTS = --dbname=$(PL_TESTDB) --load-language=plperl
! REGRESS = plperl plperl_trigger plperl_shared
include $(top_srcdir)/src/Makefile.shlib
--- 37,43
SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS)
REGRESS_OPTS = --dbname=$(PL_TESTDB) --load-language=plperl
! REGRESS = plperl plperl_trigger plperl_shared plperl_elog
include $(top_srcdir)/src/Makefile.shlib
Index: src/pl/plperl/plperl.c
===
RCS file: /cvsroot/pgsql/src/pl/plperl/plperl.c,v
retrieving revision 1.79
retrieving revision 1.80
diff -c -r1.79 -r1.80
*** src/pl/plperl/plperl.c 3 Jul 2005 21:56:16 - 1.79
--- src/pl/plperl/plperl.c 6 Jul 2005 22:33:39 - 1.80
***
*** 33,39
* ENHANCEMENTS, OR MODIFICATIONS.
*
* IDENTIFICATION
! * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.79 2005/07/03 21:56:16
tgl Exp $
*
**/
--- 33,39
* ENHANCEMENTS, OR MODIFICATIONS.
*
* IDENTIFICATION
! * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.80 2005/07/06 22:33:39
momjian Exp $
*
**/
***
*** 190,195
--- 190,197
, -e,
/* all one string follows (no commas please) */
SPI::bootstrap(); use vars qw(%_SHARED);
+ sub ::plperl_warn { my $msg = shift; elog(NOTICE, $msg); }
+ $SIG{__WARN__} = \\::plperl_warn;
sub ::mkunsafefunc {return eval(qq[ sub { $_[0] $_[1] } ]); }
};
***
*** 197,202
--- 199,206
, -e,
/* all one string follows (no commas please) */
SPI::bootstrap(); use vars qw(%_SHARED);
+ sub ::plperl_warn { my $msg = shift; elog(NOTICE, $msg); }
+ $SIG{__WARN__} = \\::plperl_warn;
sub ::mkunsafefunc {return eval(
qq[ sub { use strict; $_[0] $_[1] } ]); }
};
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
Re: [HACKERS] Schedule for 8.1 feature freeze
Bruce Momjian wrote: Bruce Momjian wrote: Andrew Dunstan wrote: There is also the tiny patch to trap lexical warnings I submitted not long ago still outstanding. OK, I missed that one. I see it at: http://archives.postgresql.org/pgsql-patches/2005-06/msg00280.php I applied the attached patch from the following URL. The URL does not have separate file names for the regression tests so I did not add those. Never mind, I found the right patch. Will add regressions. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] Schedule for 8.1 feature freeze
Dear Stephen, I'd really like to see role support added into 8.1. I'm also pretty interested in this, and was planing loosely to think about implementing roles someday. It is even better if it is done by someone else;-) I've sent Alvaro and Tom versions of the patch in the past and I was planning on submitting it to -patches soon. There's a few remaining issue but I don't think they'll take very long to clean up; I've just been unfortunately pretty busy lately. I'm hopeful that I'll be able to spend some time on it this week and next week to hopefully address at least the remaining issues on my list. I could not find this patch, although I wanted to have a look. After some thinking on the subjet, ISTM that there are 4 key issues for roles to be really interesting in postgresql, and I just wanted to state them: (1) the role rights should *supercede* group/user rights. E.g. if an admin chose to act in the role readonly-client, then it should be restricted to what this role allows. (2) roles should be per *catalog* (database), not per cluster (installation) as user and group. (3) role management should be a natural privilege of the database *owner*. (4) user/group/role will make permission denied errors even harder to comprehend and solve as they are already, so instead of permission denied on table foo, give a more precise form such as permission denied on table foo, cannot perform update in role bla. Otherwise ISTM that role would not be an improvement over the current group concept in postgresql. Maybe it is already what was submitted, but as I could not check... Thanks for working on this useful feature, have a nice day, -- Fabien. ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
Re: [HACKERS] Schedule for 8.1 feature freeze
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Bruce Momjian Sent: 21 June 2005 05:04 To: PostgreSQL-development Subject: [HACKERS] Schedule for 8.1 feature freeze We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. What about Andreas' instrumentation stuff? This has been going on since before 8.0 and it would good to get it in 8.1 given the amount of extra functionality it allows us to offer users that prefer a GUI interface. I realise there probably won't be time to fix pg_terminate_backend, or convince people that it offers the admin the lesser of two evils (my limited understanding being that there is a chance of it not clearing some locks, vs, having to shut down the whole server to kill a single connection) - can we at least get the other functions applied? Thanks, Dave. ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [HACKERS] Schedule for 8.1 feature freeze
We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. I don't beleive we have :-( The server instrumentation patch is not yet addressed. Last I checked there was the objections to pg_terminate_backend (which are certainly valid,though I and many other still claim this is in daily use at *a lot* of installations), and nothing substantial to the rest of the patch. yet it hasn't even made it to the queue (the patch would still be very useful with just the parts except pg_terminate_backend). I beleive Andreas is working on separating out the pg_terminate_backend part to a separate patch to make it easier for whomever would apply it. There is also the ICU patch. this is *very* much needed for win32, and from how I read it it's also needed for other platforms. Last I heard Palle planned to have it fixed up before feature freeze (I'm not sure exactly what more needed to be fixed). If not then we have to do something else about unicode on win32 (perhaps under the flag of bugfix, but I'm sure it will be more invasive than most would like). But I realy think a cross-platform thing like ICU is much better. And there's a pending patch that redoes signal handling on win32. I haven't had the time to check it through myself, as I've been unexpectedly-out-of-town several times lately, but it was posted some time ago and shoudl probalby be at least considered. (I'm not 100% sure it's a worthwhile simplification myself, but I'll have to look into it muc more careful before I can form an actual opinion on it) Finally a heads-up: I'm looking at an updated patch to remove the Kerberos V4 support. I posted to both hackers and general a month ago asking for people who use it for exactly zero responses. It's not quite done yet, but I plan to have it done before July 1st. But it's definitly not something to hold up a freeze date for if I'm not. Is there an Open Issues list yet, as you usually prepare for releases? If so, can you please put these items up on it? //Magnus ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [HACKERS] Schedule for 8.1 feature freeze
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Bruce Momjian Sent: 21 June 2005 05:04 To: PostgreSQL-development Subject: [HACKERS] Schedule for 8.1 feature freeze We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. Bruce, we're working on GiST concurrency which is based on GiST recovery code already submitted. Hopefully, we'll submit patch before July 1. There is also one problem we already discussed - we have no gist opclasses in core we could use for regression tests ! Probably, it's a time we need to add some opclasses from intarray or rtree_gist to core ? btw, there was a noise about funding of our work, but I've contacted only with PostGis guys about real contribution. I'm just wondered if any commercial clones do really understand the importance of our work. Should I write some explanation what're recovery and concurrency for GiST ? Regards, Oleg _ Oleg Bartunov, sci.researcher, hostmaster of AstroNet, Sternberg Astronomical Institute, Moscow University (Russia) Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(095)939-16-83, +007(095)939-23-83 ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [HACKERS] Schedule for 8.1 feature freeze
* Bruce Momjian (pgman@candle.pha.pa.us) wrote: We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. Bruce, I'd really like to see role support added into 8.1. I've sent Alvaro and Tom versions of the patch in the past and I was planning on submitting it to -patches soon. There's a few remaining issue but I don't think they'll take very long to clean up; I've just been unfortunately pretty busy lately. I'm hopeful that I'll be able to spend some time on it this week and next week to hopefully address at least the remaining issues on my list. Lookups need to do multi-level role resolution (for owner and other ACL areas) (Not very hard, and mostly isolated to the acl code) Need to implement per-backend role-member cacheing (Not very hard, basically same kind of way pg_namespace does schema_path) Support 'grant role to role' (Shouldn't be too difficult, mainly just parser work) Support 'with admin option' (Somewhat difficult, but not necessary for the same functionality we have today) Support 'granted by' (Not very hard, just parser work really) Fix other parsers (ecpg, etc) based on updates to backend/parser. (Worked on this some already, should be done real soon now) Distinguish 'create role' permissions from 'superuser'? (Not sure if this makes sense) Modify \du, \dg to use new tables (They work already using the backwards-compat views, just would be nice to update them to the new schema). ? Add \dr, \dm (Should be easy and would be nice I think, though perhaps not required) Add documentation for CREATE ROLE/etc Document new system catalogs (pg_authid, pg_auth_members) (Documentation updates) There are views for pg_shadow/pg_group and things seem to be happy with them. CREATE USER/CREATE GROUP work more-or-less as expected. An interesting side-effect is that if you do 'create group' and then look in the 'group' table you don't see the group till you actually put users in it. Not entirely sure if anything actually depends on that (You can, after all, still grant rights to the role which was created by CREATE GROUP, and do ALTER GROUP on it, etc). Thanks, Stephen signature.asc Description: Digital signature
Re: [HACKERS] Schedule for 8.1 feature freeze
Stephen Frost [EMAIL PROTECTED] writes: I'd really like to see role support added into 8.1. I've sent Alvaro and Tom versions of the patch in the past and I was planning on submitting it to -patches soon. There's a few remaining issue but I don't think they'll take very long to clean up; I've just been unfortunately pretty busy lately. I'm hopeful that I'll be able to spend some time on it this week and next week to hopefully address at least the remaining issues on my list. Stephen, it is not going to be acceptable to sit on that patch until June 30 --- there are other things depending on it. If you don't have time for it now, send in what you have so that someone else can pick up the ball. regards, tom lane ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [HACKERS] Schedule for 8.1 feature freeze
* Tom Lane ([EMAIL PROTECTED]) wrote: Stephen Frost [EMAIL PROTECTED] writes: I'd really like to see role support added into 8.1. I've sent Alvaro and Tom versions of the patch in the past and I was planning on submitting it to -patches soon. There's a few remaining issue but I don't think they'll take very long to clean up; I've just been unfortunately pretty busy lately. I'm hopeful that I'll be able to spend some time on it this week and next week to hopefully address at least the remaining issues on my list. Stephen, it is not going to be acceptable to sit on that patch until June 30 --- there are other things depending on it. If you don't have time for it now, send in what you have so that someone else can pick up the ball. Sorry, I thought that's what I had been doing when sending to you/Alvaro/-hackers earlier.. I'll send in what I've got and I guess see what happens. I'm planning on still working on it when I have time available so if someone else picks it up to work on it, please let me know so we can coordinate. Thanks, Stephen signature.asc Description: Digital signature
Re: [HACKERS] Schedule for 8.1 feature freeze
Bruce Momjian pgman@candle.pha.pa.us writes: We have addressed all the open issues for 8.1 except for auto-vacuum, Aside from the other stuff people mentioned, I have these things on my to-look-at list: * Fix pg_dump to be able to dump large objects in text dumps * Fix inherited constraints (per discussion around 5/20) * Fix reporting of table/column numbers for cursors (per DeSoi, 4/9) * statement_timeout does not behave very reasonably for V3 messages And I'd really like to see pg_role and shared dependencies get in... regards, tom lane ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] Schedule for 8.1 feature freeze
Bruce Momjian wrote: We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. FYI - plperl status. I am trying to get the following 2 items done by feature freeze: . convert returned perl array to pg array (see patch recently sent for discussion) . validator function The remaining memory issue we have is where plperl does a huge select via SPI. Abhijit Menon-Sen was working on this but is stumped on how to proceed (see his previous message). We have a patch from CommandPrompt which apparently improves the situation, although it doesn't solve the basic problem. If we don't make progress with Abhijit's work, I will look at working that up by July 1. There is also the tiny patch to trap lexical warnings I submitted not long ago still outstanding. cheers andrew ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [HACKERS] Schedule for 8.1 feature freeze
I'll do my best to submit bitmap index AM patch next week for your review. -- Victor Y. Yegorov ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [HACKERS] Schedule for 8.1 feature freeze
Andrew Dunstan wrote: There is also the tiny patch to trap lexical warnings I submitted not long ago still outstanding. OK, I missed that one. I see it at: http://archives.postgresql.org/pgsql-patches/2005-06/msg00280.php However, I don't see the new regession files attached to that URL. Would you repost please? -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [HACKERS] Schedule for 8.1 feature freeze
Magnus Hagander wrote: Is there an Open Issues list yet, as you usually prepare for releases? If so, can you please put these items up on it? Yes, it is at: This item has been added to the 7.4 open items list: http://candle.pha.pa.us/cgi-bin/pgopenitems It did contain only pgautovacuum, but has been updated with the new items. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] Schedule for 8.1 feature freeze
On Jun 21, 2005, at 1:03 PM, Bruce Momjian wrote: We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. I'm hoping to add documentation and regression tests for interval- day over the next couple of days and have that ready for 8.1 as well. Michael Glaesemann grzm myrealbox com ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [HACKERS] Schedule for 8.1 feature freeze
On Jun 21, 2005, at 1:03 PM, Bruce Momjian wrote: We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. I'm hoping to add documentation and regression tests for interval- day over the next couple of days and have that ready for 8.1 as well. Michael Glaesemann grzm myrealbox com ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [HACKERS] Schedule for 8.1 feature freeze
People: Oh, and in implementing the COPY stuff we realized that there weren't any regression tests for encodings. If we can figure out how to do them, we'll add those. Are new regression tests permitted during beta? -- --Josh Josh Berkus Aglio Database Solutions San Francisco ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [HACKERS] Schedule for 8.1 feature freeze
On Tue, 21 Jun 2005, Josh Berkus wrote: People: Oh, and in implementing the COPY stuff we realized that there weren't any regression tests for encodings. If we can figure out how to do them, we'll add those. Are new regression tests permitted during beta? Yes, most definitely ... especially if they happen to pick up a bug at the same time :) Anything that improves *testing* or *documentation* should be no-brainers for addition during the release process, since they both improve the end product without affecting the backend code itself ... Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: [EMAIL PROTECTED] Yahoo!: yscrappy ICQ: 7615664 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [HACKERS] Schedule for 8.1 feature freeze
Josh Berkus josh@agliodbs.com writes: Oh, and in implementing the COPY stuff we realized that there weren't any regression tests for encodings. If we can figure out how to do them, we'll add those. Are new regression tests permitted during beta? Certainly. Feature freeze is about features, not correctness ... regards, tom lane ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] Schedule for 8.1 feature freeze
Bruce Momjian wrote: We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. It would be nice to upgrade to autoconf 2.59 before the freeze (although it would probably be okay to do this post-freeze but pre-beta). -Neil ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[HACKERS] Schedule for 8.1 feature freeze
We have addressed all the open issues for 8.1 except for auto-vacuum, which Alvaro is working on, so I think we are ready for a feature freeze on July 1. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
