Re: [HACKERS] Typo in parallel comment of heap_delete()

[Robert Haas]

On Thu, Jun 16, 2016 at 12:32 AM, Thomas Munro
 wrote:
> On Tue, Jun 7, 2016 at 12:00 AM, Robert Haas  wrote:
>> On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby  wrote:
>>> I'm pretty sure this is a typo...
>>
>> Sure is.  Thanks.
>
> The same typo appears in heap_update.

Commited.

> PS Far be it from me, but postgres_fdw.c seems to have a stray
> conditional form where I would expect a present subjunctive:  "...
> lest the new path *would* kick ..."
> /me ducks

Rephrased.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel comment of heap_delete()

[Thomas Munro]

On Tue, Jun 7, 2016 at 12:00 AM, Robert Haas  wrote:
> On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby  wrote:
>> I'm pretty sure this is a typo...
>
> Sure is.  Thanks.

The same typo appears in heap_update.

PS Far be it from me, but postgres_fdw.c seems to have a stray
conditional form where I would expect a present subjunctive:  "...
lest the new path *would* kick ..."
/me ducks

-- 
Thomas Munro
http://www.enterprisedb.com


lest.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel comment of heap_delete()

[Robert Haas]

On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby  wrote:
> I'm pretty sure this is a typo...

Sure is.  Thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Typo in parallel comment of heap_delete()

[Jim Nasby]

I'm pretty sure this is a typo...
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)   mobile: 512-569-9461
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 950bfc8..c061507 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -3019,7 +3019,7 @@ heap_delete(Relation relation, ItemPointer tid,
Assert(ItemPointerIsValid(tid));
 
/*
-* Forbid this during a parallel operation, lets it allocate a combocid.
+* Forbid this during a parallel operation, lest it allocate a combocid.
 * Other workers might need that combocid for visibility checks, and we
 * have no provision for broadcasting it to them.
 */

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers