Re: [HACKERS] Useless mention of RMGRDESCSOURCES in src/bin/pg_rewind/Makefile
On Tue, Jun 9, 2015 at 1:39 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, pg_rewind's Makefile uses RMGRDESCSOURCES: EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c However this variable is defined only in the Makefile of pg_xlogdump so it has no utility in this case. Attached is a cleanup patch. Good catch. Patch applied. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Useless mention of RMGRDESCSOURCES in src/bin/pg_rewind/Makefile
Hi all, pg_rewind's Makefile uses RMGRDESCSOURCES: EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c However this variable is defined only in the Makefile of pg_xlogdump so it has no utility in this case. Attached is a cleanup patch. Regards, -- Michael diff --git a/src/bin/pg_rewind/Makefile b/src/bin/pg_rewind/Makefile index 98213c4..7d60715 100644 --- a/src/bin/pg_rewind/Makefile +++ b/src/bin/pg_rewind/Makefile @@ -24,7 +24,7 @@ OBJS = pg_rewind.o parsexlog.o xlogreader.o datapagemap.o timeline.o \ fetch.o file_ops.o copy_fetch.o libpq_fetch.o filemap.o logging.o \ $(WIN32RES) -EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c +EXTRA_CLEAN = xlogreader.c all: pg_rewind -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
