Re: [HACKERS] getting carriage return character in vacuumo
Martijn van Oosterhout wrote: -- Start of PGP signed section. On Fri, Apr 08, 2011 at 02:10:56PM -0400, Tom Lane wrote: Muhammad Usama m.us...@gmail.com writes: While using the vacuumlo utility I encountered a redundant carriage return(\r') character in the output. It is required in any scenario? If not, please find attached a tiny patch which will get rid of that extra '\r' character. I think the idea there is to overwrite successive progress messages on the same line. It's maybe not going to work in all environments, though, so perhaps we should reconsider that bit of cuteness. One could hinge it on batch or non-batch mode, the default being determined by whether it's running in a terminal or not. pg_upgrade also uses this \r status update trick unconfitionally. Should we fix these? -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] getting carriage return character in vacuumo
On Fri, Apr 08, 2011 at 02:10:56PM -0400, Tom Lane wrote: Muhammad Usama m.us...@gmail.com writes: While using the vacuumlo utility I encountered a redundant carriage return(\r') character in the output. It is required in any scenario? If not, please find attached a tiny patch which will get rid of that extra '\r' character. I think the idea there is to overwrite successive progress messages on the same line. It's maybe not going to work in all environments, though, so perhaps we should reconsider that bit of cuteness. One could hinge it on batch or non-batch mode, the default being determined by whether it's running in a terminal or not. Have a nice day, -- Martijn van Oosterhout klep...@svana.org http://svana.org/kleptog/ Patriotism is when love of your own people comes first; nationalism, when hate for people other than your own comes first. - Charles de Gaulle signature.asc Description: Digital signature
[HACKERS] getting carriage return character in vacuumo
Hi, While using the vacuumlo utility I encountered a redundant carriage return(\r') character in the output. It is required in any scenario? If not, please find attached a tiny patch which will get rid of that extra '\r' character. Regards, Usama carriage_return_in_vacuumlo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] getting carriage return character in vacuumo
Muhammad Usama m.us...@gmail.com writes: While using the vacuumlo utility I encountered a redundant carriage return(\r') character in the output. It is required in any scenario? If not, please find attached a tiny patch which will get rid of that extra '\r' character. I think the idea there is to overwrite successive progress messages on the same line. It's maybe not going to work in all environments, though, so perhaps we should reconsider that bit of cuteness. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
