Re: [HACKERS] improve release-note for pg_current_logfile()
>>> Add function pg_current_logfile() to read syslog's current stderr and >>> csvlog output file names (Gilles Darold) >> >> This confused me because "syslog" is one of method for logging as well >> as stderr and csvlog. I guess it is intended syslogger, but I think that >> "logging collector" is more convenient for users because this is used in >> the pg_current_logfile() documentation. > > His proposal is changing the line above to: > > Add function pg_current_logfile() to read logging collector's current stderr > and csvlog output file names (Gilles Darold) > > Looks reasonable fix to me. If there's no objection, I will commit > this. Done. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] improve release-note for pg_current_logfile()
>> Add function pg_current_logfile() to read syslog's current stderr and csvlog >> output file names (Gilles Darold) > > This confused me because "syslog" is one of method for logging as well > as stderr and csvlog. I guess it is intended syslogger, but I think that > "logging collector" is more convenient for users because this is used in > the pg_current_logfile() documentation. His proposal is changing the line above to: Add function pg_current_logfile() to read logging collector's current stderr and csvlog output file names (Gilles Darold) Looks reasonable fix to me. If there's no objection, I will commit this. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] improve release-note for pg_current_logfile()
Hi, When I am reading the PG 10 release-notes, I found the following item. > Add function pg_current_logfile() to read syslog's current stderr and csvlog > output file names (Gilles Darold) This confused me because "syslog" is one of method for logging as well as stderr and csvlog. I guess it is intended syslogger, but I think that "logging collector" is more convenient for users because this is used in the pg_current_logfile() documentation. pg_current_logfile returns, as text, the path of the log file(s) currently in use by the logging collector. Attached is a patch to fix it. Regards, -- Yugo Nagata release_note_pg_current_logfile.pach Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers