Re: [HACKERS] simplehash.h typo
On 06/05/2017 11:26 AM, Andres Freund wrote: On 2017-06-05 11:10:12 +0300, Heikki Linnakangas wrote: Fixed, thanks. I also fixed and clarified some other comments in the file that seemed wrong or confusing to me. Thanks for looking - I don't see any commit though? Pushed now. Note to self: remove --dry-run when you intend to commit for real :-). - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] simplehash.h typo
On 2017-06-05 11:10:12 +0300, Heikki Linnakangas wrote: > On 05/28/2017 04:50 AM, Jeff Janes wrote: > > /* round up size to the next power of 2, that's the bucketing works */ > > > > > > That should probably be "that's the **way** bucketing works". Or maybe it > > is an idiom I don't grok. No, you're perfectly right! > Fixed, thanks. I also fixed and clarified some other comments in the file > that seemed wrong or confusing to me. Thanks for looking - I don't see any commit though? - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] simplehash.h typo
On 05/28/2017 04:50 AM, Jeff Janes wrote: /* round up size to the next power of 2, that's the bucketing works */ That should probably be "that's the **way** bucketing works". Or maybe it is an idiom I don't grok. Fixed, thanks. I also fixed and clarified some other comments in the file that seemed wrong or confusing to me. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] simplehash.h typo
/* round up size to the next power of 2, that's the bucketing works */ That should probably be "that's the **way** bucketing works". Or maybe it is an idiom I don't grok. Cheers, Jeff
Re: [HACKERS] simplehash.h typo fix
Hi, On 2016-10-18 09:41:14 +0200, Erik Rijkers wrote: > it's -> its > the the -> the Thanks! Committed. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] simplehash.h typo fix
it's -> its the the -> the--- ./src/include/lib/simplehash.h.orig 2016-10-18 09:31:22.712028458 +0200 +++ ./src/include/lib/simplehash.h 2016-10-18 09:37:00.050970588 +0200 @@ -256,7 +256,7 @@ return curelem; } -/* return distance between bucket and it's optimal position */ +/* return distance between bucket and its optimal position */ static inline uint32 SH_DISTANCE_FROM_OPTIMAL(SH_TYPE *tb, uint32 optimal, uint32 bucket) { @@ -349,7 +349,7 @@ * * To be able to simply move entries over, we have to start not at the * first bucket (i.e olddata[0]), but find the first bucket that's either - * empty, or is occupied by an entry at it's optimal position. Such a + * empty, or is occupied by an entry at its optimal position. Such a * bucket has to exist in any table with a load factor under 1, as not all * buckets are occupied, i.e. there always has to be an empty bucket. By * starting at such a bucket we can move the entries to the larger table, @@ -485,9 +485,9 @@ /* * If the bucket is not empty, we either found a match (in which case * we're done), or we have to decide whether to skip over or move the - * colliding entry. When the the colliding elements distance to it's + * colliding entry. When the colliding elements distance to its * optimal position is smaller than the to-be-inserted entry's, we - * shift the colliding entry (and it's followers) forward by one. + * shift the colliding entry (and its followers) forward by one. */ if (SH_COMPARE_KEYS(tb, hash, key, entry)) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers