Re: [HACKERS] Re: [COMMITTERS] pgsql: Cause pg_proc.probin to be declared as text, not bytea.
Greg Stark wrote: On Tue, Aug 4, 2009 at 2:46 PM, Tom Lanet...@sss.pgh.pa.us wrote: I'll point out though that having probin declared bytea would surely be antithetical to any attempt to treat shlib filenames in an encoding-aware fashion. Declaring it that way implies that it is *not* storing a character string that has any particular encoding. Well that's kind of the point. Unix filesystems traditionally prohibit '/' and '\0' but otherwise allowing any series of bytes without requiring any particular encoding. If we used bytea to store filesystem paths then you could specify any arbitrary series of bytes without worrying that the server will re-encode it differently. Is this any different from the path in COPY foo to '/path/to/file'? I suspect the probin stuff is a solution in search of a problem. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Cause pg_proc.probin to be declared as text, not bytea.
Andrew Dunstan and...@dunslane.net writes: Is this any different from the path in COPY foo to '/path/to/file'? I suspect the probin stuff is a solution in search of a problem. Well, the previous probin behavior is demonstrably broken. Make a shlib with backslash or non-ASCII in the name, create a function referencing it, dump and reload. Whatever your opinions are about encodings, you won't think pg_dump did the right thing. I'm not sure whether the more general pathname encoding issue is worth working on or not. In general it's a non-problem if the paths in the server filesystem are written in the database encoding. If they are not, then you have to figure out what they *are* written in, and that seems a bit tough. But anyway that problem is hardly restricted to probin, and a solution that works only for probin doesn't seem terribly interesting. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
