Re: [HACKERS] patch for space around the FragmentDelimiter

2009-03-01 Thread Tom Lane
Sushant Sinha sushant...@gmail.com writes:
 FragmentDelimiter is an argument for ts_headline function to separates
 different headline fragments. The default delimiter is  ... .
 Currently if someone specifies the delimiter as an option to the
 function, no extra space is added around the delimiter. However, it does
 not look good without space around the delimter. 

Maybe not to you, for the particular delimiter you happen to be working
with, but it doesn't follow that spaces are always appropriate.

 Since the option parsing function removes any space around the  given
 value, it is not possible to add any desired space. The attached patch
 adds space when a FragmentDelimiter is specified.

I think this is a pretty bad idea.  Better would be to document how to
get spaces into the delimiter, ie, use double quotes:

... FragmentDelimiter =  ...  ...

Hmm, actually, it looks to me that the documentation already shows this,
in the example of the default values.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] patch for space around the FragmentDelimiter

2009-03-01 Thread Sushant Sinha
yeah you are right. I did not know that you can pass space using double
quotes.

-Sushant.

On Sun, 2009-03-01 at 20:49 -0500, Tom Lane wrote:
 Sushant Sinha sushant...@gmail.com writes:
  FragmentDelimiter is an argument for ts_headline function to separates
  different headline fragments. The default delimiter is  ... .
  Currently if someone specifies the delimiter as an option to the
  function, no extra space is added around the delimiter. However, it does
  not look good without space around the delimter. 
 
 Maybe not to you, for the particular delimiter you happen to be working
 with, but it doesn't follow that spaces are always appropriate.
 
  Since the option parsing function removes any space around the  given
  value, it is not possible to add any desired space. The attached patch
  adds space when a FragmentDelimiter is specified.
 
 I think this is a pretty bad idea.  Better would be to document how to
 get spaces into the delimiter, ie, use double quotes:
 
   ... FragmentDelimiter =  ...  ...
 
 Hmm, actually, it looks to me that the documentation already shows this,
 in the example of the default values.
 
   regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers