Re: [PATCHES] Win32 tablespace
It was, next update got it! Of course I found the src/utils issue then However, with the patch for that applied I can confirm a successful build! (create/drop tablespace works too) regards Mark Quoting Bruce Momjian [EMAIL PROTECTED]: Nope, you need Makefile 1.15. Must be a lag. ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Win32 tablespace
[EMAIL PROTECTED] wrote: (create/drop tablespace works too) I can *not* confirm this; after configure; make clean; make; make install I got tablespace not supported. pg_config.h lacks HAVE_SYMLINK=1. Regards, Andreas ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [PATCHES] Win32 fix for pg_dumpall
Bruce Momjian wrote:
/*
+ * Sometime the child returns \r\n, which doesn't match
+ * our version string. The backend uses
+ * setvbuf(stdout, NULL, _IONBF, 0), but pg_dump doesn't
+ * so we have to fix it here.
+ */
+ if (strlen(line) = 2
+ line[strlen(line)-2] == '\r'
+ line[strlen(line)-1] == '\n')
+ {
+ line[strlen(line)-2] == '\n';
+ line[strlen(line)-1] == '\0';
+ }
+
+ /*
I do not see how the comment relates at all to the code following it -
buffer mode and line end mode are two different things. Also, the
repeated calls to strlen(line) are horribly inefficient - it should be
called once and stashed in an int (I once made an order of magnitude
speedup in a program by correcting a piece of someone else's code that
looked like this: for (i = 0; i = strlen(s); i++) where s was an
invariant very long string)
cheers
andrew
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Win32 tablespace
[EMAIL PROTECTED] wrote: It was, next update got it! Of course I found the src/utils issue then However, with the patch for that applied I can confirm a successful build! What patch is that? -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Win32 tablespace
Andreas Pflug wrote: [EMAIL PROTECTED] wrote: (create/drop tablespace works too) I can *not* confirm this; after configure; make clean; make; make install I got tablespace not supported. pg_config.h lacks HAVE_SYMLINK=1. I am confused. We have something in configure that forces HAVE_SYMLINK=1 if you are win32. Would you try a 'gmake distclean'? I think that might fix it. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Win32 fix for pg_dumpall
Andrew Dunstan wrote:
Bruce Momjian wrote:
/*
+ * Sometime the child returns \r\n, which doesn't match
+ * our version string. The backend uses
+ * setvbuf(stdout, NULL, _IONBF, 0), but pg_dump doesn't
+ * so we have to fix it here.
+ */
+if (strlen(line) = 2
+line[strlen(line)-2] == '\r'
+line[strlen(line)-1] == '\n')
+{
+line[strlen(line)-2] == '\n';
+line[strlen(line)-1] == '\0';
+}
+
+/*
I do not see how the comment relates at all to the code following it -
buffer mode and line end mode are two different things. Also, the
Yea, you would _think_ they are unrelated on Win32, but they aren't.
:-)
Turns out when you do that call in the backend, all EOLs become \n and
not \r\n. This is what Claudio found. Let me document the strangeness
of this more clearly.
repeated calls to strlen(line) are horribly inefficient - it should be
called once and stashed in an int (I once made an order of magnitude
speedup in a program by correcting a piece of someone else's code that
looked like this: for (i = 0; i = strlen(s); i++) where s was an
invariant very long string)
OK, I will clean that up too, but after beta1.
--
Bruce Momjian| http://candle.pha.pa.us
[EMAIL PROTECTED] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
Re: [PATCHES] Patch for Array min() / max()
Bruce Momjian wrote: May I have a context diff please, diff -c? As this is new functionality, I presume it will be held for 8.1, correct? In any case, you can put my name on it for review. Joe Hi ! I updated the patch for array min()/max() contrib. If I still miss something, please let me know. Thank you! Regards koju This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 693 481. It is confidential to the ordinary user of the email address to which it was addressed and may contain copyright and/or legally privileged information. No one else may read, print, store, copy or forward all or any of it or its attachments. If you receive this email in error, please return to sender. Thank you. If you do not wish to receive commercial email messages from Fujitsu Australia Software Technology Pty Ltd, please email [EMAIL PROTECTED] arrayMin_Max2.diff Description: Binary data ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Patch for Array min() / max()
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Koju Iijima wrote: Bruce Momjian wrote: May I have a context diff please, diff -c? As this is new functionality, I presume it will be held for 8.1, correct? In any case, you can put my name on it for review. Joe Hi ! I updated the patch for array min()/max() contrib. If I still miss something, please let me know. Thank you! Regards koju This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 693 481. It is confidential to the ordinary user of the email address to which it was addressed and may contain copyright and/or legally privileged information. No one else may read, print, store, copy or forward all or any of it or its attachments. If you receive this email in error, please return to sender. Thank you. If you do not wish to receive commercial email messages from Fujitsu Australia Software Technology Pty Ltd, please email [EMAIL PROTECTED] [ Attachment, skipping... ] ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] psql - missing tab-completion support for tablespaces
Stefan Kaltenbrunner wrote: When looking through the code I found that there seem to be much more places where the tabcomplete-code is not 100% in sync with what the doc's show as possible syntax. Is there interest in fixing those up (ie qualifing as BUGS that can get fixed during BETA) ? If so I could take a look at those in the next days ... Yes, please send in any tab completion improvements you can make. Thanks. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
