Re: [PATCHES] restore to defaults values when commenting of variables

2006-04-21 Thread Bruce Momjian
Tom Lane wrote:
 BERTHOULE Emmanuel [EMAIL PROTECTED] writes:
  with this patch, you can now restore default value with SIGHUP when
  commenting an variable in postgresql.conf
 
 This seems pretty poorly thought out, in particular making PGC_S_SIGHUP
 = PGC_S_OVERRIDE seems to me likely to break the interaction with other
 sources.  Doesn't that cause postgresql.conf to override per-user and
 per-database settings?  Why do you need the extra value at all ---
 isn't the correct logic just to reset entries with source PGC_S_FILE?
 
 Another problem is that if there's something wrong with the config file,
 this will cause all values previously read from the config file to
 revert to defaults, which seems less than robust to me.  You really
 shouldn't apply the reset until after the file has been parsed.

Is any progress being made on this patch to address the above concerns?

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match


Re: [PATCHES] [PERFORM] WAL logging of SELECT ... INTO command

2006-04-21 Thread Simon Riggs
On Fri, 2006-04-21 at 19:56 -0400, Bruce Momjian wrote:
 Your patch has been added to the PostgreSQL unapplied patches list at:
 
   http://momjian.postgresql.org/cgi-bin/pgpatches
 
 It will be applied as soon as one of the PostgreSQL committers reviews
 and approves it.

This patch should now be referred to as 
allow CREATE TABLE AS/SELECT INTO to use default_tablespace
or something similar.

The name of the original thread no longer bears any resemblance to the
intention of this patch as submitted in its final form.

I've no objection to the patch, which seems to fill a functional
gap/bug.

-- 
  Simon Riggs
  EnterpriseDB  http://www.enterprisedb.com/


---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


Re: [PATCHES] patch to have configure check if CC is intel C compiler

2006-04-21 Thread Bruce Momjian

This seems like a compiler bug so I am hoping it will be fixed, or is
already fixed in a later release.  In fact, I know some users are using
the Intel compiler, and we are not hearing reports of regression
failures, so I am hoping the release with this bug is not widely used.

---

Jeremy Drake wrote:
 Should also warn anyone who tries this that the regression tests for
 float4 and float8 fail under normal optimization flags.  I managed to
 track it down, and apparently some floating point optimizations (seemingly
 relating to SSE) cause comparisons involving NaN to give non-standard
 results.  This is worked around in float[48]cmp by explicitly checking
 isnan.  The issue I encountered was when dividing by NaN.  float[48]div do
 a check that if the divisor == 0.0, then a division by zero error is
 raised.  With the non-standard behavior, the comparison NaN == 0 is true,
 and so dividing by NaN results in a division by zero error rather than the
 expected result (NaN).
 
 The workaround is to give the -mp1 flag to the compiler, which rectifies
 the behavior.
 
 I do not know if this error is important enough to insert the option if
 the check for the Intel compiler succeeds.
 
 The rest of this is an irrelevant but (imho) interesting detailed
 description of why the code generated by the compiler breaks, and why the
 -mp1 flag causes it to start working.
 
 The exact cause of the nonstandard behavior is an interesting side-effect
 of the COMISD instruction, in that if the comparison is unordered, all
 three of the ZF, CF, and PF are set to 1.  The optimization results in
 assembly which looks like (inserted constants instead of registers for
 readability)
 
 comisd 0, NaN
 je equal
 ; false
 equal:
 ; true
 
 The use of the -mp1 flag results in code that checks the parity flag,
 which when set indicates an unordered result, like this:
 
 comisd 0, NaN
 jp nequal
 je equal
 nequal:
 ; false
 equal:
 ; true
 
 
 
 On Fri, 21 Apr 2006, Bruce Momjian wrote:
 
 
  Comment added and patch applied.  Thanks.
 
  ---
 
 
  Jeremy Drake wrote:
   This patch makes configure check for the __INTEL_COMPILER define (which is
   the recommended way to detect the intel compiler) before adding the extra
   CFLAGS if it thinks the compiler is GCC.  I am not an autoconf hacker, so
   I may have done it wrong or something, but it appears to work for me (ICC
   9.0.032 on gentoo i686 with latest packages).
 
 
 -- 
 I tried the clone syscall on me, but it didn't work.
   -- Mike Neuffer trying to fix a serious time problem
 
 ---(end of broadcast)---
 TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match
 

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly