Re: [PATCHES] plpython tracebacks
Neil, where are we on this patch? --- Neil Conway wrote: P. Scott DeVos wrote: I'm on it. Actually, don't worry about it -- I've made the corrections I had in mind myself. Attached is a revised patch. On looking closer, I didn't really like the way the patch accumulated the lines of the traceback: AFAICS _PyString_Join() is not an official Python C API function (it's not documented, at any rate), and besides it is cleaner and more efficient to build up the traceback string in a StringInfo rather than using Python lists and strings. The attached patch isn't quite finished: No Traceback when there is no traceback information doesn't seem like the best message, I need to update the regression tests and some comments, etc. But I plan to apply something similar in substance to the attached patch to HEAD in the next day or two, barring objections. -Neil ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings -- Bruce Momjian http://candle.pha.pa.us EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] Solaris ASM problem
Kris Jurka wrote: On Fri, 28 Apr 2006, Theo Schlossnagle wrote: The file that uses the spinlocks: /src/backend/storage/lmgr/s_lock.c can be compiled standalone with -DS_LOCK_TEST To get the test to compile I had to link in tas.o as the attached patch shows. Unfortunately this doesn't work for platforms that don't have a tas.o, bailing out with file not found. Perhaps it's not important to fix this test, but I thought I'd mention it. Fixed with the attached patch. Thanks. -- Bruce Momjian http://candle.pha.pa.us EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/backend/storage/lmgr/Makefile === RCS file: /cvsroot/pgsql/src/backend/storage/lmgr/Makefile,v retrieving revision 1.20 diff -c -c -r1.20 Makefile *** src/backend/storage/lmgr/Makefile 7 Oct 2004 00:08:04 - 1.20 --- src/backend/storage/lmgr/Makefile 28 Apr 2006 22:51:26 - *** *** 19,27 SUBSYS.o: $(OBJS) $(LD) $(LDREL) $(LDOUT) SUBSYS.o $(OBJS) s_lock_test: s_lock.c $(top_builddir)/src/port/libpgport.a $(CC) $(CPPFLAGS) $(CFLAGS) -DS_LOCK_TEST=1 $(srcdir)/s_lock.c \ ! -L $(top_builddir)/src/port -lpgport -o s_lock_test check: s_lock_test ./s_lock_test --- 19,31 SUBSYS.o: $(OBJS) $(LD) $(LDREL) $(LDOUT) SUBSYS.o $(OBJS) + ifdef TAS + TASPATH = $(top_builddir)/src/backend/port/tas.o + endif + s_lock_test: s_lock.c $(top_builddir)/src/port/libpgport.a $(CC) $(CPPFLAGS) $(CFLAGS) -DS_LOCK_TEST=1 $(srcdir)/s_lock.c \ ! $(TASPATH) -L $(top_builddir)/src/port -lpgport -o s_lock_test check: s_lock_test ./s_lock_test ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] patch to have configure check if CC is intel C compiler
Patch applied. Thanks. --- Jeremy Drake wrote: On Sat, 22 Apr 2006, Tom Lane wrote: Given that we've already got a test for ICC in there as of today, I'd vote for adding -mp1 to CFLAGS if we see it's ICC. This patch seems to do the trick... Index: configure.in === RCS file: /home/jeremyd/local/postgres/cvsuproot/pgsql/configure.in,v retrieving revision 1.460 diff -c -r1.460 configure.in *** configure.in22 Apr 2006 00:29:41 - 1.460 --- configure.in25 Apr 2006 06:03:12 - *** *** 263,268 --- 263,273 # Check whether they are supported, and add them to CFLAGS if so. PGAC_PROG_CC_CFLAGS_OPT([-Wdeclaration-after-statement]) PGAC_PROG_CC_CFLAGS_OPT([-Wendif-labels]) + else + # Intel compiler has a bug/misoptimization in checking for + # division by NAN (NaN == 0), -mp1 fixes it, so add it to the + # CFLAGS. + PGAC_PROG_CC_CFLAGS_OPT([-mp1]) fi # Disable strict-aliasing rules; needed for gcc 3.3+ -- A quarrel is quickly settled when deserted by one party; there is no battle unless there be two. -- Seneca ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match -- Bruce Momjian http://candle.pha.pa.us EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
