Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]
On Mon, Sep 15, 2008 at 9:45 PM, Ryan Bradetich [EMAIL PROTECTED] wrote: I have the code and regression tests updated to solve the problems you initially discovered. After code reading, stepping through with the debugger, and help from RhodiumToad on irc I was able to implement new restrict selective estimation functions for the uint4 vs int4 data types. The uint1 vs int4 and uint2 vs int4 data types did not require a custom restrict selective estimation function. i'm still seeing the failures in the copy commands (the ones about the paths) i'm not really sure if this matters. contrib_regression=# select 256::int2::int4; int4 -- 256 (1 row) contrib_regression=# select 256::uint2::int4; int4 -- 256 (1 row) contrib_regression=# select 256::int2::uint4; ERROR: cannot cast type smallint to uint4 at character 17 STATEMENT: select 256::int2::uint4; ERROR: cannot cast type smallint to uint4 LINE 1: select 256::int2::uint4; otherwise seems fine -- regards, Jaime Casanova Soporte y capacitación de PostgreSQL AsesorÃa y desarrollo de sistemas Guayaquil - Ecuador Cel. +59387171157 -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]
Hello Jaime, i'm still seeing the failures in the copy commands (the ones about the paths) I just tested this on a different machine (to get it away from my development environment) I was able to duplicate the failures. It looks like I need to update the expected/ files as well. I will get fixed ASAP. i'm not really sure if this matters. contrib_regression=# select 256::int2::int4; int4 -- 256 (1 row) contrib_regression=# select 256::uint2::int4; int4 -- 256 (1 row) contrib_regression=# select 256::int2::uint4; ERROR: cannot cast type smallint to uint4 at character 17 STATEMENT: select 256::int2::uint4; ERROR: cannot cast type smallint to uint4 LINE 1: select 256::int2::uint4; To keep this type fairly simple, I was not planning to add these casts. My intention was to handle just enough casting for the required ASSIGNMENT and IMPLICIT casts and to gracefully handle the int4 type since naked numbers are implicitly cast to int4. otherwise seems fine Thank you very much for your review! I am still working on adding comments to the uint.c file. I am hoping to have that completed tonight. Tom: Have you had a chance to look over the RESTRICT selectivity functions I implemented to handle the cross-type problem? Is that what you had in mind? Thanks! - Ryan -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
