Re: [PATCHES] Adminpack build fix
> > Attached patch removes a couple of extern definitions from > adminpack, > > replacing some of them with a #include. > > I've now removed all the local DLLIMPORT-redeclarations I > could find in favor of marking the relevant variables in the > main header files. Thanks. All affected projects build with MSVC now - haven't tested if they work, but they pass the compiler... //Magnus ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Adminpack build fix
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Attached patch removes a couple of extern definitions from adminpack, > replacing some of them with a #include. I've now removed all the local DLLIMPORT-redeclarations I could find in favor of marking the relevant variables in the main header files. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] Adminpack build fix
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> The same redeclaration technique is being used elsewhere >> (pg_buffercache and pg_freespacemap it looks like). Aren't >> you getting warnings there too? > I am - I just started working on getting those done as well. OK, I guess we gotta play them all honestly. Will fix. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] Adminpack build fix
> >> The reason for redeclaring these in the contrib files is to get > >> DLLIMPORT onto them... > > > Interedting - it builds on MSVC without it :-O > > > Anyway. That certainly explains why MSVC is complaining - > it's getting > > completely different definitions of these variables from the header > > and from the actual file. > > The same redeclaration technique is being used elsewhere > (pg_buffercache and pg_freespacemap it looks like). Aren't > you getting warnings there too? I am - I just started working on getting those done as well. (they were also living on my list of fix-later ones for some other reasons - the other reasons now having been fixed) //Magnus ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] Adminpack build fix
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> The reason for redeclaring these in the contrib files is to >> get DLLIMPORT onto them... > Interedting - it builds on MSVC without it :-O > Anyway. That certainly explains why MSVC is complaining - it's getting > completely different definitions of these variables from the header and > from the actual file. The same redeclaration technique is being used elsewhere (pg_buffercache and pg_freespacemap it looks like). Aren't you getting warnings there too? regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Adminpack build fix
> > Attached patch removes a couple of extern definitions from > adminpack, > > replacing some of them with a #include. (Cam eup with this > because we > > got a duplicate definition of DataDir when building with > Visual C++). > > That isn't going to work unless we put DLLIMPORT into the > main headers. > The reason for redeclaring these in the contrib files is to > get DLLIMPORT onto them... Interedting - it builds on MSVC without it :-O Anyway. That certainly explains why MSVC is complaining - it's getting completely different definitions of these variables from the header and from the actual file. What do you think about simply adding DLLIMPORT to the variables in the main header? //Magnus ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Adminpack build fix
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Attached patch removes a couple of extern definitions from adminpack, > replacing some of them with a #include. (Cam eup with this because we > got a duplicate definition of DataDir when building with Visual C++). That isn't going to work unless we put DLLIMPORT into the main headers. The reason for redeclaring these in the contrib files is to get DLLIMPORT onto them... regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[PATCHES] Adminpack build fix
Attached patch removes a couple of extern definitions from adminpack, replacing some of them with a #include. (Cam eup with this because we got a duplicate definition of DataDir when building with Visual C++). Seems much more correct to pull in the header file that has the definition, and only do that. //Magnus adminpack.diff Description: adminpack.diff ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] adminpack
Tom Lane wrote: > "Joshua D. Drake" <[EMAIL PROTECTED]> writes: >> Here is adminpack... > > Applied with minor corrections (the .sql file is DATA not DATA_built, > as you'd have found out if you'd tried "make clean"). Likewise for > the pgrowlocks script. Noted, thanks. > > regards, tom lane > -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] adminpack
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > Here is adminpack... Applied with minor corrections (the .sql file is DATA not DATA_built, as you'd have found out if you'd tried "make clean"). Likewise for the pgrowlocks script. regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
[PATCHES] adminpack
Hello, Here is adminpack... -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ ? adminpack.diff ? adminpack.sql ? libadminpack.so.0.0 ? uninstall_adminpack.sql Index: Makefile === RCS file: /projects/cvsroot/pgsql/contrib/adminpack/Makefile,v retrieving revision 1.2 diff -c -r1.2 Makefile *** Makefile30 May 2006 21:34:15 - 1.2 --- Makefile29 Sep 2006 01:15:05 - *** *** 1,6 MODULE_big = adminpack PG_CPPFLAGS = -I$(libpq_srcdir) ! DATA_built = adminpack.sql DOCS = README.adminpack OBJS = adminpack.o --- 1,6 MODULE_big = adminpack PG_CPPFLAGS = -I$(libpq_srcdir) ! DATA_built = adminpack.sql uninstall_adminpack.sql DOCS = README.adminpack OBJS = adminpack.o DROP FUNCTION pg_catalog.pg_file_write(text, text, bool) ; DROP FUNCTION pg_catalog.pg_file_rename(text, text, text) ; DROP FUNCTION pg_catalog.pg_file_rename(text, text) ; DROP FUNCTION pg_catalog.pg_file_unlink(text) ; DROP FUNCTION pg_catalog.pg_logdir_ls() ; DROP FUNCTION pg_catalog.pg_file_read(text, bigint, bigint) ; DROP FUNCTION pg_catalog.pg_file_length(text) ; DROP FUNCTION pg_catalog.pg_logfile_rotate() ; ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
[PATCHES] Adminpack contrib module
A few weeks ago following a discussion on pgsql-general it was proposed that the pgAdmin 'adminpack' contrib module be added to /contrib in the server's source tree to make it easier for users to find and install. There were no objections, so attached is an updated version of the adminpack, with non-version specific naming for addition to the source tree. The entire directory in the archive should be added to /contrib, and an appropriate entry added to contrib/Makefile. Regards, Dave adminpack.tar.gz Description: Binary data ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
