[PATCHES] mingw autoconf again

2007-10-29 Thread Magnus Hagander
So I was fixing my MingW environment to test and fix that issue with the
functions missing. In doing so, I came across the error previously
discussed that gettimeofday() is now suddently defined in the latest
versions of mingw, but wasn't before. 

So I figured I'd have to fix that. Attached is a patch for configure to
check this. I'd like comments from someone who knows autoconf better than
me on:
1) does it look ok?
2) is it ok to put checks for win32-only this way?


It does work on my mingw build, and with the new version of mingw the
functions aren't missing so I can actualliy build CVS HEAD to working state
with that one. Which just means I'll have to write another autoconf test
for the missing functions ni older mingw, but I'd like to get comments on
this one first.

//Magnus
Index: configure
===
RCS file: /cvsroot/pgsql/configure,v
retrieving revision 1.565
diff -c -r1.565 configure
*** configure   27 Oct 2007 00:22:42 -  1.565
--- configure   29 Oct 2007 08:41:55 -
***
*** 16962,16975 
  
  # Win32 support
  if test $PORTNAME = win32; then
! case $LIBOBJS in
! gettimeofday.$ac_objext   | \
!   * gettimeofday.$ac_objext   | \
! gettimeofday.$ac_objext * | \
!   * gettimeofday.$ac_objext * ) ;;
!   *) LIBOBJS=$LIBOBJS gettimeofday.$ac_objext ;;
  esac
  
  case $LIBOBJS in
  kill.$ac_objext   | \
* kill.$ac_objext   | \
--- 16962,17079 
  
  # Win32 support
  if test $PORTNAME = win32; then
! 
! for ac_func in gettimeofday
! do
! as_ac_var=`echo ac_cv_func_$ac_func | $as_tr_sh`
! echo $as_me:$LINENO: checking for $ac_func 5
! echo $ECHO_N checking for $ac_func... $ECHO_C 6
! if eval test \\${$as_ac_var+set}\ = set; then
!   echo $ECHO_N (cached) $ECHO_C 6
! else
!   cat conftest.$ac_ext _ACEOF
! /* confdefs.h.  */
! _ACEOF
! cat confdefs.h conftest.$ac_ext
! cat conftest.$ac_ext _ACEOF
! /* end confdefs.h.  */
! /* Define $ac_func to an innocuous variant, in case limits.h declares 
$ac_func.
!For example, HP-UX 11i limits.h declares gettimeofday.  */
! #define $ac_func innocuous_$ac_func
! 
! /* System header to define __stub macros and hopefully few prototypes,
! which can conflict with char $ac_func (); below.
! Prefer limits.h to assert.h if __STDC__ is defined, since
! limits.h exists even on freestanding compilers.  */
! 
! #ifdef __STDC__
! # include limits.h
! #else
! # include assert.h
! #endif
! 
! #undef $ac_func
! 
! /* Override any gcc2 internal prototype to avoid an error.  */
! #ifdef __cplusplus
! extern C
! {
! #endif
! /* We use char because int might match the return type of a gcc2
!builtin and then its argument prototype would still apply.  */
! char $ac_func ();
! /* The GNU C library defines this for functions which it implements
! to always fail with ENOSYS.  Some functions are actually named
! something starting with __ and the normal name is an alias.  */
! #if defined (__stub_$ac_func) || defined (__stub___$ac_func)
! choke me
! #else
! char (*f) () = $ac_func;
! #endif
! #ifdef __cplusplus
! }
! #endif
! 
! int
! main ()
! {
! return f != $ac_func;
!   ;
!   return 0;
! }
! _ACEOF
! rm -f conftest.$ac_objext conftest$ac_exeext
! if { (eval echo $as_me:$LINENO: \$ac_link\) 5
!   (eval $ac_link) 2conftest.er1
!   ac_status=$?
!   grep -v '^ *+' conftest.er1 conftest.err
!   rm -f conftest.er1
!   cat conftest.err 5
!   echo $as_me:$LINENO: \$? = $ac_status 5
!   (exit $ac_status); } 
!{ ac_try='test -z $ac_c_werror_flag
!|| test ! -s conftest.err'
!   { (eval echo $as_me:$LINENO: \$ac_try\) 5
!   (eval $ac_try) 25
!   ac_status=$?
!   echo $as_me:$LINENO: \$? = $ac_status 5
!   (exit $ac_status); }; } 
!{ ac_try='test -s conftest$ac_exeext'
!   { (eval echo $as_me:$LINENO: \$ac_try\) 5
!   (eval $ac_try) 25
!   ac_status=$?
!   echo $as_me:$LINENO: \$? = $ac_status 5
!   (exit $ac_status); }; }; then
!   eval $as_ac_var=yes
! else
!   echo $as_me: failed program was: 5
! sed 's/^/| /' conftest.$ac_ext 5
! 
! eval $as_ac_var=no
! fi
! rm -f conftest.err conftest.$ac_objext \
!   conftest$ac_exeext conftest.$ac_ext
! fi
! echo $as_me:$LINENO: result: `eval echo '${'$as_ac_var'}'` 5
! echo ${ECHO_T}`eval echo '${'$as_ac_var'}'` 6
! if test `eval echo '${'$as_ac_var'}'` = yes; then
!   cat confdefs.h _ACEOF
! #define `echo HAVE_$ac_func | $as_tr_cpp` 1
! _ACEOF
! 
! else
!   case $LIBOBJS in
! $ac_func.$ac_objext   | \
!   * $ac_func.$ac_objext   | \
! $ac_func.$ac_objext * | \
!   * $ac_func.$ac_objext * ) ;;
!   *) LIBOBJS=$LIBOBJS $ac_func.$ac_objext ;;
  esac
  
+ fi
+ done
+ 
+ 
  case $LIBOBJS in
  kill.$ac_objext   | \
* kill.$ac_objext   | \
Index: configure.in
===
RCS file: /cvsroot/pgsql/configure.in,v
retrieving revision 1.531
diff -c -r1.531 configure.in
*** configure.in27 Oct 2007 00:22:42 - 

Re: [PATCHES] mingw autoconf again

2007-10-29 Thread Heikki Linnakangas
Magnus Hagander wrote:
 So I was fixing my MingW environment to test and fix that issue with the
 functions missing. In doing so, I came across the error previously
 discussed that gettimeofday() is now suddently defined in the latest
 versions of mingw, but wasn't before. 

Is it just missing from header files, or does it really not exist?

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [PATCHES] mingw autoconf again

2007-10-29 Thread Magnus Hagander
Heikki Linnakangas wrote:
 Magnus Hagander wrote:
 So I was fixing my MingW environment to test and fix that issue with the
 functions missing. In doing so, I came across the error previously
 discussed that gettimeofday() is now suddently defined in the latest
 versions of mingw, but wasn't before. 
 
 Is it just missing from header files, or does it really not exist?

It really does not exist. We have a replacement in port/.

//Magnus

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [PATCHES] mingw autoconf again

2007-10-29 Thread Peter Eisentraut
Am Montag, 29. Oktober 2007 schrieb Magnus Hagander:
 1) does it look ok?

yes

 2) is it ok to put checks for win32-only this way?

Well, the available replacement implementation only works on win32, so this is 
about as correct as we should care to be at the moment.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

---(end of broadcast)---
TIP 6: explain analyze is your friend