Re: [PATCHES] patch to suppress psql timing output in quiet mode

2007-04-16 Thread Magnus Hagander
Merlin Moncure wrote:
 I noticed that when psql accepts input from stdin or -f (but not -c),
 and timing is set to on in .psqlrc, timing results are printed out to
 stdout even when -q (quiet) is passed in.
 
 This may not be the perfect solution, but it fixes the problem (I'm
 having problems with bash scripts that are borking on time returned).
 
 current behavior:
 [EMAIL PROTECTED] psql]# echo select 0 | psql -tAq
 0
 Time: 1.155 ms
 [EMAIL PROTECTED] psql]# psql -tAqcselect 0
 0

Makes sense to me. Applied and backpatched, thanks!

//Magnus

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


[PATCHES] patch to suppress psql timing output in quiet mode

2007-04-11 Thread Merlin Moncure

I noticed that when psql accepts input from stdin or -f (but not -c),
and timing is set to on in .psqlrc, timing results are printed out to
stdout even when -q (quiet) is passed in.

This may not be the perfect solution, but it fixes the problem (I'm
having problems with bash scripts that are borking on time returned).

current behavior:
[EMAIL PROTECTED] psql]# echo select 0 | psql -tAq
0
Time: 1.155 ms
[EMAIL PROTECTED] psql]# psql -tAqcselect 0
0

merlin

Index: common.c
===
RCS file: /projects/cvsroot/pgsql/src/bin/psql/common.c,v
retrieving revision 1.133
diff -c -r1.133 common.c
*** common.c8 Feb 2007 11:10:27 -   1.133
--- common.c11 Apr 2007 17:20:21 -
***
*** 918,924 
   PQclear(results);

   /* Possible microtiming output */
!   if (OK  pset.timing)
   printf(_(Time: %.3f ms\n), elapsed_msec);

   /* check for events that may occur during query execution */
--- 918,924 
   PQclear(results);

   /* Possible microtiming output */
!   if (OK  pset.timing  !pset.quiet)
   printf(_(Time: %.3f ms\n), elapsed_msec);

   /* check for events that may occur during query execution */

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
  choose an index scan if your joining column's datatypes do not
  match