[PATCHES] remove obsolete NULL casts
In any modern dialect of C, casting the NULL pointer literal to a specific pointer type is unnecessary. For example: char *foo; foo = malloc(...); if (foo == (char *) NULL) {...} The cast on the 3rd line serves no useful purpose. Hence, this patch removes all such instances of NULL-pointer casting from the backend. I've attached it in gzip'ed format, as it is 145KB uncompressed. Unless anyone objects, I intend to apply this within 48 hours. -Neil null-cast-cleanup-3.patch.gz Description: Binary data ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] remove obsolete NULL casts
On Mon, Jan 05, 2004 at 04:31:40PM -0500, Neil Conway wrote: In any modern dialect of C, casting the NULL pointer literal to a specific pointer type is unnecessary. For example: char *foo; foo = malloc(...); if (foo == (char *) NULL) {...} In src/backend/port/darwin/system.c you replaced: execl(_PATH_BSHELL, sh, -c, command, (char *) NULL); By: execl(_PATH_BSHELL, sh, -c, command, NULL); I think that is one of the exceptions where you do have to cast it, because the type is unknown. You can only remove the cast when you actually know what pointer type it is. Kurt ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]