Re: [PATCHES] tsearch pfree error

2003-09-13 Thread Tom Lane
Nigel J. Andrews [EMAIL PROTECTED] writes:
 On Fri, 12 Sep 2003, Bruce Momjian wrote:
 I might have assumed the tsearch guys had it handled now that they have
 CVS access.

 Good point. I'd completely forgotten I was also expecting them to pick it up,

Yes, I'd also passed it over because I assumed Oleg and Teodor would
take care of it.  But they haven't yet, so I applied what I could.

regards, tom lane

---(end of broadcast)---
TIP 8: explain analyze is your friend


[PATCHES] tsearch pfree error

2003-09-12 Thread Nigel J. Andrews

I haven't seen a notice that Bruce noticed this patch I sent across general as
part of a rambling thread of mine. There again, I'm not exactly up to date with
all my email so could easily have missed it. However, in light of the beta3
notice I'm sending it to the correct list now.

Fixes simple bug that was causing me problems using tsearch2.

--
Nigel Andrews
*** /tmp/postgresql-7.3.4/contrib/tsearch2/query.c  Thu Aug 28 13:29:12 2003
--- query.c Sun Sep  7 18:53:17 2003
***
*** 837,843 
PG_GETARG_DATUM(1)
);

!   PG_FREE_IF_COPY(name,1);
PG_RETURN_DATUM(res);
  }
  
--- 837,843 
PG_GETARG_DATUM(1)
);

!   PG_FREE_IF_COPY(name,0);
PG_RETURN_DATUM(res);
  }
  

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Nigel J. Andrews
On Fri, 12 Sep 2003, Bruce Momjian wrote:

 
 I hadn't seen this --- not sure why.

Probably because it was in a rambling thread consisting mostly of posts by
myself.

Thanks for applying it chaps.


Nigel
(Sheesh, all this fuss for a one character change :)




---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])


Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Bruce Momjian
Nigel J. Andrews wrote:
 On Fri, 12 Sep 2003, Bruce Momjian wrote:
 
  
  I hadn't seen this --- not sure why.
 
 Probably because it was in a rambling thread consisting mostly of posts by
 myself.
 
 Thanks for applying it chaps.

I might have assumed the tsearch guys had it handled now that they have
CVS access.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])


Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Bruce Momjian

I hadn't seen this --- not sure why.


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---




---

Nigel J. Andrews wrote:
 
 I haven't seen a notice that Bruce noticed this patch I sent across general as
 part of a rambling thread of mine. There again, I'm not exactly up to date with
 all my email so could easily have missed it. However, in light of the beta3
 notice I'm sending it to the correct list now.
 
 Fixes simple bug that was causing me problems using tsearch2.
 
 --
 Nigel Andrews

Content-Description: 

[ Attachment, skipping... ]

 
 ---(end of broadcast)---
 TIP 7: don't forget to increase your free space map settings

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Nigel J. Andrews

On Fri, 12 Sep 2003, Bruce Momjian wrote:

 ...

 I might have assumed the tsearch guys had it handled now that they have
 CVS access.

Good point. I'd completely forgotten I was also expecting them to pick it up,
principally because it needs to be applied to the version for running with a
7.3 server and no one else seems to know how that is being maintained. Maybe
Theodor is on holiday.


Nigel




---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster