Re: [PATCHES] Win32 psql fix

2004-10-19 Thread Dave Page 
 

 -Original Message-
 From: Tom Lane [mailto:[EMAIL PROTECTED] 
 Sent: 18 October 2004 18:37
 To: Dave Page
 Cc: PostgreSQL-patches
 Subject: Re: [PATCHES] Win32 psql fix 
 
 Dave Page [EMAIL PROTECTED] writes:
  The attached patch fixes psql's win32 frontend-only build, by using 
  pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in 
  miscadmin.h.
 
 What in the world is client-side code doing including 
 miscadmin.h in the first place?

It's included by port/exec.c which contains functions like find_my_exec.

Regards, Dave

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] Win32 psql fix

2004-10-18 Thread Bruce Momjian 

Patch applied.  Thanks.

---


Dave Page wrote:
 The attached patch fixes psql's win32 frontend-only build, by using
 pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
 miscadmin.h.
 
 Please apply.
 
 Regards Dave.

Content-Description: psql.diff

[ Attachment, skipping... ]

 
 ---(end of broadcast)---
 TIP 9: the planner will ignore your desire to choose an index scan if your
   joining column's datatypes do not match

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])

Re: [PATCHES] Win32 psql fix

2004-10-18 Thread Bruce Momjian 
Tom Lane wrote:
 Dave Page [EMAIL PROTECTED] writes:
  The attached patch fixes psql's win32 frontend-only build, by using
  pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
  miscadmin.h.
 
 What in the world is client-side code doing including miscadmin.h
 in the first place?

Ah, it is getting included from the port files.  Let me see if I can fix
that with FRONTEND tests.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match