Re: [PATCHES] [HACKERS] Hint Bits and Write I/O
Simon Riggs wrote: The first half is actually quite large, but that makes it even more sensible to commit this part now. The enclosed patch introduces the machinery by which we might later optimise hint bit setting. It differentiates between hint bit setting and block dirtying, when the distinction can safely be made. It acts safely during VACUUM and correctly during checkpoint. In all other respects it emulates current behaviour. I think it makes sense to commit this patch now, per previous discussions on which we have agreed to make incremental changes. I think we should just get rid of the bogus changes Pavan identified. I'm just wondering if the change of usage_count from 16 to 8 bits was discussed and agreed? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
Re: [PATCHES] [HACKERS] Hint Bits and Write I/O
Alvaro Herrera [EMAIL PROTECTED] writes: I think it makes sense to commit this patch now, per previous discussions on which we have agreed to make incremental changes. Yeah, but at the same time there is merit in the argument that the proposed patch hasn't actually been proven to be usable for anything. I would be a lot happier if there were even a trivial proof-of-concept plugin example submitted with it, just to prove that there were no showstopper problems in the plugin design, like failure to pass essential information or not getting the locking straight. I'm just wondering if the change of usage_count from 16 to 8 bits was discussed and agreed? Umm ... it was not, but given that we have logic in there to limit the usage_count to 5 or so, it's hard to argue that there's a big problem. I confess to not having read the patch in detail --- where did the other 8 bits go to? regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
