Re: [Pharo-dev] DeleteVisitor and symbolic links

2019-02-13 Thread Alistair Grant
Hi Sven & Torsten,

On Wed, 13 Feb 2019 at 20:59, Torsten Bergmann  wrote:
>
> Sven wrote:
> > Thanks, Alistair, for taking care of all this stuff.
>
> +1

Thank you!

Cheers,
Alistair



Re: [Pharo-dev] DeleteVisitor and symbolic links

2019-02-13 Thread Nicolas Cellier
+1, following links is insanely dangerous

Le mer. 13 févr. 2019 à 20:59, Torsten Bergmann  a écrit :

> Sven wrote:
> > Thanks, Alistair, for taking care of all this stuff.
>
> +1
>
>


Re: [Pharo-dev] External Module not found

2019-02-13 Thread Esteban Lorenzano
Hi,

> On 13 Feb 2019, at 15:06, Moussa Saker via Pharo-dev 
>  wrote:
> 
> 
> From: Moussa Saker 
> Subject: Re: [Pharo-dev] External Module not found
> Date: 13 February 2019 at 15:06:12 CET
> To: Pharo Development List 
> Reply-To: Moussa Saker 
> 
> 
> the missing module is  SqueakFFIPrims as shown by the debuger 
> 
> how i can add it ?

No is not. 
You’re missing Cairo library. 
Most probably you can install it with apt-get etc.

Esteban

> 
> Moussa.
> 
> 
> On Wednesday, 13 February 2019, 09:10:22 CET, Pierce Ng 
>  wrote:
> 
> 
> On Wed, Feb 13, 2019 at 12:12:39AM +, Moussa Saker via Pharo-dev wrote:
> 
> > am using a Pharo 7 image and an elementary os 64bits distribution
> > (based on Ubuntu 18.04), i was working on my project and when trying
> > to execute it i encountered this problem.
> 
> 
> Click on the debug button, look around and it'll tell you _which_
> external module cannot be found. From context it looks like Cairo, so
> try installing Cairo runtime libraries, but before that confirm by
> clicking on the debug button.
> 
> 
> 
> 
> 
> 



Re: [Pharo-dev] DeleteVisitor and symbolic links

2019-02-13 Thread Torsten Bergmann
Sven wrote:
> Thanks, Alistair, for taking care of all this stuff.

+1



Re: [Pharo-dev] DeleteVisitor and symbolic links

2019-02-13 Thread Sven Van Caekenberghe
Thanks, Alistair, for taking care of all this stuff.

> On 13 Feb 2019, at 18:54, Alistair Grant  wrote:
> 
> Hi Everyone,
> 
> I inadvertantly changed the behaviour of DeleteVisitor in Pharo 8.
> In Pharo 7 DeleteVisitor will follow all symbolic links when deleting a
> directory tree.  This has two consequences:
> 
> - A symbolic link that points to its containing directory will result in
>  an infinite loop.
> - Files may be deleted that are NOT subdirectories of the root
>  directory.
> 
> The Pharo 8 behaviour of not following symbolic links is how the linux
> 'rm -r' command behaves, and how I think DeleteVisitor should behave.
> 
> As Sean commented in
> http://forum.world.st/File-problems-in-Pharo-8-tp5095111p5095176.html
> following symbolic links can lead to unexpected behaviour, deleting
> files out of the tree, and thus is quite dangerous.
> 
> But since it is a change in existing behaviour, I wanted to let everyone
> know in case there's something I haven't thought of.
> 
> I'll submit a PR that updates the appropriate method and class comments
> in a few days.
> 
> 
> Cheers,
> Alistair
> 




[Pharo-dev] [Pharo 8.0] Build #74: 2518-DiskStoreentryFromNodepathfor-doesnt-use-existing-attributes

2019-02-13 Thread ci-pharo-ci-jenkins2
There is a new Pharo build available!
  
The status of the build #74 was: FAILURE.

The Pull Request #2522 was integrated: 
"2518-DiskStoreentryFromNodepathfor-doesnt-use-existing-attributes"
Pull request url: https://github.com/pharo-project/pharo/pull/2522

Issue Url: https://pharo.fogbugz.com/f/cases/2518
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/74/


Re: [Pharo-dev] Can't Install Launcher on Mac Mojave

2019-02-13 Thread Sean P. DeNigris
Max Leske wrote
> Nope. I downloaded launcher just 20 minutes ago on Mojave and am using 
> it without problems.

Weird. Nuked startup preferences folder just in case. fullPath modification
didn't help.

>Where did you extract it to? 
~/Application

> Did you extract it as a different user? 
Doesn't look like it

> Did you try to run it from within the .dmg directly?
No. Opened the dmg, dragged it into apps folder, then opened that



-
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html



[Pharo-dev] [Pharo 8.0] Build #73: 2219-RBParseErrorNode-misses-dumpOn

2019-02-13 Thread ci-pharo-ci-jenkins2
There is a new Pharo build available!
  
The status of the build #73 was: SUCCESS.

The Pull Request #2524 was integrated: "2219-RBParseErrorNode-misses-dumpOn"
Pull request url: https://github.com/pharo-project/pharo/pull/2524

Issue Url: https://pharo.fogbugz.com/f/cases/2219
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/73/


[Pharo-dev] DeleteVisitor and symbolic links

2019-02-13 Thread Alistair Grant
Hi Everyone,

I inadvertantly changed the behaviour of DeleteVisitor in Pharo 8.
In Pharo 7 DeleteVisitor will follow all symbolic links when deleting a
directory tree.  This has two consequences:

- A symbolic link that points to its containing directory will result in
  an infinite loop.
- Files may be deleted that are NOT subdirectories of the root
  directory.

The Pharo 8 behaviour of not following symbolic links is how the linux
'rm -r' command behaves, and how I think DeleteVisitor should behave.

As Sean commented in
http://forum.world.st/File-problems-in-Pharo-8-tp5095111p5095176.html
following symbolic links can lead to unexpected behaviour, deleting
files out of the tree, and thus is quite dangerous.

But since it is a change in existing behaviour, I wanted to let everyone
know in case there's something I haven't thought of.

I'll submit a PR that updates the appropriate method and class comments
in a few days.


Cheers,
Alistair



[Pharo-dev] [Pharo 8.0] Build #72: 2205-OCASTTranslator-class-initialize-should-not-invoke-super

2019-02-13 Thread ci-pharo-ci-jenkins2
There is a new Pharo build available!
  
The status of the build #72 was: SUCCESS.

The Pull Request #2520 was integrated: 
"2205-OCASTTranslator-class-initialize-should-not-invoke-super"
Pull request url: https://github.com/pharo-project/pharo/pull/2520

Issue Url: https://pharo.fogbugz.com/f/cases/2205
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/72/


[Pharo-dev] [Pharo 8.0] Build #71: 2189-superNodeClass-selfNodeClass-and-thisContextNodeClass-are-not-used-

2019-02-13 Thread ci-pharo-ci-jenkins2
There is a new Pharo build available!
  
The status of the build #71 was: SUCCESS.

The Pull Request #2521 was integrated: 
"2189-superNodeClass-selfNodeClass-and-thisContextNodeClass-are-not-used-"
Pull request url: https://github.com/pharo-project/pharo/pull/2521

Issue Url: https://pharo.fogbugz.com/f/cases/2189
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/71/


Re: [Pharo-dev] File problems in Pharo 8

2019-02-13 Thread Sean P. DeNigris
Alistair Grant wrote
> I… changed the behaviour of DeleteVisitor
> slightly.  In Pharo 7 the Visitor will descend in to a symbolic link
> that points to a directory, in Pharo 8 it doesn't.

Thank goodness someone finally fixed that! IMHO the old behavior was
extremely dangerous and I greatly limited my use of #deleteAll for that
reason.

'/path/to/aFolder' deleteAll

where
- aFolder
  - aSymbolicLinkTo~

No problem, we all have backups, right?... right?



-
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html



Re: [Pharo-dev] External Module not found

2019-02-13 Thread Moussa Saker via Pharo-dev
--- Begin Message ---
the missing module is  SqueakFFIPrims as shown by the debuger 

how i can add it ?

Moussa. 

On Wednesday, 13 February 2019, 09:10:22 CET, Pierce Ng 
 wrote:  
 
 On Wed, Feb 13, 2019 at 12:12:39AM +, Moussa Saker via Pharo-dev wrote:
> am using a Pharo 7 image and an elementary os 64bits distribution
> (based on Ubuntu 18.04), i was working on my project and when trying
> to execute it i encountered this problem.

Click on the debug button, look around and it'll tell you _which_
external module cannot be found. From context it looks like Cairo, so
try installing Cairo runtime libraries, but before that confirm by
clicking on the debug button.



  --- End Message ---


[Pharo-dev] [Pharo 8.0] Build #70: 2511 Tag in Slot-Examples should be uppercase

2019-02-13 Thread ci-pharo-ci-jenkins2
There is a new Pharo build available!
  
The status of the build #70 was: SUCCESS.

The Pull Request #2512 was integrated: "2511 Tag in Slot-Examples should be 
uppercase"
Pull request url: https://github.com/pharo-project/pharo/pull/2512

Issue Url: https://pharo.fogbugz.com/f/cases/2511
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/70/


[Pharo-dev] [Pharo 8.0] Build #69: 2513 Tag in MenuRegistration package should be uppercase

2019-02-13 Thread ci-pharo-ci-jenkins2
There is a new Pharo build available!
  
The status of the build #69 was: SUCCESS.

The Pull Request #2514 was integrated: "2513 Tag in MenuRegistration package 
should be uppercase"
Pull request url: https://github.com/pharo-project/pharo/pull/2514

Issue Url: https://pharo.fogbugz.com/f/cases/2513
Build Url: 
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/69/


Re: [Pharo-dev] Can't Install Launcher on Mac Mojave

2019-02-13 Thread Christophe Demarey
Hi Sean,

There was a similar issue on Linux: 
https://github.com/pharo-project/pharo-launcher/issues/307

It works with 1.7.2 on my laptop but I’m able to reproduce the error if I put 
PharoLauncher in a location containing non ASCII characters, I get the same 
error.
To fix this, in PL image, edit VirtualMachine>>#fullPath with:
^(self getSystemAttribute: 0) asByteArray utf8Decoded

It is a problem with the Pharo image. Encoding is not managed everywhere.

Tell me if it fixes your problem.

Christophe


> Le 13 févr. 2019 à 03:42, Sean P. DeNigris  a écrit :
> 
> Just dl-ed launcher from Pharo.org. Attempting to open Iceberg gives:
> "NotFound: Could not find repository from '/'". Seems to be coming from
> libgit. Anyone else seeing this?
> 
> 
> 
> -
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
> 




Re: [Pharo-dev] Can't Install Launcher on Mac Mojave

2019-02-13 Thread Max Leske
Nope. I downloaded launcher just 20 minutes ago on Mojave and am using 
it without problems. Where did you extract it to? Did you extract it as 
a different user? Did you try to run it from within the .dmg directly?



Max

On 13 Feb 2019, at 3:42, Sean P. DeNigris wrote:


Just dl-ed launcher from Pharo.org. Attempting to open Iceberg gives:
"NotFound: Could not find repository from '/'". Seems to be coming 
from

libgit. Anyone else seeing this?



-
Cheers,
Sean
--
Sent from: 
http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html




Re: [Pharo-dev] External Module not found

2019-02-13 Thread Pierce Ng
On Wed, Feb 13, 2019 at 12:12:39AM +, Moussa Saker via Pharo-dev wrote:
> am using a Pharo 7 image and an elementary os 64bits distribution
> (based on Ubuntu 18.04), i was working on my project and when trying
> to execute it i encountered this problem.

Click on the debug button, look around and it'll tell you _which_
external module cannot be found. From context it looks like Cairo, so
try installing Cairo runtime libraries, but before that confirm by
clicking on the debug button.