[Pharo-dev] [Pharo 8.0] Build #443: Fix mistake from PR3768
There is a new Pharo build available! The status of the build #443 was: FAILURE. The Pull Request #3800 was integrated: "Fix mistake from PR3768" Pull request url: https://github.com/pharo-project/pharo/pull/3800 Issue Url: https://github.com/pharo-project/pharo/issues/3799 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/443/
[Pharo-dev] [Pharo 8.0] Build #442: Lint review Tests in UnifiedFFI-Tests
There is a new Pharo build available! The status of the build #442 was: FAILURE. The Pull Request #3797 was integrated: "Lint review Tests in UnifiedFFI-Tests" Pull request url: https://github.com/pharo-project/pharo/pull/3797 Issue Url: https://github.com/pharo-project/pharo/issues/3796 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/442/
[Pharo-dev] [Pharo 8.0] Build #441: Cleanup Polymorph-Widgets
There is a new Pharo build available! The status of the build #441 was: FAILURE. The Pull Request #3784 was integrated: "Cleanup Polymorph-Widgets" Pull request url: https://github.com/pharo-project/pharo/pull/3784 Issue Url: https://github.com/pharo-project/pharo/issues/3783 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/441/
Re: [Pharo-dev] Pharo source code formatting guide
> On 5 Jul 2019, at 17:09, Esteban Lorenzano wrote: > > Hi, > >> On 5 Jul 2019, at 08:57, Norbert Hartl wrote: >> >> Sometimes I wonder when I change a piece of code in pharo if there is an >> official formatting guide line. Is the formatter in calypso the incarnation >> of it or how code is supposed to be formatted in the offical image? We are working on an enh of the formatter. - more tests (it was easy there was only one) - cleaning the settings/describing the settings - the goal is to be able to reformat all the code of the image Now in Pharo by example I have some examples. > We need a code style guide, yes. > But no, definitively the code formatter available should not be the canonical > formatting (since its ugly and some times even illegible). > > Esteban > >> >> I just see tons of occurrences where caret immediately follows a token and >> such which I don’t like at all. >> >> Norbert >> >> > >
[Pharo-dev] [Pharo 8.0] Build #440: Cleanup HTTPProgress example
There is a new Pharo build available! The status of the build #440 was: FAILURE. The Pull Request #3780 was integrated: "Cleanup HTTPProgress example" Pull request url: https://github.com/pharo-project/pharo/pull/3780 Issue Url: https://github.com/pharo-project/pharo/issues/3779 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/440/
[Pharo-dev] [Pharo 8.0] Build #439: Improve Athens-Cairo-Tests
There is a new Pharo build available! The status of the build #439 was: FAILURE. The Pull Request #3793 was integrated: "Improve Athens-Cairo-Tests" Pull request url: https://github.com/pharo-project/pharo/pull/3793 Issue Url: https://github.com/pharo-project/pharo/issues/3791 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/439/
[Pharo-dev] [Pharo 8.0] Build #438: Remove unnecessary temps in RBScannerTest test methods
There is a new Pharo build available! The status of the build #438 was: FAILURE. The Pull Request #3790 was integrated: "Remove unnecessary temps in RBScannerTest test methods" Pull request url: https://github.com/pharo-project/pharo/pull/3790 Issue Url: https://github.com/pharo-project/pharo/issues/3788 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/438/
[Pharo-dev] [Pharo 8.0] Build #437: RBParseTreeTests should be abstract test class
There is a new Pharo build available! The status of the build #437 was: SUCCESS. The Pull Request #3789 was integrated: "RBParseTreeTests should be abstract test class" Pull request url: https://github.com/pharo-project/pharo/pull/3789 Issue Url: https://github.com/pharo-project/pharo/issues/3787 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/437/
[Pharo-dev] [Pharo 8.0] Build #436: Cleanup EdgeGripMorph
There is a new Pharo build available! The status of the build #436 was: FAILURE. The Pull Request #3778 was integrated: "Cleanup EdgeGripMorph" Pull request url: https://github.com/pharo-project/pharo/pull/3778 Issue Url: https://github.com/pharo-project/pharo/issues/3777 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/436/
[Pharo-dev] [Pharo 8.0] Build #435: 3761-CompiledCodeargumentNames-should-be-reviewed
There is a new Pharo build available! The status of the build #435 was: SUCCESS. The Pull Request #3762 was integrated: "3761-CompiledCodeargumentNames-should-be-reviewed" Pull request url: https://github.com/pharo-project/pharo/pull/3762 Issue Url: https://github.com/pharo-project/pharo/issues/3761 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/435/
[Pharo-dev] [Pharo 8.0] Build #434: Cleanups in GT-Tests-Inspector
There is a new Pharo build available! The status of the build #434 was: SUCCESS. The Pull Request #3770 was integrated: "Cleanups in GT-Tests-Inspector" Pull request url: https://github.com/pharo-project/pharo/pull/3770 Issue Url: https://github.com/pharo-project/pharo/issues/3769 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/434/
Re: [Pharo-dev] Pharo source code formatting guide
Hi, > On 5 Jul 2019, at 08:57, Norbert Hartl wrote: > > Sometimes I wonder when I change a piece of code in pharo if there is an > official formatting guide line. Is the formatter in calypso the incarnation > of it or how code is supposed to be formatted in the offical image? We need a code style guide, yes. But no, definitively the code formatter available should not be the canonical formatting (since its ugly and some times even illegible). Esteban > > I just see tons of occurrences where caret immediately follows a token and > such which I don’t like at all. > > Norbert > >
[Pharo-dev] [Pharo 8.0] Build #433: Lint fix for readEvalPrint
There is a new Pharo build available! The status of the build #433 was: SUCCESS. The Pull Request #3768 was integrated: "Lint fix for readEvalPrint" Pull request url: https://github.com/pharo-project/pharo/pull/3768 Issue Url: https://github.com/pharo-project/pharo/issues/3767 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/433/
[Pharo-dev] Pharo source code formatting guide
Sometimes I wonder when I change a piece of code in pharo if there is an official formatting guide line. Is the formatter in calypso the incarnation of it or how code is supposed to be formatted in the offical image? I just see tons of occurrences where caret immediately follows a token and such which I don’t like at all. Norbert
[Pharo-dev] [Pharo 8.0] Build #432: Typo: explicitely should be explicitly
There is a new Pharo build available! The status of the build #432 was: SUCCESS. The Pull Request #3766 was integrated: "Typo: explicitely should be explicitly" Pull request url: https://github.com/pharo-project/pharo/pull/3766 Issue Url: https://github.com/pharo-project/pharo/issues/3765 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/Pharo8.0/432/