[Pharo-dev] ComposableModelinitialExtent

2014-03-12 Thread Laurent Laffont
Hi,

I'm trying to have tests green for TWM. I found:

ComposableModelinitialExtent
^ nil

on superclass Model there's

ModelinitialExtent
^ RealEstateAgent standardWindowExtent

that sounds good. So I don't understand why ComposableModel redefine 
#initialExtent to answer nil. Any explanation ?

Laurent



Re: [Pharo-dev] ComposableModelinitialExtent

2014-03-12 Thread Benjamin
The first answer is:
ComposableModel was not a subclass of model at first :P


Ben

On 12 Mar 2014, at 13:09, Laurent Laffont laurent.laff...@gmail.com wrote:

 Hi,
 
 I'm trying to have tests green for TWM. I found:
 
 ComposableModelinitialExtent
   ^ nil
 
 on superclass Model there's
 
 ModelinitialExtent
   ^ RealEstateAgent standardWindowExtent
 
 that sounds good. So I don't understand why ComposableModel redefine 
 #initialExtent to answer nil. Any explanation ?
 
 Laurent
 



Re: [Pharo-dev] ComposableModelinitialExtent

2014-03-12 Thread Laurent Laffont
As far as I see, it seems safe to remove ComposableModelinitialExtent  
Spec tests green, TWM tests green and I haven't seen any problem yet. What do 
you think ?

Laurent


Le mercredi 12 mars 2014, 17:36:20 Benjamin a écrit :
 The first answer is:
 ComposableModel was not a subclass of model at first :P
 
 
 Ben
 
 On 12 Mar 2014, at 13:09, Laurent Laffont laurent.laff...@gmail.com wrote:
 
  Hi,
  
  I'm trying to have tests green for TWM. I found:
  
  ComposableModelinitialExtent
  ^ nil
  
  on superclass Model there's
  
  ModelinitialExtent
  ^ RealEstateAgent standardWindowExtent
  
  that sounds good. So I don't understand why ComposableModel redefine 
  #initialExtent to answer nil. Any explanation ?
  
  Laurent
  
 




Re: [Pharo-dev] ComposableModelinitialExtent

2014-03-12 Thread Benjamin
Sounds good :P
I will integrate it into Spec dev
(I think it’s safer for now to not remove it into Pharo since it’s frozen)

Ben

On 12 Mar 2014, at 19:04, Laurent Laffont laurent.laff...@gmail.com wrote:

 As far as I see, it seems safe to remove ComposableModelinitialExtent  
 Spec tests green, TWM tests green and I haven't seen any problem yet. What do 
 you think ?
 
 Laurent
 
 
 Le mercredi 12 mars 2014, 17:36:20 Benjamin a écrit :
 The first answer is:
 ComposableModel was not a subclass of model at first :P
 
 
 Ben
 
 On 12 Mar 2014, at 13:09, Laurent Laffont laurent.laff...@gmail.com wrote:
 
 Hi,
 
 I'm trying to have tests green for TWM. I found:
 
 ComposableModelinitialExtent
 ^ nil
 
 on superclass Model there's
 
 ModelinitialExtent
 ^ RealEstateAgent standardWindowExtent
 
 that sounds good. So I don't understand why ComposableModel redefine 
 #initialExtent to answer nil. Any explanation ?
 
 Laurent