Re: [PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-04-04 Thread Sakari Ailus
Hi Luigi,

On Wed, Apr 03, 2024 at 09:03:51AM -0600, g...@luigi311.com wrote:
> From: Luis Garcia 
> 
> Add powerdown-gpio binding as it is required for some boards
> 
> Signed-off-by: Ondrej Jirman 
> Signed-off-by: Luis Garcia 
> ---
>  Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml 
> b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> index c978abc0cdb3..8139e6e8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> @@ -36,6 +36,10 @@ properties:
>reg:
>  maxItems: 1
>  
> +  powerdown-gpios:
> +description:
> +  Reference to the GPIO connected to the PWDN pin, if any.

The sensor datasheet does not mention this one so I presume this is
unrelated to the sensor. Could it be for GPIO regulator control instead?

> +
>reset-gpios:
>  description: |-
>Reference to the GPIO connected to the XCLR pin, if any.

-- 
Regards,

Sakari Ailus



Re: [PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-04-03 Thread Pavel Machek
Hi!

> From: Luis Garcia 
> 
> Add powerdown-gpio binding as it is required for some boards

"." at end of sentence.

> Signed-off-by: Ondrej Jirman 
> Signed-off-by: Luis Garcia 

If the patch is from Ondrej, he should be in From:, I believe.

Best regards,
Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.


signature.asc
Description: PGP signature


Re: [PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 17:03, g...@luigi311.com wrote:
> From: Luis Garcia 
> 
> Add powerdown-gpio binding as it is required for some boards
> 
> Signed-off-by: Ondrej Jirman 
> Signed-off-by: Luis Garcia 
> ---

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof




[PATCH v3 22/25] dt-bindings: media: imx258: Add binding for powerdown-gpio

2024-04-03 Thread git
From: Luis Garcia 

Add powerdown-gpio binding as it is required for some boards

Signed-off-by: Ondrej Jirman 
Signed-off-by: Luis Garcia 
---
 Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml 
b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
index c978abc0cdb3..8139e6e8 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
@@ -36,6 +36,10 @@ properties:
   reg:
 maxItems: 1
 
+  powerdown-gpios:
+description:
+  Reference to the GPIO connected to the PWDN pin, if any.
+
   reset-gpios:
 description: |-
   Reference to the GPIO connected to the XCLR pin, if any.
-- 
2.42.0