Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS
Hi, Jani Taskinen wrote: Felipe Pena wrote: felipeSun Sep 7 23:08:21 2008 UTC Modified files: (Branch: PHP_5_3) /php-srcNEWS Log: - New entry ?? ??? 200?, PHP 5.3.0 Alpha 3 +- Changed Soap methods error level, now it is no longer E_ERROR. (Felipe) Wha? In english please? And I checked soap.c and it has quite a few E_ERROR errors in it..so this NEWS entry is quite misleading. I'm too having trouble, based on this entry, understanding what has really changed (unfortunately I didn't understand the commit either). What errors have been changed to what exactly would be nice to know, and is it something which needs documented? thanks :) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl php_spl.c php_spl.h /ext/tidy php_tidy.h tidy.c
Confirmed, gave me a headache today ...
- Markus
Antony Dovgal wrote:
On 25.01.2008 23:29, Nuno Lopes wrote:
-zend_module_entry spl_module_entry = {
+const zend_module_entry spl_module_entry = {
-zend_module_entry tidy_module_entry = {
+const zend_module_entry tidy_module_entry = {
This makes PHP to crash right after the start.
Please revert.
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/pdo_odbc odbc_driver.c
Hi Wez,
I've tested a snapshot 23th and it still crashes. See my comment in
http://bugs.php.net/bug.php?id=35552 .
Thanks and mery christman,
- Markus
Wez Furlong wrote:
wez Wed Dec 14 04:56:22 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/ext/pdo_odbc odbc_driver.c
Log:
Possible fixes for #35552, #35592 and #35620.
http://cvs.php.net/viewcvs.cgi/php-src/ext/pdo_odbc/odbc_driver.c?r1=1.27.2.1r2=1.27.2.2diff_format=u
Index: php-src/ext/pdo_odbc/odbc_driver.c
diff -u php-src/ext/pdo_odbc/odbc_driver.c:1.27.2.1
php-src/ext/pdo_odbc/odbc_driver.c:1.27.2.2
--- php-src/ext/pdo_odbc/odbc_driver.c:1.27.2.1 Mon Sep 26 21:37:33 2005
+++ php-src/ext/pdo_odbc/odbc_driver.c Wed Dec 14 04:56:22 2005
@@ -16,7 +16,7 @@
+--+
*/
-/* $Id: odbc_driver.c,v 1.27.2.1 2005/09/26 21:37:33 wez Exp $ */
+/* $Id: odbc_driver.c,v 1.27.2.2 2005/12/14 04:56:22 wez Exp $ */
#ifdef HAVE_CONFIG_H
#include config.h
@@ -58,8 +58,10 @@
void pdo_odbc_error(pdo_dbh_t *dbh, pdo_stmt_t *stmt, PDO_ODBC_HSTMT statement, char *what, const char *file, int line TSRMLS_DC) /* {{{ */
{
- RETCODE rc;
- SWORD errmsgsize = 0;
+ SQLRETURN rc;
+ SQLSMALLINT errmsgsize = 0;
+ SQLHANDLE eh;
+ SQLSMALLINT htype, recno = 1;
pdo_odbc_db_handle *H = (pdo_odbc_db_handle*)dbh-driver_data;
pdo_odbc_errinfo *einfo = H-einfo;
pdo_odbc_stmt *S = NULL;
@@ -75,8 +77,19 @@
if (statement == SQL_NULL_HSTMT S) {
statement = S-stmt;
}
-
- rc = SQLError(H-env, H-dbc, statement, einfo-last_state,
einfo-last_error,
+
+ if (statement) {
+ htype = SQL_HANDLE_STMT;
+ eh = statement;
+ } else if (H-dbc) {
+ htype = SQL_HANDLE_DBC;
+ eh = H-dbc;
+ } else {
+ htype = SQL_HANDLE_ENV;
+ eh = H-env;
+ }
+
+ rc = SQLGetDiagRec(htype, eh, recno++, einfo-last_state,
einfo-last_error,
einfo-last_err_msg, sizeof(einfo-last_err_msg)-1,
errmsgsize);
if (rc != SQL_SUCCESS rc != SQL_SUCCESS_WITH_INFO) {
@@ -94,6 +107,20 @@
zend_throw_exception_ex(php_pdo_get_exception(), 0 TSRMLS_CC,
SQLSTATE[%s] %s: %d %s,
*pdo_err, what, einfo-last_error,
einfo-last_err_msg);
}
+
+ /* just like a cursor, once you start pulling, you need to keep
+* going until the end; SQL Server (at least) will mess with the
+* actual cursor state if you don't finish retrieving all the
+* diagnostic records (which can be generated by PRINT statements
+* in the query, for instance). */
+ while (rc == SQL_SUCCESS || rc == SQL_SUCCESS_WITH_INFO) {
+ char discard_state[5];
+ char discard_buf[1024];
+ SQLINTEGER code;
+ rc = SQLGetDiagRec(htype, eh, recno++, discard_state, code,
+ discard_buf, sizeof(discard_buf)-1,
errmsgsize);
+ }
+
}
/* }}} */
@@ -175,14 +202,12 @@
pdo_odbc_stmt_error(SQLPrepare);
}
+ stmt-driver_data = S;
+ stmt-methods = odbc_stmt_methods;
+
if (rc != SQL_SUCCESS rc != SQL_SUCCESS_WITH_INFO) {
- SQLFreeHandle(SQL_HANDLE_STMT, S-stmt);
return 0;
}
-
- stmt-driver_data = S;
- stmt-methods = odbc_stmt_methods;
-
return 1;
}
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src /ext/standard file.c
Jani Taskinen wrote:
Marcus Boerger wrote:
Modified files: /php-src/ext/standardfile.c
Log:
- Allow length 0 as default (e.g. skip param)
[...]
if (len 0) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, Length
parameter may not be negative);
RETURN_FALSE;
+} else if (len == 0) {
+len = -1;
}
Does this fix http://bugs.php.net/bug.php?id=31192 ?
Try it? :)
Sorry, I currently lack the resources to verify this myself.
- Markus
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/sybase_ct php_sybase_ct.c
Make a separate checkout in an empty directory and try this: cvs co -r PHP_4_3 php4/ext/sybase_ct/php_sybase_ct.c On Sun, Dec 08, 2002 at 04:01:32PM +0100, Timm Friebe wrote : On Sun, 2002-12-08 at 10:28, Jani Taskinen wrote: MFH?? --Jani I'm sorry, I've tried the following: $ cvs update -j PHP_4_3 ext/sybase_ct/php_sybase_ct.c doesn't do anything, nor does: $ cvs update -j PHP_4_3 -j 1.74 ext/sybase_ct/php_sybase_ct.c Then again: $ cvs update -j 1.74 -j PHP_4_3 ext/sybase_ct/php_sybase_ct.c wants to remove php_sybase_ct.c cvs server: scheduling ext/sybase_ct/php_sybase_ct.c for removal $ cvs status -v ext/sybase_ct/php_sybase_ct.c === File: no file php_sybase_ct.c Status: Locally Removed Working revision:-1.74 Repository revision: 1.74 /repository/php4/ext/sybase_ct/php_sybase_ct.c,v Sticky Tag: (none) Sticky Date: (none) Sticky Options: (none) OK, so this is _definitely_ not what I want. So, currently, this is what is showing (and what was showing before, e.g. yesterday): $ cvs status -v ext/sybase_ct/php_sybase_ct.c === File: php_sybase_ct.c Status: Up-to-date Working revision:1.74 Repository revision: 1.74 /repository/php4/ext/sybase_ct/php_sybase_ct.c,v Sticky Tag: (none) Sticky Date: (none) Sticky Options: (none) Existing Tags: php_4_3_0RC2(revision: 1.73) php_4_3_0RC1(revision: 1.73) PHP_4_3 (branch: 1.73.2) php_4_3_0pre2 (revision: 1.70) php_4_3_0pre1 (revision: 1.70) php_4_3_0_dev_zend2_alpha3 (revision: 1.70) [...shortened for brevity...] What's wrong? How does this magic MFH (merge from head?) work? I mean, I see it all the time, and have been reading http://www.cvshome.org/docs/manual/cvs_5.html#SEC54 for a while now, but don't seem to get what I have to do to make the PHP_4_3 branch contain the contents of HEAD (1.74). I know you're not here to support CVS lamers... maybe you can give me a hint, anyway? On Sat, 7 Dec 2002, Timm Friebe wrote: thekid Sat Dec 7 14:49:31 2002 EDT Modified files: /php4/ext/sybase_ctphp_sybase_ct.c Log: - Fixed three memory leaks - Fixed segfault with sybase_unbuffered_query() and unfetched resultsets [...] -- Timm Friebe [EMAIL PROTECTED] -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /main rfc1867.c
On Thu, Oct 24, 2002 at 03:47:21PM +0900, Moriyoshi Koizumi wrote : This commit occurred on the HEAD branch. Was it intended for some other branch or is the log message incorrect? Neither, though I don't know what you really mean. My previous patch to main/rfc1867.c was wrong, so I've corrected it. Is something going wrong with that? He meant your log message: MFH; we would see a nasty problem again if it was not fixed... MFH means Merge from HEAD and thus it surely puzzles people if you actually apply it to HEAD and not to a branch. -- GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc $ grep docref_root php.ini docref_root = http://landonize.it/?how=urltheme=classicfilter=RichyHuser=imajesurl=http%3A%2F%2Fphp.net%2F/; -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 / NEWS
mfischerFri Oct 18 03:29:40 2002 EDT Modified files: /php4 NEWS Log: - word_count() - str_word_count() Index: php4/NEWS diff -u php4/NEWS:1.1214 php4/NEWS:1.1215 --- php4/NEWS:1.1214Thu Oct 17 20:34:26 2002 +++ php4/NEWS Fri Oct 18 03:29:40 2002 -19,7 +19,7 - Changed registry entries under HKLM\SOFTWARE\PHP\Per Directory Values to work also with administrative directives such as safe_mode, open_basedir, etc. (Claudio Felber) -- Added word_count() function which counts words inside a string. (Ilia) +- Added str_word_count() function which counts words inside a string. (Ilia) - Added PGSQL_CONNECT_FORCE_NEW option to pg_connect() (Yasuo) - Added ICONV_IMPL and ICONV_VERSION constants to iconv extension to indicate which iconv implementation is used. (Moriyoshi) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd_topal.c
On Thu, Oct 17, 2002 at 12:06:30AM -0700, Rasmus Lerdorf wrote : So you are saying you want to make it optional? Because as it is there is no way to not give a value. Exactly. I don't see any really compelling reason to do that. When you convert a truecolor image to a palette-based one, not providing the size of this palette doesn't make any sense to me. Ok, not a big issue. Seems it was just me who thought a default value of 256 would make sense ;) -- GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc rei_ Derick, while ($xml) $ass-get_new_ideas(); [James] Markus: IE on_user_fart() -- People doesn't seem to like the new XHTML2 specs :) -- -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /main config.w32.h.in
Unless you fix the rest of the occurences of these symbolic defines this patch (which is the same Stig commited) is a bit problematic and will not work properly. Take a look at http://lxr.php.net/source/php4/main/main.c#1100 and see how PEAR_INSTALL_DIR is registered; sizeof() doesn't work as you might expect with the CONDENV construct. Please test before commit: C:\cygwin\home\mfischer\isrc\cvs\php4\Debug_TSphp test.php Warning: String is not zero-terminated (c:\php4\pear) (source: c:\cygwin\home\mfischer\isrc\cvs\php4\zend\zend_constants .c:239) in C:\cygwin\home\mfischer\isrc\cvs\php4\Debug_TS\test.php on line 2 string(3) c:\ C:\cygwin\home\mfischer\isrc\cvs\php4\Debug_TSset PEAR_INSTALLDIR=whatever C:\cygwin\home\mfischer\isrc\cvs\php4\Debug_TSphp test.php Warning: String is not zero-terminated (whatever) (source: c:\cygwin\home\mfischer\isrc\cvs\php4\zend\zend_constants.c:2 39) in C:\cygwin\home\mfischer\isrc\cvs\php4\Debug_TS\test.php on line 2 string(3) wha - Markus On Wed, Oct 16, 2002 at 07:37:28AM -, Sebastian Bergmann wrote : sebastian Wed Oct 16 03:37:28 2002 EDT Modified files: /php4/mainconfig.w32.h.in Log: Patch by Urs Gehrig [EMAIL PROTECTED]. Index: php4/main/config.w32.h.in diff -u php4/main/config.w32.h.in:1.17 php4/main/config.w32.h.in:1.18 --- php4/main/config.w32.h.in:1.17Fri Oct 11 05:20:38 2002 +++ php4/main/config.w32.h.in Wed Oct 16 03:37:28 2002 @@ -2,22 +2,24 @@ Build Configuration for Win32. This has only been tested with MS VisualC++ 6 (and later). - $Id: config.w32.h.in,v 1.17 2002/10/11 09:20:38 edink Exp $ + $Id: config.w32.h.in,v 1.18 2002/10/16 07:37:28 sebastian Exp $ */ +#define CONDENV(ev,def) (getenv(ev)!=NULL?getenv(ev):def) + /* Default PHP / PEAR directories */ -#define CONFIGURATION_FILE_PATH php.ini -#define PEAR_INSTALLDIR c:\\php4\\pear -#define PHP_BINDIR c:\\php4 -#define PHP_CONFIG_FILE_PATH (getenv(SystemRoot))?getenv(SystemRoot): -#define PHP_CONFIG_FILE_SCAN_DIR -#define PHP_DATADIR c:\\php4 -#define PHP_EXTENSION_DIR c:\\php4 -#define PHP_INCLUDE_PATH .;c:\\php4\\pear -#define PHP_LIBDIR c:\\php4 -#define PHP_LOCALSTATEDIR c:\\php4 -#define PHP_PREFIX c:\\php4 -#define PHP_SYSCONFDIR c:\\php4 +#define CONFIGURATION_FILE_PATH php.ini +#define PEAR_INSTALLDIR CONDENV(PEAR_INSTALLDIR, c:\\php4\\pear) +#define PHP_BINDIRCONDENV(PHP_BINDIR, c:\\php4) +#define PHP_CONFIG_FILE_PATH CONDENV(SystemRoot, ) +#define PHP_CONFIG_FILE_SCAN_DIR CONDENV(PHP_CONFIG_FILE_SCAN_DIR, ) +#define PHP_DATADIR CONDENV(PHP_DATADIR, c:\\php4) +#define PHP_EXTENSION_DIR c:\\php4 +#define PHP_INCLUDE_PATH .;c:\\php4\\pear +#define PHP_LIBDIRCONDENV(PHP_LIBDIR, c:\\php4) +#define PHP_LOCALSTATEDIR CONDENV(PHP_LOCALSTATEDIR, c:\\php4) +#define PHP_PREFIXCONDENV(PHP_PREFIX, c:\\php4) +#define PHP_SYSCONFDIRCONDENV(PHP_SYSCONFDIR, c:\\php4) /* Enable / Disable BCMATH extension (default: enabled) */ #define WITH_BCMATH 1 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc rei_ Derick, while ($xml) $ass-get_new_ideas(); [James] Markus: IE on_user_fart() -- People doesn't seem to like the new XHTML2 specs :) -- -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd_topal.c
Just a sidenote: I think if this would also be fixed in
gd/gd.c then we could prevent a segfault with the external gd
library too.
On Wed, Oct 16, 2002 at 10:34:45PM -, Rasmus Lerdorf wrote :
rasmusWed Oct 16 18:34:45 2002 EDT
Modified files:
/php4/ext/gd/libgdgd_topal.c
Log:
Fix for bug #19941
Index: php4/ext/gd/libgd/gd_topal.c
diff -u php4/ext/gd/libgd/gd_topal.c:1.7 php4/ext/gd/libgd/gd_topal.c:1.8
--- php4/ext/gd/libgd/gd_topal.c:1.7 Sun Oct 6 13:47:50 2002
+++ php4/ext/gd/libgd/gd_topal.c Wed Oct 16 18:34:44 2002
-1493,7 +1493,7
my_cquantize_ptr cquantize = 0;
int i;
size_t arraysize;
- if (!im-trueColor)
+ if (!im-trueColor || colorsWanted = 0)
{
/* Nothing to do! */
return;
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc
rei_ Derick, while ($xml) $ass-get_new_ideas();
[James] Markus: IE on_user_fart()
-- People doesn't seem to like the new XHTML2 specs :) --
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd_topal.c
On Wed, Oct 16, 2002 at 09:52:53PM -0700, Rasmus Lerdorf wrote : It's not an issue in the external gd since this function doesn't work at all there. They had colorsWanted hardcoded to 256. Ah! Ok, another suggestion. Wouldn't it make sense to have the last parameter default to 256 if left out? - Markus -- GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc rei_ Derick, while ($xml) $ass-get_new_ideas(); [James] Markus: IE on_user_fart() -- People doesn't seem to like the new XHTML2 specs :) -- -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd_topal.c
On Wed, Oct 16, 2002 at 11:12:25PM -0700, Rasmus Lerdorf wrote : It's not an optional arg though. So by leaving it off, do you mean if an invalid value is given? I don't like changing args like that. Yes I know it's not optional. But having it default to 256 colors makes sense if the value is not given (I think). Another thing I just saw: if you pass a negative value to the last parameter it segfaults too -- GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc rei_ Derick, while ($xml) $ass-get_new_ideas(); [James] Markus: IE on_user_fart() -- People doesn't seem to like the new XHTML2 specs :) -- -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 /win32 php4dllts.dsp
mfischerTue Oct 15 12:56:01 2002 EDT Modified files: /php4/win32 php4dllts.dsp Log: - Define LINK_SIZE=2 needed for newly updated pcrelib; fixes Win32 build. # Getting linker warning about using local defined _php_pcre_exec now at the # end, anything serious ? Index: php4/win32/php4dllts.dsp diff -u php4/win32/php4dllts.dsp:1.86 php4/win32/php4dllts.dsp:1.87 --- php4/win32/php4dllts.dsp:1.86 Thu Sep 26 02:10:22 2002 +++ php4/win32/php4dllts.dspTue Oct 15 12:56:00 2002 -450,22 +450,22 # Begin Source File SOURCE=..\ext\pcre\pcrelib\get.c -# ADD CPP /D STATIC /D SUPPORT_UTF8 +# ADD CPP /D STATIC /D SUPPORT_UTF8 /D LINK_SIZE=2 # End Source File # Begin Source File SOURCE=..\ext\pcre\pcrelib\maketables.c -# ADD CPP /D STATIC /D SUPPORT_UTF8 +# ADD CPP /D STATIC /D SUPPORT_UTF8 /D LINK_SIZE=2 # End Source File # Begin Source File SOURCE=..\ext\pcre\pcrelib\pcre.c -# ADD CPP /D STATIC /D SUPPORT_UTF8 +# ADD CPP /D STATIC /D SUPPORT_UTF8 /D LINK_SIZE=2 # End Source File # Begin Source File SOURCE=..\ext\pcre\pcrelib\study.c -# ADD CPP /D STATIC /D SUPPORT_UTF8 +# ADD CPP /D STATIC /D SUPPORT_UTF8 /D LINK_SIZE=2 # End Source File # End Group # Begin Group Header Files No. 3 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 /ext/standard/tests/strings explode.phpt
mfischerFri Oct 11 14:06:15 2002 EDT Modified files: /php4/ext/standard/tests/stringsexplode.phpt Log: - Document were the first test came from. Index: php4/ext/standard/tests/strings/explode.phpt diff -u php4/ext/standard/tests/strings/explode.phpt:1.1 php4/ext/standard/tests/strings/explode.phpt:1.2 --- php4/ext/standard/tests/strings/explode.phpt:1.1Fri Oct 11 11:19:57 2002 +++ php4/ext/standard/tests/strings/explode.phptFri Oct 11 14:06:15 2002 -6,6 +6,7 error_reporting=2047 --FILE-- ?php +/* From http://bugs.php.net/19865 */ echo md5(var_export(explode(\1, a. chr(1). b. chr(0). d . chr(1) . f . chr(1). 1 . chr(1) . d), TRUE)); echo \n; var_dump(explode(, )); -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 / NEWS
mfischerWed Oct 9 03:45:18 2002 EDT
Modified files:
/php4 NEWS
Log:
- Update
Index: php4/NEWS
diff -u php4/NEWS:1.1193 php4/NEWS:1.1194
--- php4/NEWS:1.1193Tue Oct 8 09:43:02 2002
+++ php4/NEWS Wed Oct 9 03:45:17 2002
-4,6 +4,7
- ATTENTION! make install will *by default* install the CLI SAPI binary in
{PREFIX}/bin/php. If you don't disable the CGI binary, it will be
installed as {PREFIX}/bin/php-cgi.
+- Fixed bug #19280 (imap_header fails with many To: addresses). (Ilia)
- Added mb_regex_set_options(). The Options parameters of various mbregex
functions are now deprecated. (Moriyoshi)
- Fixed bug #19482 (Segfault with PCRE and locale). (Andrei)
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c
No function never called RETURN_FALSE if
zend_parse_parameters couldn't successfully parse the passed
parameters.
Are we going to change this behaviour globally?
Function up and including today returned NULL if there was a
problem with parsing the parameters.
This could well break BC in my eyes. Is this absolutely
necessary ?
On Fri, Oct 04, 2002 at 05:17:01PM -, Marcus Börger wrote :
helly Fri Oct 4 13:17:01 2002 EDT
Modified files:
/php4/ext/standardbasic_functions.c
Log:
return FALSE on error
Index: php4/ext/standard/basic_functions.c
diff -u php4/ext/standard/basic_functions.c:1.522
php4/ext/standard/basic_functions.c:1.523
--- php4/ext/standard/basic_functions.c:1.522 Thu Oct 3 09:31:59 2002
+++ php4/ext/standard/basic_functions.c Fri Oct 4 13:17:01 2002
-17,7 +17,7
+--+
*/
-/* $Id: basic_functions.c,v 1.522 2002/10/03 13:31:59 yohgaki Exp $ */
+/* $Id: basic_functions.c,v 1.523 2002/10/04 17:17:01 helly Exp $ */
#include php.h
#include php_streams.h
-1377,7 +1377,7
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, s,
options, options_len) ==
FAILURE) {
- return;
+ RETURN_FALSE;
[...]
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4(PHP_4_2_0) / NEWS
mfischerSun Sep 29 18:15:15 2002 EDT Modified files: (Branch: PHP_4_2_0) /php4 NEWS Log: - Update Index: php4/NEWS diff -u php4/NEWS:1.885.2.63 php4/NEWS:1.885.2.64 --- php4/NEWS:1.885.2.63Tue Sep 17 05:18:45 2002 +++ php4/NEWS Sun Sep 29 18:15:14 2002 -1,6 +1,7 PHP 4 NEWS ||| ?? ??? 2002, Version 4.2.4 +- Fixed bug #19292 (open_basedir restriction problem). (Rasmus) - Fixed a corruption bug in the thread-safe version (Michael Sisolak) - Fixed file_exists(), is_readable(), is_writable(), and is_executable() on multi-threaded non-windows platforms. (Edin) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 / NEWS
mfischerSat Sep 28 04:56:33 2002 EDT Modified files: /php4 NEWS Log: - Don't forget whom to blame ... ;) Index: php4/NEWS diff -u php4/NEWS:1.1145 php4/NEWS:1.1146 --- php4/NEWS:1.1145Fri Sep 27 20:34:07 2002 +++ php4/NEWS Sat Sep 28 04:56:33 2002 -3,7 +3,7 ? ? ??? 2002, Version 4.3.0 - Added stream_select() which works like socket_select but only works on streams returned by fopen(), fsockopen() and pfsockopen(). (Wez) -- Fixed bug #19595 (Missing functions for GD2 format handling). +- Fixed bug #19595 (Missing functions for GD2 format handling). (Edin) - Fix for bug #19633 (wrong directories in ext/ldap/config.m4). (Derick) - Fixed bugs #17274 and #19627 (segfault in sem_remove). (Wez) - Fixed bug #18022 (fopen does not work with php://stdin anymore on Solaris). -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 / NEWS
mfischerFri Sep 27 03:02:12 2002 EDT Modified files: /php4 NEWS Log: - Update. Index: php4/NEWS diff -u php4/NEWS:1.1140 php4/NEWS:1.1141 --- php4/NEWS:1.1140Thu Sep 26 16:54:55 2002 +++ php4/NEWS Fri Sep 27 03:02:12 2002 -1,6 +1,9 PHP 4 NEWS ||| ? ? ??? 2002, Version 4.3.0 +- Fixed bug #11643 (Session related, fix SID redefinition). (Ilia) +- Fixed bug #18556 (Scripting Engine, problem with locales like tr_TR). + (Ilia) - Changed y2k_compliance to default to 1 now. (Sascha) - Added platform independent socket error constants for better error handling. - Fixed include(), require() and GD functions to work with remote files under -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 / php.ini-recommended
mfischerThu Sep 26 03:05:19 2002 EDT Modified files: /php4 php.ini-recommended Log: - Merge url_rewriter.tags description from Sascha. Index: php4/php.ini-recommended diff -u php4/php.ini-recommended:1.108 php4/php.ini-recommended:1.109 --- php4/php.ini-recommended:1.108 Wed Sep 25 19:34:50 2002 +++ php4/php.ini-recommendedThu Sep 26 03:05:17 2002 -851,6 +851,11 ; always using URL stored in browser's history or bookmarks. session.use_trans_sid = 0 +; The URL rewriter will look for URLs in a defined set of HTML tags. +; form/fieldset are special; if you include them here, the rewriter will +; add a hidden input field with the info which is otherwise appended +; to URLs. If you want XHTML conformity, remove the form entry. +; Note that all valid entries require a =, even if no value follows. url_rewriter.tags = a=href,area=href,frame=src,input=src,form=fakeentry [MSSQL] -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php4 / NEWS
mfischerThu Sep 26 03:38:03 2002 EDT Modified files: /php4 NEWS Log: - Add missing bug fixes. # Please always add a NEWS entry for fixed bugs. # The NEWS entry are added to http://php.net/ChangeLog-4.php after every # released and the fixed bugs are auto(vi)matically linked to the BTS. # So please also conform to the #number style (no one violated this, but # just in case ;). Index: php4/NEWS diff -u php4/NEWS:1.1136 php4/NEWS:1.1137 --- php4/NEWS:1.1136Wed Sep 25 21:20:38 2002 +++ php4/NEWS Thu Sep 26 03:38:02 2002 -11,6 +11,12 - Fixed compile errors in the FriBidi extension (Bug #16414). (Tal) - Fixed bugs #7472, #12120 and #12989 as well as other potential problems with strip_tags() function. (Ilia) +- Fixed bugs #17570 and #17957 (Regexps related). (Andrei, Ilia) +- Fixed bugs #18167 and #16859 (SEGV with session_decode). (Ilia) +- Fixed bugs #19573 and #13472 (Session, XHTML compliance and + trans_sid). (Sascha) +- Fix #19570 (last character was missing in + get_html_translation_table). (Wez) - Upgraded PCRE to version 3.9. (Wez) - Fixed bug in OCIResult() which returned garbage when called on empty result-sets. (Thies) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php4 /ext/session session.c
Guys,
_Please_ include bug fixes in NEWS entries (or separately
commit them) so we've complete log.
Browsing back the ChangeLog and finding missing treasures
ain't that funny.
;)
thanks,
- Markus
On Thu, Sep 26, 2002 at 06:12:27PM -, Ilia Alshanetsky wrote :
iliaa Thu Sep 26 14:12:27 2002 EDT
Modified files:
/php4/ext/session session.c
Log:
Fixed bug #11643
Index: php4/ext/session/session.c
diff -u php4/ext/session/session.c:1.317 php4/ext/session/session.c:1.318
--- php4/ext/session/session.c:1.317 Thu Sep 26 12:46:21 2002
+++ php4/ext/session/session.cThu Sep 26 14:12:27 2002
-17,7 +17,7
+--+
*/
-/* $Id: session.c,v 1.317 2002/09/26 16:46:21 sniper Exp $ */
+/* $Id: session.c,v 1.318 2002/09/26 18:12:27 iliaa Exp $ */
#ifdef HAVE_CONFIG_H
#include config.h
-826,6 +826,7
int module_number = PS(module_number);
int nrand;
int lensess;
+ zend_constant *c;
PS(apply_trans_sid) = PS(use_trans_sid);
-919,7 +920,11
php_session_send_cookie(TSRMLS_C);
}
-
+ /* check if SID constant exists, if it does destroy it. */
+ if (zend_hash_find(EG(zend_constants), sid, 4, (void **) c) != FAILURE) {
+ zend_hash_del(EG(zend_constants), sid, 4);
+ }
+
if (define_sid) {
smart_str var = {0};
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc
rei_ Derick, while ($xml) $ass-get_new_ideas();
[James] Markus: IE on_user_fart()
-- People doesn't seem to like the new XHTML2 specs :) --
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
