[PHP-CVS] 回复： [PHP-CVS] com php-src: Fix broken test This was missing a %s for the path here: ext/session/tests/bug60860.phpt

2012-12-16 Thread Reeze Xia 
Hi,
   This test failed with diff:

003+ Fatal error: session_start(): Failed to initialize storage module: user 
(path: ) in /Users/reeze/Opensource/php-tes
t/php-src-master/ext/session/tests/bug60860.php on line 3^M
003- Fatal error: session_start(): Failed to initialize storage module: user 
(path: %s) in %s on line 3


The `PG(save_path)` might be empty, how about:

(path: %s)
(path:%s)


--  
reeze | reeze.cn

已使用 Sparrow (http://www.sparrowmailapp.com/?sig)  

在 2012年12月14日星期五，上午8:13，Rasmus Lerdorf 写道：

> Commit: eecdb4c254bafe5fc53b1e06055482944cd3560f
> Author: Rasmus Lerdorf mailto:ras...@php.net)> Thu, 13 Dec 
> 2012 16:13:37 -0800
> Parents: a11606b18fd20be1048a858eb5011fb7117855a9
> Branches: PHP-5.3 PHP-5.4 master
>  
> Link: 
> http://git.php.net/?p=php-src.git;a=commitdiff;h=eecdb4c254bafe5fc53b1e06055482944cd3560f
>  
> Log:
> Fix broken test
> This was missing a %s for the path here
>  
> Changed paths:
> M ext/session/tests/bug60860.phpt
>  
>  
> Diff:
> diff --git a/ext/session/tests/bug60860.phpt b/ext/session/tests/bug60860.phpt
> index 1231020..223fb35 100644
> --- a/ext/session/tests/bug60860.phpt
> +++ b/ext/session/tests/bug60860.phpt
> @@ -14,4 +14,4 @@ echo "ok\n";
> --EXPECTF--
> Warning: session_start(): user session functions not defined in %s on line 3
>  
> -Fatal error: session_start(): Failed to initialize storage module: user 
> (path: ) in %s on line 3
> +Fatal error: session_start(): Failed to initialize storage module: user 
> (path: %s) in %s on line 3
>  
>  
> --  
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>  
>

Re: [PHP-CVS] com php-src: Fix broken test This was missing a %s for the path here: ext/session/tests/bug60860.phpt

2012-12-13 Thread Rasmus Lerdorf 
I forgot 5.5 initially here and merged it:

http://git.php.net/?p=php-src.git;a=commitdiff;h=17b803d4488931603517ac6c11180fffae93a82f

Not sure why there was no email notification about that.

On 12/13/2012 04:13 PM, Rasmus Lerdorf wrote:
> Commit:eecdb4c254bafe5fc53b1e06055482944cd3560f
> Author:Rasmus Lerdorf  Thu, 13 Dec 2012 16:13:37 
> -0800
> Parents:   a11606b18fd20be1048a858eb5011fb7117855a9
> Branches:  PHP-5.3 PHP-5.4 master
> 
> Link:   
> http://git.php.net/?p=php-src.git;a=commitdiff;h=eecdb4c254bafe5fc53b1e06055482944cd3560f
> 
> Log:
> Fix broken test
> This was missing a %s for the path here
> 
> Changed paths:
>   M  ext/session/tests/bug60860.phpt
> 
> 
> Diff:
> diff --git a/ext/session/tests/bug60860.phpt b/ext/session/tests/bug60860.phpt
> index 1231020..223fb35 100644
> --- a/ext/session/tests/bug60860.phpt
> +++ b/ext/session/tests/bug60860.phpt
> @@ -14,4 +14,4 @@ echo "ok\n";
>  --EXPECTF--
>  Warning: session_start(): user session functions not defined in %s on line 3
>  
> -Fatal error: session_start(): Failed to initialize storage module: user 
> (path: ) in %s on line 3
> +Fatal error: session_start(): Failed to initialize storage module: user 
> (path: %s) in %s on line 3
> 
> 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] com php-src: Fix broken test This was missing a %s for the path here: ext/session/tests/bug60860.phpt

2012-12-13 Thread Rasmus Lerdorf 
Commit:eecdb4c254bafe5fc53b1e06055482944cd3560f
Author:Rasmus Lerdorf  Thu, 13 Dec 2012 16:13:37 
-0800
Parents:   a11606b18fd20be1048a858eb5011fb7117855a9
Branches:  PHP-5.3 PHP-5.4 master

Link:   
http://git.php.net/?p=php-src.git;a=commitdiff;h=eecdb4c254bafe5fc53b1e06055482944cd3560f

Log:
Fix broken test
This was missing a %s for the path here

Changed paths:
  M  ext/session/tests/bug60860.phpt


Diff:
diff --git a/ext/session/tests/bug60860.phpt b/ext/session/tests/bug60860.phpt
index 1231020..223fb35 100644
--- a/ext/session/tests/bug60860.phpt
+++ b/ext/session/tests/bug60860.phpt
@@ -14,4 +14,4 @@ echo "ok\n";
 --EXPECTF--
 Warning: session_start(): user session functions not defined in %s on line 3
 
-Fatal error: session_start(): Failed to initialize storage module: user (path: 
) in %s on line 3
+Fatal error: session_start(): Failed to initialize storage module: user (path: 
%s) in %s on line 3


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php