Re: [PHP-CVS] com php-src: Fix failed test: ext/session/tests/bug60860.phpt

2012-12-17 Thread Hannes Magnusson
On Sun, Dec 16, 2012 at 8:56 PM, Xinchen Hui larue...@php.net wrote:
 Commit:d2cc09704951d8746d06decf95ea981426b8278b
 Author:Xinchen Hui larue...@php.net Mon, 17 Dec 2012 12:56:55 
 +0800
 Parents:   7a49e09fd8ef612df45e540a5b1895b045c46235
 Branches:  PHP-5.3

 Link:   
 http://git.php.net/?p=php-src.git;a=commitdiff;h=d2cc09704951d8746d06decf95ea981426b8278b

 Log:
 Fix failed test

 Changed paths:
   M  ext/session/tests/bug60860.phpt


 Diff:
 diff --git a/ext/session/tests/bug60860.phpt b/ext/session/tests/bug60860.phpt
 index 223fb35..8318586 100644
 --- a/ext/session/tests/bug60860.phpt
 +++ b/ext/session/tests/bug60860.phpt
 @@ -14,4 +14,4 @@ echo ok\n;
  --EXPECTF--
  Warning: session_start(): user session functions not defined in %s on line 3

 -Fatal error: session_start(): Failed to initialize storage module: user 
 (path: %s) in %s on line 3
 +Fatal error: session_start(): Failed to initialize storage module: user 
 (path:%s) in %s on line 3

Wouldn't it make sense to update the code to have quotes around the path itself?
The errormessage now just looks weird, like there is a bug in the code.

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] com php-src: Fix failed test: ext/session/tests/bug60860.phpt

2012-12-16 Thread Xinchen Hui
Commit:d2cc09704951d8746d06decf95ea981426b8278b
Author:Xinchen Hui larue...@php.net Mon, 17 Dec 2012 12:56:55 
+0800
Parents:   7a49e09fd8ef612df45e540a5b1895b045c46235
Branches:  PHP-5.3

Link:   
http://git.php.net/?p=php-src.git;a=commitdiff;h=d2cc09704951d8746d06decf95ea981426b8278b

Log:
Fix failed test

Changed paths:
  M  ext/session/tests/bug60860.phpt


Diff:
diff --git a/ext/session/tests/bug60860.phpt b/ext/session/tests/bug60860.phpt
index 223fb35..8318586 100644
--- a/ext/session/tests/bug60860.phpt
+++ b/ext/session/tests/bug60860.phpt
@@ -14,4 +14,4 @@ echo ok\n;
 --EXPECTF--
 Warning: session_start(): user session functions not defined in %s on line 3
 
-Fatal error: session_start(): Failed to initialize storage module: user (path: 
%s) in %s on line 3
+Fatal error: session_start(): Failed to initialize storage module: user 
(path:%s) in %s on line 3


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php