Re: [PHP-CVS] com php-src: Really fix leaks, add test cases to prove it...: ext/standard/password.c ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_hash_er

2012-10-16 Thread Nuno Lopes 

Hi,


+ case IS_BOOL:
+ case IS_NULL:
  case IS_RESOURCE:
  case IS_ARRAY:
  default:


it doesn't make sense to have those cases and the default. Please remove all 
those useless cases.


Nuno 



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] com php-src: Really fix leaks, add test cases to prove it...: ext/standard/password.c ext/standard/tests/password/password_bcrypt_errors.phpt ext/standard/tests/password/password_hash_er

2012-10-16 Thread Anthony Ferrara 
Nuno,

On Tue, Oct 16, 2012 at 2:14 PM, Nuno Lopes nlop...@php.net wrote:

 Hi,

  + case IS_BOOL:
 + case IS_NULL:
   case IS_RESOURCE:
   case IS_ARRAY:
   default:


 it doesn't make sense to have those cases and the default. Please remove
 all those useless cases.


I see it as self-documentation to include them as it indicates without
needing to think that it's intentional that they are treated as default. If
the overall consensus is that they should be removed, that's fine (and I'll
remove them). But I consider this more readable and easier to comprehend
than without...

Thoughts?

Anthony