Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
Its may break BC, but it actually fixes a bug, unless I am missing something there is nothing special about # at the start of a .php file that would imply by itself that this line should be skipped. I am not suggesting we touch 5.2, but for 5.3 and beyond it makes sense to have this fix. On 5-Jan-09, at 3:33 PM, Nuno Lopes wrote: Well,.. at least it breaks BC. I think I prefer not breaking BC in this case, as it doesn't hurt much.. Nuno - Original Message - The fact that any line starting with # was ignored is actually a bug, the original intent (even in 5.2 where the bug also exists in CLI) was to handle #!/path/to/executable With the new code the check is more strict looking for # followed by !, I think its probably the desired behavior what do you guys think? On 5-Jan-09, at 11:17 AM, Antony Dovgal wrote: On 05.01.2009 19:06, Ilia Alshanetsky wrote: Would it not be better to use :memory:, in memory DB and avoid the file creation entirely, it'll also speed up test a bit. Anything would do, as long as it doesn't pollute my /tmp dir. Did you see this, btw: http://news.php.net/php.cvs/55354 ? Ilia Alshanetsky -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
Well,.. at least it breaks BC. I think I prefer not breaking BC in this case, as it doesn't hurt much.. Nuno - Original Message - The fact that any line starting with # was ignored is actually a bug, the original intent (even in 5.2 where the bug also exists in CLI) was to handle #!/path/to/executable With the new code the check is more strict looking for # followed by !, I think its probably the desired behavior what do you guys think? On 5-Jan-09, at 11:17 AM, Antony Dovgal wrote: On 05.01.2009 19:06, Ilia Alshanetsky wrote: Would it not be better to use :memory:, in memory DB and avoid the file creation entirely, it'll also speed up test a bit. Anything would do, as long as it doesn't pollute my /tmp dir. Did you see this, btw: http://news.php.net/php.cvs/55354 ? -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
The fact that any line starting with # was ignored is actually a bug, the original intent (even in 5.2 where the bug also exists in CLI) was to handle #!/path/to/executable With the new code the check is more strict looking for # followed by !, I think its probably the desired behavior what do you guys think? On 5-Jan-09, at 11:17 AM, Antony Dovgal wrote: On 05.01.2009 19:06, Ilia Alshanetsky wrote: Would it not be better to use :memory:, in memory DB and avoid the file creation entirely, it'll also speed up test a bit. Anything would do, as long as it doesn't pollute my /tmp dir. Did you see this, btw: http://news.php.net/php.cvs/55354 ? -- Wbr, Antony Dovgal Ilia Alshanetsky -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
On 05.01.2009 19:06, Ilia Alshanetsky wrote: > Would it not be better to use :memory:, in memory DB and avoid the > file creation entirely, it'll also speed up test a bit. Anything would do, as long as it doesn't pollute my /tmp dir. Did you see this, btw: http://news.php.net/php.cvs/55354 ? -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
Would it not be better to use :memory:, in memory DB and avoid the file creation entirely, it'll also speed up test a bit. On 5-Jan-09, at 11:01 AM, Antony Dovgal wrote: tony2001Mon Jan 5 16:01:45 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pdo/tests bug_44159.phpt Log: create temporary db in the current dir and cleanup on completion http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/bug_44159.phpt?r1=1.1.4.4&r2=1.1.4.5&diff_format=u Index: php-src/ext/pdo/tests/bug_44159.phpt diff -u php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.4 php-src/ext/pdo/ tests/bug_44159.phpt:1.1.4.5 --- php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.4 Thu Apr 10 19:09:49 2008 +++ php-src/ext/pdo/tests/bug_44159.phptMon Jan 5 16:01:45 2009 @@ -7,7 +7,8 @@ --FILE-- $attrs = array(PDO::ATTR_STATEMENT_CLASS, PDO::ATTR_STRINGIFY_FETCHES, PDO::NULL_TO_STRING); @@ -17,6 +18,8 @@ var_dump($pdo->setAttribute($attr, 'nonsense')); } +...@unlink($dir."/foo.db"); + ?> --EXPECTF-- Warning: PDO::setAttribute(): SQLSTATE[HY000]: General error: PDO::ATTR_STATEMENT_CLASS requires format array(classname, array(ctor_args)); the classname must be a string specifying an existing class in %s on line %d -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php Ilia Alshanetsky -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
tony2001Mon Jan 5 16:01:45 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pdo/tests bug_44159.phpt Log: create temporary db in the current dir and cleanup on completion http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/bug_44159.phpt?r1=1.1.4.4&r2=1.1.4.5&diff_format=u Index: php-src/ext/pdo/tests/bug_44159.phpt diff -u php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.4 php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.5 --- php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.4Thu Apr 10 19:09:49 2008 +++ php-src/ext/pdo/tests/bug_44159.phptMon Jan 5 16:01:45 2009 @@ -7,7 +7,8 @@ --FILE-- setAttribute($attr, 'nonsense')); } +...@unlink($dir."/foo.db"); + ?> --EXPECTF-- Warning: PDO::setAttribute(): SQLSTATE[HY000]: General error: PDO::ATTR_STATEMENT_CLASS requires format array(classname, array(ctor_args)); the classname must be a string specifying an existing class in %s on line %d -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
felipe Fri Feb 22 02:45:37 2008 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pdo/tests bug_44159.phpt Log: Fix test http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/bug_44159.phpt?r1=1.1.4.2&r2=1.1.4.3&diff_format=u Index: php-src/ext/pdo/tests/bug_44159.phpt diff -u php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.2 php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.3 --- php-src/ext/pdo/tests/bug_44159.phpt:1.1.4.2Tue Feb 19 14:53:44 2008 +++ php-src/ext/pdo/tests/bug_44159.phptFri Feb 22 02:45:37 2008 @@ -23,10 +23,11 @@ Warning: PDO::setAttribute(): SQLSTATE[HY000]: General error: PDO::ATTR_STATEMENT_CLASS requires format array(classname, array(ctor_args)); the classname must be a string specifying an existing class in %s on line %d bool(false) + +Warning: PDO::setAttribute(): SQLSTATE[HY000]: General error: attribute value must be an integer in %s on line %d +bool(false) bool(true) bool(true) bool(true) bool(true) bool(true) -bool(true) - -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo/tests bug_44159.phpt
felipe Tue Feb 19 14:53:44 2008 UTC Added files: (Branch: PHP_5_2) /php-src/ext/pdo/tests bug_44159.phpt Log: New test http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/bug_44159.phpt?view=markup&rev=1.1 Index: php-src/ext/pdo/tests/bug_44159.phpt +++ php-src/ext/pdo/tests/bug_44159.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
