Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug43522.phpt /main/streams streams.c

2007-12-29 Thread Antony Dovgal 
On 13.12.2007 09:57, Antony Dovgal wrote:
> On 13.12.2007 03:17, Ilia Alshanetsky wrote:
>> I tested with valgrind 3.2.3 and I see no memory errors, what valgrind  
>> are you using? Could it be a bug in 3.3.0 valgrind?
> 
> Both 3.2.3 and 3.3.0 report this error.
> 
> See ext/standard/tests/file/stream_get_line.phpt and 
> ext/standard/tests/file/bug30362.phpt.
> bug43522.phpt doesn't show up this problem, sorry.

The issue is still there.

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug43522.phpt /main/streams streams.c

2007-12-12 Thread Antony Dovgal 
On 13.12.2007 03:17, Ilia Alshanetsky wrote:
> I tested with valgrind 3.2.3 and I see no memory errors, what valgrind  
> are you using? Could it be a bug in 3.3.0 valgrind?

Both 3.2.3 and 3.3.0 report this error.

See ext/standard/tests/file/stream_get_line.phpt and 
ext/standard/tests/file/bug30362.phpt.
bug43522.phpt doesn't show up this problem, sorry.

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug43522.phpt /main/streams streams.c

2007-12-12 Thread Ilia Alshanetsky 
I tested with valgrind 3.2.3 and I see no memory errors, what valgrind  
are you using? Could it be a bug in 3.3.0 valgrind?



On 11-Dec-07, at 3:45 AM, Antony Dovgal wrote:


On 10.12.2007 17:16, Ilia Alshanetsky wrote:

iliaa   Mon Dec 10 14:16:57 2007 UTC

 Added files: (Branch: PHP_5_3)
   /php-src/ext/standard/tests/file bug43522.phpt

 Modified files:
   /php-src/main/streamsstreams.c
 Log:

 Fixed bug #43522 (stream_get_line() eats additional characters)


Ilia, the patch doesn't look correct.

==19357== Conditional jump or move depends on uninitialised value(s)
==19357==at 0x4C23A4C: memchr (in /usr/lib64/valgrind/amd64- 
linux/vgpreload_memcheck.so)

==19357==by 0x86E631: zend_memnstr (zend_operators.h:226)
==19357==by 0x86E4D2: php_stream_get_record (streams.c:870)
==19357==by 0x81B4DA: zif_stream_get_line (streamsfuncs.c:1204)
==19357==by 0x8E2542: zend_do_fcall_common_helper_SPEC  
(zend_vm_execute.h:191)
==19357==by 0x8E8873: ZEND_DO_FCALL_SPEC_CONST_HANDLER  
(zend_vm_execute.h:1389)

==19357==by 0x8E1F72: execute (zend_vm_execute.h:87)
==19357==by 0x8B62C3: zend_execute_scripts (zend.c:1139)
==19357==by 0x854E49: php_execute_script (main.c:2008)
==19357==by 0x95107F: main (php_cli.c:1140)

--
Wbr,
Antony Dovgal

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Ilia Alshanetsky

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug43522.phpt /main/streams streams.c

2007-12-11 Thread Antony Dovgal 
On 10.12.2007 17:16, Ilia Alshanetsky wrote:
> iliaa Mon Dec 10 14:16:57 2007 UTC
> 
>   Added files: (Branch: PHP_5_3)
> /php-src/ext/standard/tests/file  bug43522.phpt 
> 
>   Modified files:  
> /php-src/main/streams streams.c 
>   Log:
>   
>   Fixed bug #43522 (stream_get_line() eats additional characters)

Ilia, the patch doesn't look correct.

==19357== Conditional jump or move depends on uninitialised value(s)
==19357==at 0x4C23A4C: memchr (in 
/usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so)
==19357==by 0x86E631: zend_memnstr (zend_operators.h:226)
==19357==by 0x86E4D2: php_stream_get_record (streams.c:870)
==19357==by 0x81B4DA: zif_stream_get_line (streamsfuncs.c:1204)
==19357==by 0x8E2542: zend_do_fcall_common_helper_SPEC 
(zend_vm_execute.h:191)
==19357==by 0x8E8873: ZEND_DO_FCALL_SPEC_CONST_HANDLER 
(zend_vm_execute.h:1389)
==19357==by 0x8E1F72: execute (zend_vm_execute.h:87)
==19357==by 0x8B62C3: zend_execute_scripts (zend.c:1139)
==19357==by 0x854E49: php_execute_script (main.c:2008)
==19357==by 0x95107F: main (php_cli.c:1140)

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file bug43522.phpt /main/streams streams.c

2007-12-10 Thread Ilia Alshanetsky 
iliaa   Mon Dec 10 14:16:57 2007 UTC

  Added files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/filebug43522.phpt 

  Modified files:  
/php-src/main/streams   streams.c 
  Log:
  
  Fixed bug #43522 (stream_get_line() eats additional characters)
  
http://cvs.php.net/viewvc.cgi/php-src/main/streams/streams.c?r1=1.82.2.6.2.18.2.1&r2=1.82.2.6.2.18.2.2&diff_format=u
Index: php-src/main/streams/streams.c
diff -u php-src/main/streams/streams.c:1.82.2.6.2.18.2.1 
php-src/main/streams/streams.c:1.82.2.6.2.18.2.2
--- php-src/main/streams/streams.c:1.82.2.6.2.18.2.1Tue Nov  6 11:02:36 2007
+++ php-src/main/streams/streams.c  Mon Dec 10 14:16:57 2007
@@ -19,7 +19,7 @@
+--+
  */
 
-/* $Id: streams.c,v 1.82.2.6.2.18.2.1 2007/11/06 11:02:36 helly Exp $ */
+/* $Id: streams.c,v 1.82.2.6.2.18.2.2 2007/12/10 14:16:57 iliaa Exp $ */
 
 #define _GNU_SOURCE
 #include "php.h"
@@ -860,9 +860,9 @@
toread = maxlen;
} else {
if (delim_len == 1) {
-   e = memchr(stream->readbuf + stream->readpos, *delim, 
stream->writepos - stream->readpos);
+   e = memchr(stream->readbuf + stream->readpos, *delim, 
maxlen);
} else {
-   e = php_memnstr(stream->readbuf + stream->readpos, 
delim, delim_len, (stream->readbuf + stream->writepos));
+   e = php_memnstr(stream->readbuf + stream->readpos, 
delim, delim_len, (stream->readbuf + stream->readpos + maxlen));
}
 
if (!e) {

http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/bug43522.phpt?view=markup&rev=1.1
Index: php-src/ext/standard/tests/file/bug43522.phpt
+++ php-src/ext/standard/tests/file/bug43522.phpt

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php