Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/strings highlight_file.phpt ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h
shire Wed Mar 11 22:11:54 2009 UTC Modified files: (Branch: PHP_5_3) /ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h /php-src/ext/standard/tests/strings highlight_file.phpt Log: MFH: Add proper EOF handling for language scanner. Fixes bug #46817. This is not really the right fix.. I can accept this solution *temporarily*, but this breaks BC.. We need a better solution in the long run. I'm sorry but I haven't had time to work on this lately.. Nuno -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/strings highlight_file.phpt ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h
Nuno Lopes wrote: shire Wed Mar 11 22:11:54 2009 UTC Modified files: (Branch: PHP_5_3) /ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h /php-src/ext/standard/tests/strings highlight_file.phpt Log: MFH: Add proper EOF handling for language scanner. Fixes bug #46817. This is not really the right fix.. I can accept this solution *temporarily*, but this breaks BC.. We need a better solution in the long run. I'm sorry but I haven't had time to work on this lately.. Understood, working on a fix. If I can't get a fix in for this today I'll revert. If this is causing issues for anyone right now let me know and I'll back the change out of course... -shire -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/strings highlight_file.phpt ZendEngine2 zend_language_scanner.c zend_language_scanner.l zend_language_scanner_defs.h zend_stream.h
Hello shire, Wednesday, March 11, 2009, 11:55:00 PM, you wrote: Marcus Boerger wrote: Hello Brian, thanks for looking into this. The patch looks pretty good for the most part. But you effectively create a BC issue here becuase you no longer allow \0 inside a php file or string. You might want to test whether a length check in your NULL rules fixes that. That check would either return the \0 if inside the code or return 0 if in the lookahead block. Thanks Marcus, Sorry I probably should have worked through that more. I'll try that and see if I can work around this correctly this evening, perhaps another possibility is that I could handle the null chars in places where they are valid such as within strings. (Are there any other constructs that could contain these that I might be missing?) I think it is only correct outside php scope and inside strings, and here- as well as now-docs. marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
