Re: [PHP-CVS] cvs: php-src / unicode-todo.txt /ext/filter filter.c /ext/mbstring mb_gpc.c /ext/pcre php_pcre.c /ext/standard basic_functions.c basic_functions.h php_string.h string.c /main SAPI.c
This commit has added 14 segfaults in the tests (HEAD only, ZTS only). The backtrace is always similar to this: Core was generated by `/local/qa/head.zts/sapi/cgi/php-cgi -C -n -d output_handler= -d open_basedir= -'. Program terminated with signal 11, Segmentation fault. #0 0x7fc5ae41ddd3 in ?? () from /usr/lib64/libicuuc.so.40 (gdb) bt #0 0x7fc5ae41ddd3 in ?? () from /usr/lib64/libicuuc.so.40 #1 0x008dfec0 in zend_string_to_unicode_ex (conv=0x137c2b0, target=0x7fffb90c9d30, target_len=0x7fffb90c9d1c, source=0x137c4d8 PHPSESSID, source_len=9, status=0x7fffb90c9cb8) at /local/qa/head.zts/Zend/zend_unicode.c:226 #2 0x008e1351 in zend_string_to_unicode (conv=0x137c2b0, u=0x7fffb90c9d30, u_len=0x7fffb90c9d1c, s=0x137c4d8 PHPSESSID, s_len=9, tsrm_ls=0xfc71b0) at /local/qa/head.zts/Zend/zend_unicode.c:604 #3 0x008463ac in php_register_variable_with_conv (conv=0x137c2b0, var=0x137c4d8 PHPSESSID, var_len=9, val=0x137c4e2 rfc1867-tests, val_len=13, array_ptr=0x137c3b0, filter_arg=2, tsrm_ls=0xfc71b0) at /local/qa/head.zts/main/php_variables.c:56 #4 0x00848052 in php_default_treat_data (arg=2, str=0x0, destArray=0x0, tsrm_ls=0xfc71b0) at /local/qa/head.zts/main/php_variables.c:616 #5 0x00849482 in php_hash_environment (tsrm_ls=0xfc71b0) at /local/qa/head.zts/main/php_variables.c:933 #6 0x0082e9d1 in php_request_startup (tsrm_ls=0xfc71b0) at /local/qa/head.zts/main/main.c:1489 #7 0x00a1e8e5 in main (argc=85, argv=0x7fffb90cc408) at /local/qa/head.zts/sapi/cgi/cgi_main.c:1972 (gdb) f 1 #1 0x008dfec0 in zend_string_to_unicode_ex (conv=0x137c2b0, target=0x7fffb90c9d30, target_len=0x7fffb90c9d1c, source=0x137c4d8 PHPSESSID, source_len=9, status=0x7fffb90c9cb8) at /local/qa/head.zts/Zend/zend_unicode.c:226 226 ucnv_resetToUnicode(conv); -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src / unicode-todo.txt /ext/filter filter.c /ext/mbstring mb_gpc.c /ext/pcre php_pcre.c /ext/standard basic_functions.c basic_functions.h php_string.h string.c /main SAPI.c
Jani Taskinen wrote: Is this really correct (rfc1867.c): - register_http_post_files_variable(lbuf, s+1, http_post_files, 0 TSRMLS_CC); + register_raw_var(lbuf, s+1, strlen(s+1), files_vars TSRMLS_CC); That 'strlen(s+1)' looks kinda wrong..? And to not cause more compile failures, configure option --enable-maintainer-zts helps. :) It's correct. We're registering a string starting from s+1 position, so we need to get the length starting from that position too. -Andrei -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Thu Jan 18 16:45:43 2007 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.23r2=1.24diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.23 php-src/unicode-todo.txt:1.24 --- php-src/unicode-todo.txt:1.23 Tue Oct 3 19:35:37 2006 +++ php-src/unicode-todo.txtThu Jan 18 16:45:43 2007 @@ -35,7 +35,8 @@ performance difference when doing quickCheck + normalize versus simple normalize. -* UG(unicode) is turned off during MINIT() currently. We need to figure out - a way to avoid turning it off. +* USTR_MAKE() should be estrndup(EMPTY_STR) -* USTR_MAKE() should be EMPTY_STR +* See if ext/pcre can ba adjusted to allow operations on pure binary + strings. Ideal mode would be: convert all IS_UNICODE to UTF-8, assume that + binary strings with /u modifier are UTF-8, otherwise it's pure binary. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Tue Oct 3 19:35:37 2006 UTC Modified files: /php-srcunicode-todo.txt Log: Update. http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.22r2=1.23diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.22 php-src/unicode-todo.txt:1.23 --- php-src/unicode-todo.txt:1.22 Thu Aug 3 23:09:29 2006 +++ php-src/unicode-todo.txtTue Oct 3 19:35:37 2006 @@ -24,14 +24,8 @@ * Control of fallback mappings in conversions. -* Review the decision to coerce binary strings to Unicode when used as array - keys. - * Figure out generic approach to locale validation/fallback. -* Relax requirement on mixing unicode/binary strings in parameters - (zend_get_unified_string_type() callers and others) - * Constant registration/fetching should do identifier normalization. * Make zend_u_str_case_fold() do only case-folding and nothing else. The -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Wed Aug 2 19:54:48 2006 UTC Modified files: /php-srcunicode-todo.txt Log: Some updates. http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.20r2=1.21diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.20 php-src/unicode-todo.txt:1.21 --- php-src/unicode-todo.txt:1.20 Wed Aug 2 19:49:32 2006 +++ php-src/unicode-todo.txtWed Aug 2 19:54:48 2006 @@ -5,30 +5,22 @@ * Discuss putting ZEND_ATTRIBUTE_FORMAT back on zend_error() or create a new zend_error_ex() function that supports new specifiers -* Determine how to deal with filesystem and filenames when Unicode is - involved. This concerns both the extension functions and things like - compile_file(), open_file_for_scanning(), etc. - -* Measure performance difference when doing quickCheck + normalize versus - simple normalize. - * Find all instances where unicode strings are compared with memcmp() and replace either with u_memcmpCodePointOrder() or ucol_strcoll() -* Opening a collator may return U_USING_DEFAULT_WARNING, - U_USING_FALLBACK_WARNING +* Opening a collator may return U_USING_DEFAULT_WARNING, U_USING_FALLBACK_WARNING * Need to finish making HTTP input work as described in the design doc. It is almost there, but needs to handle conversion errors and provide a way to - explicitly re-decode raw data with specified encoding. Also check for - _charset_ request field which might be present. + explicitly re-decode raw data with specified encoding (input filter, + perhaps?). Also check for _charset_ request field which might be present. * Optimize T_INLINE_HTML blocks conversion by either creating a converter cache or remembering the last used converter in the executor globals. * What to do with binary string literals and runtime casting? Literals are in script_encoding, casting uses runtime_encoding. If they are different, bad - stuff happens. + stuff happens. Maybe those who do that stuff should suffer anyway. * Control of fallback mappings in conversions. @@ -42,9 +34,12 @@ * Constant registration/fetching should do identifier normalization. -* Identifier normalization in callbacks (zend_is_callable/zend_u_lookup_class) - * Make zend_u_str_case_fold() do only case-folding and nothing else. The normalization should be done by zend_normalize_identifier(). -* Look at performance implications of identifier normalization. +* Look at performance implications of identifier normalization. Measure + performance difference when doing quickCheck + normalize versus simple + normalize. + +* UG(unicode) is turned off during MINIT() currently. We need to figure out + a way to avoid turning it off. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Wed Aug 2 19:49:32 2006 UTC
Modified files:
/php-srcunicode-todo.txt
Log:
http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.19r2=1.20diff_format=u
Index: php-src/unicode-todo.txt
diff -u php-src/unicode-todo.txt:1.19 php-src/unicode-todo.txt:1.20
--- php-src/unicode-todo.txt:1.19 Thu Jul 20 18:14:50 2006
+++ php-src/unicode-todo.txtWed Aug 2 19:49:32 2006
@@ -32,13 +32,6 @@
* Control of fallback mappings in conversions.
-* Introduce ability to request strings in a specific encoding in parameter
-parsing API, e.g.:
-
-if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, s(ASCII),
-locale, locale_len) == FAILURE) {
-}
-
* Review the decision to coerce binary strings to Unicode when used as array
keys.
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Thu Jul 20 18:14:50 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.18r2=1.19diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.18 php-src/unicode-todo.txt:1.19 --- php-src/unicode-todo.txt:1.18 Mon Jul 17 19:19:09 2006 +++ php-src/unicode-todo.txtThu Jul 20 18:14:50 2006 @@ -53,3 +53,5 @@ * Make zend_u_str_case_fold() do only case-folding and nothing else. The normalization should be done by zend_normalize_identifier(). + +* Look at performance implications of identifier normalization. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Mon Jul 17 19:19:09 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.17r2=1.18diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.17 php-src/unicode-todo.txt:1.18 --- php-src/unicode-todo.txt:1.17 Fri Jul 14 18:06:30 2006 +++ php-src/unicode-todo.txtMon Jul 17 19:19:09 2006 @@ -50,3 +50,6 @@ * Constant registration/fetching should do identifier normalization. * Identifier normalization in callbacks (zend_is_callable/zend_u_lookup_class) + +* Make zend_u_str_case_fold() do only case-folding and nothing else. The + normalization should be done by zend_normalize_identifier(). -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Fri Jul 14 18:06:30 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.16r2=1.17diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.16 php-src/unicode-todo.txt:1.17 --- php-src/unicode-todo.txt:1.16 Fri Jul 14 17:35:53 2006 +++ php-src/unicode-todo.txtFri Jul 14 18:06:30 2006 @@ -48,3 +48,5 @@ (zend_get_unified_string_type() callers and others) * Constant registration/fetching should do identifier normalization. + +* Identifier normalization in callbacks (zend_is_callable/zend_u_lookup_class) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Tue Jul 11 22:42:55 2006 UTC
Modified files:
/php-srcunicode-todo.txt
Log:
http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.14r2=1.15diff_format=u
Index: php-src/unicode-todo.txt
diff -u php-src/unicode-todo.txt:1.14 php-src/unicode-todo.txt:1.15
--- php-src/unicode-todo.txt:1.14 Mon Jul 10 23:09:34 2006
+++ php-src/unicode-todo.txtTue Jul 11 22:42:55 2006
@@ -38,3 +38,6 @@
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, s(ASCII),
locale, locale_len) == FAILURE) {
}
+
+* Review the decision to coerce binary strings to Unicode when used as array
+ keys.
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Mon Jul 10 23:09:34 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.13r2=1.14diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.13 php-src/unicode-todo.txt:1.14 --- php-src/unicode-todo.txt:1.13 Fri Jun 23 21:26:48 2006 +++ php-src/unicode-todo.txtMon Jul 10 23:09:34 2006 @@ -20,7 +20,8 @@ * Need to finish making HTTP input work as described in the design doc. It is almost there, but needs to handle conversion errors and provide a way to - explicitly re-decode raw data with specified encoding. + explicitly re-decode raw data with specified encoding. Also check for + _charset_ request field which might be present. * Optimize T_INLINE_HTML blocks conversion by either creating a converter cache or remembering the last used converter in the executor globals. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Fri Jun 23 21:26:48 2006 UTC
Modified files:
/php-srcunicode-todo.txt
Log:
http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.12r2=1.13diff_format=u
Index: php-src/unicode-todo.txt
diff -u php-src/unicode-todo.txt:1.12 php-src/unicode-todo.txt:1.13
--- php-src/unicode-todo.txt:1.12 Fri Jun 23 00:08:18 2006
+++ php-src/unicode-todo.txtFri Jun 23 21:26:48 2006
@@ -30,3 +30,10 @@
stuff happens.
* Control of fallback mappings in conversions.
+
+* Introduce ability to request strings in a specific encoding in parameter
+parsing API, e.g.:
+
+if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, s(ASCII),
+locale, locale_len) == FAILURE) {
+}
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Fri Jun 23 00:08:18 2006 UTC Modified files: /php-srcunicode-todo.txt Log: Update. http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.11r2=1.12diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.11 php-src/unicode-todo.txt:1.12 --- php-src/unicode-todo.txt:1.11 Thu Jun 22 23:49:40 2006 +++ php-src/unicode-todo.txtFri Jun 23 00:08:18 2006 @@ -5,9 +5,6 @@ * Discuss putting ZEND_ATTRIBUTE_FORMAT back on zend_error() or create a new zend_error_ex() function that supports new specifiers -* Should we apply identifier validity checks in functions that deal with - identifiers, such as define(), get_class(), etc? - * Determine how to deal with filesystem and filenames when Unicode is involved. This concerns both the extension functions and things like compile_file(), open_file_for_scanning(), etc. @@ -25,8 +22,6 @@ is almost there, but needs to handle conversion errors and provide a way to explicitly re-decode raw data with specified encoding. -* output.c needs a lot of work as it passes char* around - * Optimize T_INLINE_HTML blocks conversion by either creating a converter cache or remembering the last used converter in the executor globals. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Thu Jun 22 23:49:40 2006 UTC Modified files: /php-srcunicode-todo.txt Log: Fixed in ICU 3.6. http://cvs.php.net/viewvc.cgi/php-src/unicode-todo.txt?r1=1.10r2=1.11diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.10 php-src/unicode-todo.txt:1.11 --- php-src/unicode-todo.txt:1.10 Mon Mar 27 19:18:40 2006 +++ php-src/unicode-todo.txtThu Jun 22 23:49:40 2006 @@ -8,9 +8,6 @@ * Should we apply identifier validity checks in functions that deal with identifiers, such as define(), get_class(), etc? -* Resolve the differences in %G output format. sprintf() removes trailing - zeroes from the fractional part, and u_sprintf() doesn't. - * Determine how to deal with filesystem and filenames when Unicode is involved. This concerns both the extension functions and things like compile_file(), open_file_for_scanning(), etc. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Mon Mar 27 19:18:40 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewcvs.cgi/php-src/unicode-todo.txt?r1=1.9r2=1.10diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.9 php-src/unicode-todo.txt:1.10 --- php-src/unicode-todo.txt:1.9Sun Mar 26 21:46:01 2006 +++ php-src/unicode-todo.txtMon Mar 27 19:18:40 2006 @@ -5,16 +5,6 @@ * Discuss putting ZEND_ATTRIBUTE_FORMAT back on zend_error() or create a new zend_error_ex() function that supports new specifiers -* Finalize zend_hash_get_current_key_ex() discussion. We probably need to - have zend_u_hash_get_current_key_ex() and have the old function proxy to it. - The question is what happens when an IS_UNICODE key is present and the old - function is called. - -* use zend_literal_to_unicode when comparing this and such - -* fix string offset operator to work only on strings, and array offset one - to work only on arrays - * Should we apply identifier validity checks in functions that deal with identifiers, such as define(), get_class(), etc? @@ -25,36 +15,21 @@ involved. This concerns both the extension functions and things like compile_file(), open_file_for_scanning(), etc. -* Use U_STRING_DECL/U_STRING/INIT for initializing literals possibly. - * Measure performance difference when doing quickCheck + normalize versus simple normalize. -* Find all instances where unicode strings are compare with memcmp() and +* Find all instances where unicode strings are compared with memcmp() and replace either with u_memcmpCodePointOrder() or ucol_strcoll() * Opening a collator may return U_USING_DEFAULT_WARNING, U_USING_FALLBACK_WARNING -* Need to make http input work as described in the design doc. - -* Solve ZTS issues. Some extensions store pointers to internal - zend_class_entries during extension startup, but these pointers can be changed - from request to request (dependent on unicode setting). Right now these - pointers are reinitialized during request startup but they are still stored - in real global variables. Probably the problem should be solved in other way - or pinters to zend_class_entries should be stored in module globals. +* Need to finish making HTTP input work as described in the design doc. It + is almost there, but needs to handle conversion errors and provide a way to + explicitly re-decode raw data with specified encoding. * output.c needs a lot of work as it passes char* around -* Should strtoupper()/strtolower() use full or simple case mapping? - -* Replace all instances of EMPTY_STR with U_EMPTY_STR which is defined to be - ((UChar*)\0\0) - -* Change implementation of strtoupper()/strtolower() to use simple case - mapping. - * Optimize T_INLINE_HTML blocks conversion by either creating a converter cache or remembering the last used converter in the executor globals. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Sun Mar 26 21:46:01 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewcvs.cgi/php-src/unicode-todo.txt?r1=1.8r2=1.9diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.8 php-src/unicode-todo.txt:1.9 --- php-src/unicode-todo.txt:1.8Sun Mar 26 00:56:23 2006 +++ php-src/unicode-todo.txtSun Mar 26 21:46:01 2006 @@ -61,3 +61,5 @@ * What to do with binary string literals and runtime casting? Literals are in script_encoding, casting uses runtime_encoding. If they are different, bad stuff happens. + +* Control of fallback mappings in conversions. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Sun Mar 26 00:56:24 2006 UTC Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/viewcvs.cgi/php-src/unicode-todo.txt?r1=1.7r2=1.8diff_format=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.7 php-src/unicode-todo.txt:1.8 --- php-src/unicode-todo.txt:1.7Wed Aug 24 21:04:33 2005 +++ php-src/unicode-todo.txtSun Mar 26 00:56:23 2006 @@ -57,3 +57,7 @@ * Optimize T_INLINE_HTML blocks conversion by either creating a converter cache or remembering the last used converter in the executor globals. + +* What to do with binary string literals and runtime casting? Literals are in + script_encoding, casting uses runtime_encoding. If they are different, bad + stuff happens. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Wed Aug 24 17:04:33 2005 EDT Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/diff.php/php-src/unicode-todo.txt?r1=1.6r2=1.7ty=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.6 php-src/unicode-todo.txt:1.7 --- php-src/unicode-todo.txt:1.6Tue Aug 23 18:03:47 2005 +++ php-src/unicode-todo.txtWed Aug 24 17:04:33 2005 @@ -55,5 +55,5 @@ * Change implementation of strtoupper()/strtolower() to use simple case mapping. -* Store script encoding in the oparray structure and use it to convert - T_INLINE_HTML blocks. +* Optimize T_INLINE_HTML blocks conversion by either creating a converter + cache or remembering the last used converter in the executor globals. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Wed Aug 17 14:16:45 2005 EDT Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/diff.php/php-src/unicode-todo.txt?r1=1.2r2=1.3ty=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.2 php-src/unicode-todo.txt:1.3 --- php-src/unicode-todo.txt:1.2Fri Aug 12 14:14:26 2005 +++ php-src/unicode-todo.txtWed Aug 17 14:16:44 2005 @@ -47,14 +47,4 @@ * output.c needs a lot of work as it passes char* around -* Require and/or bundle ICU 3.4. - -* Right now if a function passes TT to zend_parse_parameters(), and one of - the arguments is IS_BINARY, then all of the rest of T arguments are - converted to IS_BINARY as well. I will modify it so that if one of the other - arguments is IS_UNICODE then we generate an error and abort parsing. If we - do run across a function that really needs to accept IS_BINARY as one - argument and IS_UNICODE as another, then we can use bu for the parsing - format. - * Should strtoupper()/strtolower() use full or simple case mapping? -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Wed Aug 17 19:12:28 2005 EDT Modified files: /php-srcunicode-todo.txt Log: http://cvs.php.net/diff.php/php-src/unicode-todo.txt?r1=1.3r2=1.4ty=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.3 php-src/unicode-todo.txt:1.4 --- php-src/unicode-todo.txt:1.3Wed Aug 17 14:16:44 2005 +++ php-src/unicode-todo.txtWed Aug 17 19:12:24 2005 @@ -48,3 +48,6 @@ * output.c needs a lot of work as it passes char* around * Should strtoupper()/strtolower() use full or simple case mapping? + +* Replace all instances of EMPTY_STR with U_EMPTY_STR which is defined to be + ((UChar*)\0\0) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / unicode-todo.txt
andrei Fri Aug 12 14:14:31 2005 EDT Modified files: /php-srcunicode-todo.txt Log: Update. http://cvs.php.net/diff.php/php-src/unicode-todo.txt?r1=1.1r2=1.2ty=u Index: php-src/unicode-todo.txt diff -u php-src/unicode-todo.txt:1.1 php-src/unicode-todo.txt:1.2 --- php-src/unicode-todo.txt:1.1Thu Aug 11 19:35:53 2005 +++ php-src/unicode-todo.txtFri Aug 12 14:14:26 2005 @@ -57,5 +57,4 @@ argument and IS_UNICODE as another, then we can use bu for the parsing format. -* Comparison operators should act similar to concatenation one, check the - types and coerce when necessary. +* Should strtoupper()/strtolower() use full or simple case mapping? -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
