Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.cmbstring.h/main rfc1867.c
At this point we are then knowingly and blatantly violating the license. This would be extremely hard to justify if anybody calls us on it. -Rasmus On Mon, 27 Oct 2003, Derick Rethans wrote: > On Sun, 26 Oct 2003, Moriyoshi Koizumi wrote: > > > > 3. the new implementation with libmbfl is well tested in PHP 5 > > > since last August. > > > > I doubt it somewhat, since we haven't got no handful of reports from who > > put beta with libmbfl in action. > > Yeah, I'm also doubting this. Let's not do it for 4.3.4 please as it > requires atleast one more RC. > > Derick > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.cmbstring.h/main rfc1867.c
Perfect, thanks for letting me know. On October 27, 2003 05:20 pm, Rui Hirokawa wrote: > I think the patch commited now fix the licensing incompatibility > as Moriyoshi said. > > Rui -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.cmbstring.h/main rfc1867.c
I think the patch commited now fix the licensing incompatibility as Moriyoshi said. Rui On Mon, 27 Oct 2003 13:09:18 -0400 Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: > To summarize this discussion could you please verify that the patch now > committed does in fact completely fix the licensing issue. From some of the > previous comments (maybe I misunderstood) it seems that new code is too not > entirely license safe (??). > > Thanks, > > Ilia > > P.S. Did you see the patch by Joe Orton on internals, it seems that there is > a compile problem with mbregex. -- Rui Hirokawa <[EMAIL PROTECTED]> -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.cmbstring.h/main rfc1867.c
To summarize this discussion could you please verify that the patch now committed does in fact completely fix the licensing issue. From some of the previous comments (maybe I misunderstood) it seems that new code is too not entirely license safe (??). Thanks, Ilia P.S. Did you see the patch by Joe Orton on internals, it seems that there is a compile problem with mbregex. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.cmbstring.h/main rfc1867.c
On Sun, 26 Oct 2003, Moriyoshi Koizumi wrote: > > 3. the new implementation with libmbfl is well tested in PHP 5 > > since last August. > > I doubt it somewhat, since we haven't got no handful of reports from who > put beta with libmbfl in action. Yeah, I'm also doubting this. Let's not do it for 4.3.4 please as it requires atleast one more RC. Derick -- "Interpreting what the GPL actually means is a job best left to those that read the future by examining animal entrails." - Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/ - -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.cmbstring.h/main rfc1867.c
Rui Hirokawa <[EMAIL PROTECTED]> wrote: > 2. The differences of libmbfl and the current implementation are > quite small because the new implementation is based on the current > implementation. Yeah, I hope the impact is just as ignorable as of a mere bug fix, but I should also mention that I'm not that pretty sure how it actually does while most of the work concerning the reconstruction of libmbfl from what used to be here in the 4.x branch was done by me. > 3. the new implementation with libmbfl is well tested in PHP 5 > since last August. I doubt it somewhat, since we haven't got no handful of reports from who put beta with libmbfl in action. > 4. the new implementation was already confirmed > to pass the all unit tests in ext/mbstring/tests/*. The fact is that I had to patch mbstring.c and rewrite some tests to keep them neat. Anyway, the license really is the deal, we should move on. Moriyoshi -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
