Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/interbase/ ibase_query.c

2011-08-16 Thread Hannes Magnusson 
5.4, trunk and a NEWS entry?

-Hannes

On Tue, Jul 19, 2011 at 22:25, Popa Adrian Marius mar...@php.net wrote:
 mariuz                                   Tue, 19 Jul 2011 20:25:51 +

 Revision: http://svn.php.net/viewvc?view=revisionrevision=313447

 Log:
 Fix for bug http://bugs.php.net/54426

 Checks for NULL are wrong as the values can be provided by the triggers

 Changed paths:
    U   php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c

 Modified: php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c
 ===
 --- php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c    2011-07-19 
 20:23:26 UTC (rev 313446)
 +++ php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c    2011-07-19 
 20:25:51 UTC (rev 313447)
 @@ -672,14 +672,7 @@
                                if (! force_null) break;

                        case IS_NULL:
 -
 -                               /* complain if this field doesn't allow NULL 
 values */
 -                               if (! (var-sqltype  1)) {
 -                                       _php_ibase_module_error(Parameter 
 %d: non-empty value required TSRMLS_CC, i+1);
 -                                       rv = FAILURE;
 -                               } else {
                                        buf[i].sqlind = -1;
 -                               }

                                if (var-sqltype  SQL_ARRAY) ++array_cnt;



 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/interbase/ ibase_query.c

2011-07-19 Thread Popa Adrian Marius 
mariuz   Tue, 19 Jul 2011 20:25:51 +

Revision: http://svn.php.net/viewvc?view=revisionrevision=313447

Log:
Fix for bug http://bugs.php.net/54426

Checks for NULL are wrong as the values can be provided by the triggers

Changed paths:
U   php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c

Modified: php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c
===
--- php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c2011-07-19 
20:23:26 UTC (rev 313446)
+++ php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c2011-07-19 
20:25:51 UTC (rev 313447)
@@ -672,14 +672,7 @@
if (! force_null) break;

case IS_NULL:
-
-   /* complain if this field doesn't allow NULL 
values */
-   if (! (var-sqltype  1)) {
-   _php_ibase_module_error(Parameter %d: 
non-empty value required TSRMLS_CC, i+1);
-   rv = FAILURE;
-   } else {
buf[i].sqlind = -1;
-   }

if (var-sqltype  SQL_ARRAY) ++array_cnt;


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/interbase/ ibase_query.c

2009-07-25 Thread Kalle Sommer Nielsen 
kalleSat, 25 Jul 2009 23:37:47 +

Revision: http://svn.php.net/viewvc?view=revisionrevision=286330

Log:
Fixed bug #48189 (ibase_execute error in return param)

Bug: http://bugs.php.net/48189 (Assigned) ibase_execute error in return param
  
Changed paths:
U   php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c

Modified: php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c
===
--- php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c2009-07-25 
22:20:18 UTC (rev 286329)
+++ php/php-src/branches/PHP_5_3/ext/interbase/ibase_query.c2009-07-25 
23:37:47 UTC (rev 286330)
@@ -1031,8 +1031,7 @@
if (affected_rows) {
RETVAL_LONG(affected_rows);
} else {
-   /* this return value evaluates to 
bool(true) and to int(0) */
-   RETVAL_STRINGL(0 ,2,1);
+   RETVAL_TRUE;
}
break;
}

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php