Re: [PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
hi, Please merge to 5.3 On Wed, Mar 2, 2011 at 6:22 AM, Moriyoshi Koizumi moriyo...@php.net wrote: moriyoshi Wed, 02 Mar 2011 05:22:22 + Modified: php/php-src/trunk/win32/build/config.w32 === --- php/php-src/trunk/win32/build/config.w32 2011-03-02 03:59:38 UTC (rev 308838) +++ php/php-src/trunk/win32/build/config.w32 2011-03-02 05:22:22 UTC (rev 308839) @@ -271,7 +271,7 @@ var php_usual_lib_suspects = PHP_PHP_BUILD+\\lib; ADD_FLAG(CFLAGS, '/I ' + php_usual_include_suspects + ' '); -ADD_FLAG(LDFLAGS, '/libpath:\\' + php_usual_lib_suspects + '\\ '); +ADD_FLAG(LDFLAGS, '/libpath:' + php_usual_lib_suspects + ' '); Why this change? Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
Hi, On Wed, Mar 2, 2011 at 5:58 PM, Pierre Joye pierre@gmail.com wrote: hi, Please merge to 5.3 Done. On Wed, Mar 2, 2011 at 6:22 AM, Moriyoshi Koizumi moriyo...@php.net wrote: moriyoshi Wed, 02 Mar 2011 05:22:22 + Modified: php/php-src/trunk/win32/build/config.w32 === --- php/php-src/trunk/win32/build/config.w32 2011-03-02 03:59:38 UTC (rev 308838) +++ php/php-src/trunk/win32/build/config.w32 2011-03-02 05:22:22 UTC (rev 308839) @@ -271,7 +271,7 @@ var php_usual_lib_suspects = PHP_PHP_BUILD+\\lib; ADD_FLAG(CFLAGS, '/I ' + php_usual_include_suspects + ' '); -ADD_FLAG(LDFLAGS, '/libpath:\\' + php_usual_lib_suspects + '\\ '); +ADD_FLAG(LDFLAGS, '/libpath:' + php_usual_lib_suspects + ' '); Why this change? The library path needs to be quoted just once. It appears old compiler frontends (VC6, 7?) used to have a bug with which arguments to the linker containing whitespaces weren't properly dealt with. Regards, Moriyoshi Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
hi, On Wed, Mar 2, 2011 at 7:35 PM, Moriyoshi Koizumi m...@mozo.jp wrote: Please merge to 5.3 Done. Thanks! On Wed, Mar 2, 2011 at 6:22 AM, Moriyoshi Koizumi moriyo...@php.net wrote: moriyoshi Wed, 02 Mar 2011 05:22:22 + Modified: php/php-src/trunk/win32/build/config.w32 === --- php/php-src/trunk/win32/build/config.w32 2011-03-02 03:59:38 UTC (rev 308838) +++ php/php-src/trunk/win32/build/config.w32 2011-03-02 05:22:22 UTC (rev 308839) @@ -271,7 +271,7 @@ var php_usual_lib_suspects = PHP_PHP_BUILD+\\lib; ADD_FLAG(CFLAGS, '/I ' + php_usual_include_suspects + ' '); -ADD_FLAG(LDFLAGS, '/libpath:\\' + php_usual_lib_suspects + '\\ '); +ADD_FLAG(LDFLAGS, '/libpath:' + php_usual_lib_suspects + ' '); Why this change? The library path needs to be quoted just once. It appears old compiler frontends (VC6, 7?) used to have a bug with which arguments to the linker containing whitespaces weren't properly dealt with. Did you test this specific change with VC6? Cheers -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
On Thu, Mar 3, 2011 at 3:42 AM, Pierre Joye pierre@gmail.com wrote: hi, On Wed, Mar 2, 2011 at 7:35 PM, Moriyoshi Koizumi m...@mozo.jp wrote: The library path needs to be quoted just once. It appears old compiler frontends (VC6, 7?) used to have a bug with which arguments to the linker containing whitespaces weren't properly dealt with. Did you test this specific change with VC6? Not yet, but trunk only supports VC9 or later versions. Is it really necessary for 5.3 to support VC6? Regards, Moriyoshi Cheers -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
On Thu, 2011-03-03 at 06:26 +0900, Moriyoshi Koizumi wrote: On Thu, Mar 3, 2011 at 3:42 AM, Pierre Joye pierre@gmail.com wrote: hi, On Wed, Mar 2, 2011 at 7:35 PM, Moriyoshi Koizumi m...@mozo.jp wrote: The library path needs to be quoted just once. It appears old compiler frontends (VC6, 7?) used to have a bug with which arguments to the linker containing whitespaces weren't properly dealt with. Did you test this specific change with VC6? Not yet, but trunk only supports VC9 or later versions. Is it really necessary for 5.3 to support VC6? PHP 5.3.6 won't support VC6 anymore. johannes Regards, Moriyoshi Cheers -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
Ah right, almost forgot I decided that, joy :) On 2 Mar 2011 22:37, Johannes Schlüter johan...@schlueters.de wrote: On Thu, 2011-03-03 at 06:26 +0900, Moriyoshi Koizumi wrote: On Thu, Mar 3, 2011 at 3:42 AM, Pierre Joye pierre@gmail.com wrote: hi, On Wed, Mar 2, 2011 at 7:35 PM, Moriyoshi Koizumi m...@mozo.jp wrote: The library path needs to be quoted just once. It appears old compiler frontends (VC6, 7?) used to have a bug with which arguments to the linker containing whitespaces weren't properly dealt with. Did you test this specific change with VC6? Not yet, but trunk only supports VC9 or later versions. Is it really necessary for 5.3 to support VC6? PHP 5.3.6 won't support VC6 anymore. johannes Regards, Moriyoshi Cheers -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] svn: /php/php-src/trunk/win32/build/ Makefile config.w32
moriyoshiWed, 02 Mar 2011 05:22:22 + Revision: http://svn.php.net/viewvc?view=revisionrevision=308839 Log: - Enable windows build system to accept paths containing spaces. Changed paths: U php/php-src/trunk/win32/build/Makefile U php/php-src/trunk/win32/build/config.w32 Modified: php/php-src/trunk/win32/build/Makefile === --- php/php-src/trunk/win32/build/Makefile 2011-03-02 03:59:38 UTC (rev 308838) +++ php/php-src/trunk/win32/build/Makefile 2011-03-02 05:22:22 UTC (rev 308839) @@ -93,7 +93,7 @@ @cd $(BUILD_DIR) @for %D in ($(BUILD_DIRS_SUB)) do @if not exist %D @mkdir %D NUL @if not exist $(BUILD_DIR_DEV) @mkdir $(BUILD_DIR_DEV) NUL - @cd $(PHP_SRC_DIR) + @cd $(PHP_SRC_DIR) clean-sapi: @@ -107,7 +107,7 @@ @echo Cleaning distribution build dirs @cd $(BUILD_DIR) @for %D in (_x $(BUILD_DIRS_SUB)) do @if exist %D @del /F /Q %D\*.* NUL - @cd $(PHP_SRC_DIR) + @cd $(PHP_SRC_DIR) -@del /F /Q $(BUILD_DIR)\*.res $(BUILD_DIR)\*.lib $(BUILD_DIR)\*.ilk $(BUILD_DIR)\*.pdb $(BUILD_DIR)\*.exp $(PHPDEF) $(BUILD_DIR)\php-$(PHP_VERSION_STRING)-Win32.zip $(BUILD_DIR)\pecl-$(PHP_VERSION_STRING)-Win32.zip NUL -rd /s /q $(BUILD_DIR)\php-$(PHP_VERSION_STRING) @@ -119,7 +119,7 @@ @echo Cleaning standard build dirs @cd $(BUILD_DIR) @for %D in (_x $(BUILD_DIRS_SUB)) do @if exist %D @rd /s /q %D - @cd $(PHP_SRC_DIR) + @cd $(PHP_SRC_DIR) -@del /f /q $(BUILD_DIR)\*.res $(BUILD_DIR)\*.lib $(BUILD_DIR)\*.ilk $(BUILD_DIR)\*.pdb $(BUILD_DIR)\*.exp $(PHPDEF) $(BUILD_DIR)\*.rc $(BUILD_DIR)\*.dbg $(BUILD_DIR)\*.bin $(BUILD_DIR)\php*.dll $(BUILD_DIR)\php*.exe NUL test: Modified: php/php-src/trunk/win32/build/config.w32 === --- php/php-src/trunk/win32/build/config.w322011-03-02 03:59:38 UTC (rev 308838) +++ php/php-src/trunk/win32/build/config.w322011-03-02 05:22:22 UTC (rev 308839) @@ -271,7 +271,7 @@ var php_usual_lib_suspects = PHP_PHP_BUILD+\\lib; ADD_FLAG(CFLAGS, '/I ' + php_usual_include_suspects + ' '); -ADD_FLAG(LDFLAGS, '/libpath:\\' + php_usual_lib_suspects + '\\ '); +ADD_FLAG(LDFLAGS, '/libpath:' + php_usual_lib_suspects + ' '); // Poke around for some headers function probe_basic_headers() -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
