zoe             Fri, 17 Jul 2009 17:31:07 +0000

URL: http://svn.php.net/viewvc?view=revision&revision=284277

Changed paths:
        U   php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterCSV.php
        U   php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterList.php

Log:
Part one of fix to Georg's code

Modified: php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterCSV.php
===================================================================
--- php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterCSV.php 
2009-07-17 17:17:57 UTC (rev 284276)
+++ php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterCSV.php 
2009-07-17 17:31:07 UTC (rev 284277)
@@ -25,22 +25,16 @@

     public function createOutput()
     {
-       foreach ($this->resultList as $testGroupResults) {
-
-               foreach ($testGroupResults as $testResult) {
-
+       foreach ($this->resultList as $testResult) {
                        $outputString = $testResult->getName();
                    $testStatus = $testResult->getStatus();
-
-                   foreach($testStatus->getTestStateNames() as $name) {
-
+                   foreach($testStatus->getTestStateNames() as $name) {
                        if($testStatus->getValue($name)) {
                            $outputString .= " , ". strtoupper($name);
                        }
                    }
                    $this->output .= $outputString."\n";
                }
-        }
     }

 }

Modified: php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterList.php
===================================================================
--- php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterList.php        
2009-07-17 17:17:57 UTC (rev 284276)
+++ php/phpruntests/trunk/src/testcase/output/rtTestOutputWriterList.php        
2009-07-17 17:31:07 UTC (rev 284277)
@@ -3,7 +3,7 @@
  * rtTestOutputWriterList
  *
  * Write test output line by line
- *
+ *
  * @category   Testing
  * @package    RUNTESTS
  * @author     Zoe Slattery <z...@php.net>
@@ -12,37 +12,32 @@
  * @copyright  2009 The PHP Group
  * @license    http://www.php.net/license/3_01.txt  PHP License 3.01
  * @link       http://qa.php.net/
- *
+ *
  */
 class rtTestOutputWriterList extends rtTestOutputWriter
 {
     public function __construct()
     {
-         $this->type = 'txt';
+        $this->type = 'txt';
     }

-
+
     public function createOutput()
     {
-        foreach ($this->resultList as $testGroupResults) {
-
-               foreach ($testGroupResults as $testResult) {
+        foreach ($this->resultList as $testResult) {
+            $outputString = "";
+            $testStatus = $testResult->getStatus();
+
+            foreach($testStatus->getTestStateNames() as $name) {

-                   $outputString = "";
-                   $testStatus = $testResult->getStatus();
-
-                   foreach($testStatus->getTestStateNames() as $name) {
-
-                       if ($testStatus->getValue($name)) {
-                           $outputString .= " ". strtoupper($name);
-                           $outputString .= " " . 
$testStatus->getMessage($name);
-                       }
-                   }
-
-                   $outputString .= " " . $testResult->getTitle();
-                   $outputString .= " [" . $testResult->getName() . ".phpt]";
-                   $this->output .= $outputString."\n";
-               }
+                if ($testStatus->getValue($name)) {
+                    $outputString .= " ". strtoupper($name);
+                    $outputString .= " " . $testStatus->getMessage($name);
+                }
+            }
+            $outputString .= " " . $testResult->getTitle();
+            $outputString .= " [" . $testResult->getName() . ".phpt]";
+            $this->output .= $outputString."\n";
         }
     }


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to