Re: [PHP-CVS] cvs: php-src(PHP_5_3) /pear Makefile.frag fetch.php

2008-05-14 Thread Derick Rethans 
On Mon, 14 Apr 2008, Hannes Magnusson wrote:

 bjori Mon Apr 14 16:56:51 2008 UTC
 
   Added files: (Branch: PHP_5_3)
 /php-src/pear fetch.php 
 
   Modified files:  
 /php-src/pear Makefile.frag 
   Log:
   Use PHP to fetch the pear phar

Can we please revert this. wget supports proxies and this fetch.php 
thing assumes a standard terminal is wider than 80 chars. I'm fine with 
having it as fallback, but wget and fetch should be used first.

 @@ -16,15 +14,7 @@
   if test -f $(srcdir)/install-pear-nozlib.phar; then \
   cp $(srcdir)/install-pear-nozlib.phar 
 $(builddir)/install-pear-nozlib.phar; \
   else \
 - if test ! -z $(WGET)  test -x $(WGET); then \
 - $(WGET) 
 http://pear.php.net/install-pear-nozlib.phar -nd -P $(builddir)/; \
 - elif test ! -z $(FETCH)  test -x $(FETCH); then \
 - $(FETCH) -o $(builddir)/ 
 http://pear.php.net/install-pear-nozlib.phar; \
 - else \
 - echo ; \
 - echo No download utilities found. Don't know 
 how to download PEAR archive.; \
 - echo ; \

ie, put it here, if wget and fetch are not found.

regards,
Derick

-- 
Derick Rethans
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /pear Makefile.frag fetch.php

2008-05-14 Thread Hannes Magnusson 
On Wed, May 14, 2008 at 8:52 PM, Derick Rethans [EMAIL PROTECTED] wrote:
 On Mon, 14 Apr 2008, Hannes Magnusson wrote:

 bjori Mon Apr 14 16:56:51 2008 UTC

   Added files: (Branch: PHP_5_3)
 /php-src/pear fetch.php

   Modified files:
 /php-src/pear Makefile.frag
   Log:
   Use PHP to fetch the pear phar

 Can we please revert this. wget supports proxies and this fetch.php
 thing assumes a standard terminal is wider than 80 chars. I'm fine with
 having it as fallback, but wget and fetch should be used first.

Err. Christopher had already pointed out the lack of proxy support but
I simply forgot to fix it.
The 80char width is an easy fix too...

The reason that prompted this commit was the annoying assumption of
wget or fetch existing, plus I was documenting the stream notification
stuff :), but I'm fine with using this as a fallback if neither wget
or fetch exist.

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php