[PHP-DEV] [PATCH] Prefer glibtool over libtool (resend)

[Justin Erenkrantz]

(This is a resend of an earlier patch.)

It switches to preferring glibtool over libtool so that we can
correctly run buildconf on Darwin.  Since Darwin comes with a libtool
but not the GNU libtool, we should try glibtool first.  Since libtool
exists, we don't look for glibtool and then when we try to verify
$libtool is a GNU libtool, we fail because $libtool isn't a GNU
libtool.

Please let me know if you have any questions or comments.  -- justin

Index: build/buildcheck.sh
===
RCS file: /repository/php4/build/buildcheck.sh,v
retrieving revision 1.16
diff -u -r1.16 buildcheck.sh
--- build/buildcheck.sh 4 Mar 2002 08:28:57 -   1.16
+++ build/buildcheck.sh 5 May 2002 08:10:10 -
 -60,8 +60,8 
 fi
 
 # libtool 1.4 or newer
-libtool=`which libtool`
-if test ! -f $libtool; then libtool=`which glibtool`; fi
+libtool=`which glibtool`
+if test ! -f $libtool; then libtool=`which libtool`; fi
 lt_pversion=`$libtool --version 2/dev/null|sed -n -e 's/^[^0-9]*//' -e 1's/[- 
].*//p'`
 if test $lt_pversion = ; then
 echo buildconf: libtool not found.

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] Prefer glibtool over libtool (resend)

[Marko Karppinen]

 (This is a resend of an earlier patch.)
 
 It switches to preferring glibtool over libtool so that we can
 correctly run buildconf on Darwin.  Since Darwin comes with a libtool
 but not the GNU libtool, we should try glibtool first.  Since libtool
 exists, we don't look for glibtool and then when we try to verify
 $libtool is a GNU libtool, we fail because $libtool isn't a GNU
 libtool.

Thanks Justin!

The thing is, we don't actually use glibtool on the platform at all.
Not with the Apache SAPIs anyway. I'll take a look and see how difficult
it would be to get rid of it completely in these checks and elsewhere.
Until I do, however, your patch is in.

--Marko


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php