Re: [PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread Jon Parise 

On Wed, Jun 20, 2001 at 06:51:31PM +0200, Thies C. Arntzen wrote:

> > Are you going to MFH it ?? I think this should go into 4.0.6.
> > It has been broken so long now.
> 
> no too sure as it really changes a few internals and needs
> _good_ testing!

4.0.6 really needs to get out the door.  Save it for 4.0.7.

-- 
Jon Parise ([EMAIL PROTECTED])  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread Thies C. Arntzen 

On Wed, Jun 20, 2001 at 07:05:23PM +0200, Jani Taskinen wrote:
> On Wed, 20 Jun 2001, Thies C. Arntzen wrote:
> 
> >> Are you going to MFH it ?? I think this should go into 4.0.6.
> >> It has been broken so long now.
> >
> >no too sure as it really changes a few internals and needs
> >_good_ testing!
> >
> >comments?
> 
> Nope. I can't test it. The HEAD branch doesn't work for me at all
> Not since the upgrade to libtool 1.4. That's why I asked if you're
> gonna MFH. :)

hmm - there are some more changes in the session module
between PHP_4_0_6 and HEAD. i will not merge my changes into
4.0.6 - your choices: a) use HEAD b) merge HEAD version of
session into your current PHP c) wait for 4.0.7

sorry,
tc

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread Thies C. Arntzen 

On Wed, Jun 20, 2001 at 06:47:46PM +0200, Jani Taskinen wrote:
> On Wed, 20 Jun 2001, Thies C. Arntzen wrote:
> 
> >On Wed, Jun 20, 2001 at 04:47:43PM +0200, Thies C. Arntzen wrote:
> >> please try attached patch and report back!
> >
> >this patch fixes the crash - the reference is still fu**ed
> >afetr the 2nd reload - switching my brain into 2nd gear;-)
> 
> You committed something to latest CVS? I guess it was the really
> working patch then? :)

yup it is.

> 
> Are you going to MFH it ?? I think this should go into 4.0.6.
> It has been broken so long now.

no too sure as it really changes a few internals and needs
_good_ testing!

comments?

tc

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread thies 

ID: 11432
Updated by: thies
Reported By: [EMAIL PROTECTED]
Old-Status: Duplicate
Status: Closed
Bug Type: *Session related
Operating system: 
PHP Version: 4.0.5
Assigned To: 
Comments:



Previous Comments:
---

[2001-06-19 11:21:49] [EMAIL PROTECTED]
I think this bug is strictly related to bug #8676.

I didn't look close enough to all open bugs wher reporting this one. I'll test new CVS 
when #8676 will be closed. 

---

[2001-06-15 06:59:17] [EMAIL PROTECTED]
Reclassifying (I don't think it can be reproduced with 'pure scripting' alone, so it's 
probably a session module bug

---

[2001-06-12 13:40:40] [EMAIL PROTECTED]
reproduced with 4.0.6RC3


---

[2001-06-12 08:29:39] [EMAIL PROTECTED]
Here are two scripts that operates on referenced objects. make.php creates object $b 
with reference to object $a as argument.

After serialize/unserialize show.php checks if the reference still exists.

PHP 4.0.1pl1 lost references.
PHP 4.0.4pl1 segfaults on show.php
PHP 4.0.5segfaults on show.php and(!) sometimes on make.php

Config line:
./configure --with-pgsql=shared --with-apxs --sysconfdir=/etc --prefix=/usr 
--localstatedir =/var --with-config-file-path=/etc/httpd/conf/ 
--with-gettext=/usr/share/gettext

make.php:
 arg_b = &$a;
}
};

session_start();
session_destroy();
session_register("b");
session_register("a");

$a = new ClassA();
$a -> arg_a = 4;
$b = new ClassB($a);
echo "done. Click here";
?>


show.php:
 arg_b = &$a;
}
};

session_start();
$a -> arg_a = 6;
echo $b -> arg_b -> arg_a;
?>

---



ATTENTION! Do NOT reply to this email!
To reply, use the web interface found at http://bugs.php.net/?id=11432&edit=2


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread Thies C. Arntzen 

On Wed, Jun 20, 2001 at 04:47:43PM +0200, Thies C. Arntzen wrote:
> please try attached patch and report back!

this patch fixes the crash - the reference is still fu**ed
afetr the 2nd reload - switching my brain into 2nd gear;-)

tc

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread Thies C. Arntzen 

please try attached patch and report back!

tc

On Tue, Jun 12, 2001 at 05:40:40PM -, [EMAIL PROTECTED] wrote:
> ID: 11432
> Updated by: sniper
> Reported By: [EMAIL PROTECTED]
> Status: Open
> Bug Type: Reproducible crash
> Operating system: 
> PHP Version: 4.0.5
> Assigned To: 
> Comments:
> 
> reproduced with 4.0.6RC3
> 
> 
> Previous Comments:
> ---
> 
> [2001-06-12 08:29:39] [EMAIL PROTECTED]
> Here are two scripts that operates on referenced objects. make.php creates object $b 
>with reference to object $a as argument.
> 
> After serialize/unserialize show.php checks if the reference still exists.
> 
> PHP 4.0.1pl1 lost references.
> PHP 4.0.4pl1 segfaults on show.php
> PHP 4.0.5segfaults on show.php and(!) sometimes on make.php
> 
> Config line:
> ./configure --with-pgsql=shared --with-apxs --sysconfdir=/etc --prefix=/usr 
> --localstatedir =/var --with-config-file-path=/etc/httpd/conf/ 
> --with-gettext=/usr/share/gettext
> 
> make.php:
>  class ClassA {
>  var $arg_a;
> };
> 
> class ClassB {
>   var $arg_b;
>  
>   function ClassB(&$a) {
>   $this -> arg_b = &$a;
>   }
> };
> 
> session_start();
> session_destroy();
> session_register("b");
> session_register("a");
> 
> $a = new ClassA();
> $a -> arg_a = 4;
> $b = new ClassB($a);
> echo "done. Click here";
> ?>
> 
> 
> show.php:
>  class ClassA {
>  var $arg_a;
> };
> 
> class ClassB {
>   var $arg_b;
>  
>   function ClassB(&$a) {
>   $this -> arg_b = &$a;
>   }
> };
> 
> session_start();
> $a -> arg_a = 6;
> echo $b -> arg_b -> arg_a;
> ?>
> 
> ---
> 
> 
> 
> ATTENTION! Do NOT reply to this email!
> To reply, use the web interface found at http://bugs.php.net/?id=11432&edit=2
> 
> 
> -- 
> PHP Development Mailing List 
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> To contact the list administrators, e-mail: [EMAIL PROTECTED]
> 


? .session.c.swp
Index: session.c
===
RCS file: /repository/php4/ext/session/session.c,v
retrieving revision 1.210
diff -u -r1.210 session.c
--- session.c   10 Jun 2001 23:26:35 -  1.210
+++ session.c   20 Jun 2001 14:47:46 -
@@ -405,7 +405,6 @@
 
PHP_VAR_UNSERIALIZE_INIT(var_hash);
 
-   MAKE_STD_ZVAL(current);
for (p = q = val; (p < endptr) && (q = memchr(p, PS_DELIMITER, endptr - p)); p 
= q) {
if (p[0] == PS_UNDEF_MARKER) {
p++;
@@ -418,16 +417,18 @@
name = estrndup(p, namelen);
q++;

+   MAKE_STD_ZVAL(current);
if (has_value) {
if (php_var_unserialize(¤t, &q, endptr, &var_hash)) {
+   
php_set_session_var(name, namelen, current PSLS_CC);
-   zval_dtor(current);
}
}
PS_ADD_VARL(name, namelen);
efree(name);
+   zval_ptr_dtor(¤t);
+   //FREE_ZVAL(current);
}
-   FREE_ZVAL(current);
 
PHP_VAR_UNSERIALIZE_DESTROY(var_hash);
return SUCCESS;



-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-20 Thread sniper 

ID: 11432
Updated by: sniper
Reported By: [EMAIL PROTECTED]
Old-Status: Open
Status: Duplicate
Bug Type: *Session related
Operating system: 
PHP Version: 4.0.5
Assigned To: 
Comments:

Let's make this duplicate then. ( #8676 )


Previous Comments:
---

[2001-06-19 11:21:49] [EMAIL PROTECTED]
I think this bug is strictly related to bug #8676.

I didn't look close enough to all open bugs wher reporting this one. I'll test new CVS 
when #8676 will be closed. 

---

[2001-06-15 06:59:17] [EMAIL PROTECTED]
Reclassifying (I don't think it can be reproduced with 'pure scripting' alone, so it's 
probably a session module bug

---

[2001-06-12 13:40:40] [EMAIL PROTECTED]
reproduced with 4.0.6RC3


---

[2001-06-12 08:29:39] [EMAIL PROTECTED]
Here are two scripts that operates on referenced objects. make.php creates object $b 
with reference to object $a as argument.

After serialize/unserialize show.php checks if the reference still exists.

PHP 4.0.1pl1 lost references.
PHP 4.0.4pl1 segfaults on show.php
PHP 4.0.5segfaults on show.php and(!) sometimes on make.php

Config line:
./configure --with-pgsql=shared --with-apxs --sysconfdir=/etc --prefix=/usr 
--localstatedir =/var --with-config-file-path=/etc/httpd/conf/ 
--with-gettext=/usr/share/gettext

make.php:
 arg_b = &$a;
}
};

session_start();
session_destroy();
session_register("b");
session_register("a");

$a = new ClassA();
$a -> arg_a = 4;
$b = new ClassB($a);
echo "done. Click here";
?>


show.php:
 arg_b = &$a;
}
};

session_start();
$a -> arg_a = 6;
echo $b -> arg_b -> arg_a;
?>

---



ATTENTION! Do NOT reply to this email!
To reply, use the web interface found at http://bugs.php.net/?id=11432&edit=2


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-19 Thread zork 

ID: 11432
User Update by: [EMAIL PROTECTED]
Status: Open
Bug Type: *Session related
Operating system: Linux 2.2.16
PHP Version: 4.0.5
Description: crash when restoring references to objects

I think this bug is strictly related to bug #8676.

I didn't look close enough to all open bugs wher reporting this one. I'll test new CVS 
when #8676 will be closed. 

Previous Comments:
---

[2001-06-15 06:59:17] [EMAIL PROTECTED]
Reclassifying (I don't think it can be reproduced with 'pure scripting' alone, so it's 
probably a session module bug

---

[2001-06-12 13:40:40] [EMAIL PROTECTED]
reproduced with 4.0.6RC3


---

[2001-06-12 08:29:39] [EMAIL PROTECTED]
Here are two scripts that operates on referenced objects. make.php creates object $b 
with reference to object $a as argument.

After serialize/unserialize show.php checks if the reference still exists.

PHP 4.0.1pl1 lost references.
PHP 4.0.4pl1 segfaults on show.php
PHP 4.0.5segfaults on show.php and(!) sometimes on make.php

Config line:
./configure --with-pgsql=shared --with-apxs --sysconfdir=/etc --prefix=/usr 
--localstatedir =/var --with-config-file-path=/etc/httpd/conf/ 
--with-gettext=/usr/share/gettext

make.php:
 arg_b = &$a;
}
};

session_start();
session_destroy();
session_register("b");
session_register("a");

$a = new ClassA();
$a -> arg_a = 4;
$b = new ClassB($a);
echo "done. Click here";
?>


show.php:
 arg_b = &$a;
}
};

session_start();
$a -> arg_a = 6;
echo $b -> arg_b -> arg_a;
?>

---


Full Bug description available at: http://bugs.php.net/?id=11432


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-19 Thread zeev 

ID: 11432
Updated by: zeev
Reported By: [EMAIL PROTECTED]
Status: Open
Old-Bug Type: Scripting Engine problem
Bug Type: *Session related
Operating system: 
PHP Version: 4.0.5
Assigned To: 
Comments:

Reclassifying (I don't think it can be reproduced with 'pure scripting' alone, so it's 
probably a session module bug

Previous Comments:
---

[2001-06-12 13:40:40] [EMAIL PROTECTED]
reproduced with 4.0.6RC3


---

[2001-06-12 08:29:39] [EMAIL PROTECTED]
Here are two scripts that operates on referenced objects. make.php creates object $b 
with reference to object $a as argument.

After serialize/unserialize show.php checks if the reference still exists.

PHP 4.0.1pl1 lost references.
PHP 4.0.4pl1 segfaults on show.php
PHP 4.0.5segfaults on show.php and(!) sometimes on make.php

Config line:
./configure --with-pgsql=shared --with-apxs --sysconfdir=/etc --prefix=/usr 
--localstatedir =/var --with-config-file-path=/etc/httpd/conf/ 
--with-gettext=/usr/share/gettext

make.php:
 arg_b = &$a;
}
};

session_start();
session_destroy();
session_register("b");
session_register("a");

$a = new ClassA();
$a -> arg_a = 4;
$b = new ClassB($a);
echo "done. Click here";
?>


show.php:
 arg_b = &$a;
}
};

session_start();
$a -> arg_a = 6;
echo $b -> arg_b -> arg_a;
?>

---



ATTENTION! Do NOT reply to this email!
To reply, use the web interface found at http://bugs.php.net/?id=11432&edit=2


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Bug #11432 Updated: crash when restoring references to objects

2001-06-19 Thread sniper 

ID: 11432
Updated by: sniper
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: Reproducible crash
Operating system: 
PHP Version: 4.0.5
Assigned To: 
Comments:

reproduced with 4.0.6RC3


Previous Comments:
---

[2001-06-12 08:29:39] [EMAIL PROTECTED]
Here are two scripts that operates on referenced objects. make.php creates object $b 
with reference to object $a as argument.

After serialize/unserialize show.php checks if the reference still exists.

PHP 4.0.1pl1 lost references.
PHP 4.0.4pl1 segfaults on show.php
PHP 4.0.5segfaults on show.php and(!) sometimes on make.php

Config line:
./configure --with-pgsql=shared --with-apxs --sysconfdir=/etc --prefix=/usr 
--localstatedir =/var --with-config-file-path=/etc/httpd/conf/ 
--with-gettext=/usr/share/gettext

make.php:
 arg_b = &$a;
}
};

session_start();
session_destroy();
session_register("b");
session_register("a");

$a = new ClassA();
$a -> arg_a = 4;
$b = new ClassB($a);
echo "done. Click here";
?>


show.php:
 arg_b = &$a;
}
};

session_start();
$a -> arg_a = 6;
echo $b -> arg_b -> arg_a;
?>

---



ATTENTION! Do NOT reply to this email!
To reply, use the web interface found at http://bugs.php.net/?id=11432&edit=2


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]