[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 Updated by: [EMAIL PROTECTED] Old Summary: Image*-functions being avail even if they're not implemented by gd Reported By: [EMAIL PROTECTED] Status: Open Old Bug Type: Feature/Change Request Bug Type: GD related Operating System: All PHP Version: 4.1.1 New Comment: I've also created a patch that remove the functions from the binary/module (if they're not available); http://software.e-mats.org/patches/gd.c-diff-2002-02-02 (i also moved this to 'GD related'.) Previous Comments: [2002-01-30 10:41:52] [EMAIL PROTECTED] I've made a small patch based on the CVS-version that remove functions that are not available. I'm not sure if i caught them all, but i made a try :-) I've not removed the original error-messages (gd was compiled without support..), so they're still in there (maybe a define or ./configure-option to select what way error-reporting should be done). the diff: http://software.e-mats.org/patches/gd.c-diff-2002-01-30 the source: http://software.e-mats.org/patches/gd.c-cvs-2002-01-30 [2002-01-30 08:51:11] [EMAIL PROTECTED] I'm +1 on your patch as well, can you make it against the latest CVS version? I'll make sure it gets committed then. regards, Derick [2002-01-30 08:47:03] [EMAIL PROTECTED] This is excactly the point i'm trying to make. To me it seems like the most logical thing would be to not implement the function at all, since this would make function_exists() work as expected. Implementing the function (to give an error message) - even though its not available seems kinda useless, since this also makes it harder to make a general solution. [2002-01-30 08:13:23] [EMAIL PROTECTED] This one seems really a mess to me (declaring function which output not implemented) when we have 'function_exists()'. Reopening for discussion. [2002-01-30 07:39:49] [EMAIL PROTECTED] .. this does however not cover the TTF*-functions. The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/?id=15288 Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 User updated by: [EMAIL PROTECTED] Old Summary: Image*-functions being avail even if they're not implemented by gd Reported By: [EMAIL PROTECTED] Status: Closed Bug Type: Feature/Change Request Operating System: All PHP Version: 4.1.1 New Comment: .. this does however not cover the TTF*-functions. Previous Comments: [2002-01-29 23:06:03] [EMAIL PROTECTED] There is already a clean way to check which image formats are supported: http://www.php.net/manual/en/function.imagetypes.php [2002-01-29 20:53:30] [EMAIL PROTECTED] The Image*-functions specific for different formats are available even if they're not supported in GD. Even though this is understandable, a better practice would probably be to disable these functions, since they're not available.(so they can be checked for existance in runtime, instead of relying on errors passed back from gd) It shouldnt be much of a change, since i was able to create the desired effect using a few #ifdef's - and i've only got spare knowledge of c. http://software.e-mats.org/patches/gd_4.1.1.diff contains the diff for the gd.c-file from 4.1.1. that i used for testing. Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 Updated by: mfischer Old Summary: Image*-functions being avail even if they're not implemented by gd Reported By: [EMAIL PROTECTED] Old Status: Closed Status: Open Bug Type: Feature/Change Request Operating System: All PHP Version: 4.1.1 New Comment: This one seems really a mess to me (declaring function which output not implemented) when we have 'function_exists()'. Reopening for discussion. Previous Comments: [2002-01-30 07:39:49] [EMAIL PROTECTED] .. this does however not cover the TTF*-functions. [2002-01-29 23:06:03] [EMAIL PROTECTED] There is already a clean way to check which image formats are supported: http://www.php.net/manual/en/function.imagetypes.php [2002-01-29 20:53:30] [EMAIL PROTECTED] The Image*-functions specific for different formats are available even if they're not supported in GD. Even though this is understandable, a better practice would probably be to disable these functions, since they're not available.(so they can be checked for existance in runtime, instead of relying on errors passed back from gd) It shouldnt be much of a change, since i was able to create the desired effect using a few #ifdef's - and i've only got spare knowledge of c. http://software.e-mats.org/patches/gd_4.1.1.diff contains the diff for the gd.c-file from 4.1.1. that i used for testing. Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 Comment by: [EMAIL PROTECTED] Reported By: [EMAIL PROTECTED] Status: Open Bug Type: Feature/Change Request Operating System: All PHP Version: 4.1.1 New Comment: This is excactly the point i'm trying to make. To me it seems like the most logical thing would be to not implement the function at all, since this would make function_exists() work as expected. Implementing the function (to give an error message) - even though its not available seems kinda useless, since this also makes it harder to make a general solution. Previous Comments: [2002-01-30 08:13:23] [EMAIL PROTECTED] This one seems really a mess to me (declaring function which output not implemented) when we have 'function_exists()'. Reopening for discussion. [2002-01-30 07:39:49] [EMAIL PROTECTED] .. this does however not cover the TTF*-functions. [2002-01-29 23:06:03] [EMAIL PROTECTED] There is already a clean way to check which image formats are supported: http://www.php.net/manual/en/function.imagetypes.php [2002-01-29 20:53:30] [EMAIL PROTECTED] The Image*-functions specific for different formats are available even if they're not supported in GD. Even though this is understandable, a better practice would probably be to disable these functions, since they're not available.(so they can be checked for existance in runtime, instead of relying on errors passed back from gd) It shouldnt be much of a change, since i was able to create the desired effect using a few #ifdef's - and i've only got spare knowledge of c. http://software.e-mats.org/patches/gd_4.1.1.diff contains the diff for the gd.c-file from 4.1.1. that i used for testing. Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 Updated by: derick Old Summary: Image*-functions being avail even if they're not implemented by gd Reported By: [EMAIL PROTECTED] Old Status: Open Status: Feedback Bug Type: Feature/Change Request Operating System: All PHP Version: 4.1.1 New Comment: I'm +1 on your patch as well, can you make it against the latest CVS version? I'll make sure it gets committed then. regards, Derick Previous Comments: [2002-01-30 08:47:03] [EMAIL PROTECTED] This is excactly the point i'm trying to make. To me it seems like the most logical thing would be to not implement the function at all, since this would make function_exists() work as expected. Implementing the function (to give an error message) - even though its not available seems kinda useless, since this also makes it harder to make a general solution. [2002-01-30 08:13:23] [EMAIL PROTECTED] This one seems really a mess to me (declaring function which output not implemented) when we have 'function_exists()'. Reopening for discussion. [2002-01-30 07:39:49] [EMAIL PROTECTED] .. this does however not cover the TTF*-functions. [2002-01-29 23:06:03] [EMAIL PROTECTED] There is already a clean way to check which image formats are supported: http://www.php.net/manual/en/function.imagetypes.php [2002-01-29 20:53:30] [EMAIL PROTECTED] The Image*-functions specific for different formats are available even if they're not supported in GD. Even though this is understandable, a better practice would probably be to disable these functions, since they're not available.(so they can be checked for existance in runtime, instead of relying on errors passed back from gd) It shouldnt be much of a change, since i was able to create the desired effect using a few #ifdef's - and i've only got spare knowledge of c. http://software.e-mats.org/patches/gd_4.1.1.diff contains the diff for the gd.c-file from 4.1.1. that i used for testing. Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 User updated by: [EMAIL PROTECTED] Old Summary: Image*-functions being avail even if they're not implemented by gd Reported By: [EMAIL PROTECTED] Old Status: Feedback Status: Open Bug Type: Feature/Change Request Operating System: All PHP Version: 4.1.1 New Comment: I've made a small patch based on the CVS-version that remove functions that are not available. I'm not sure if i caught them all, but i made a try :-) I've not removed the original error-messages (gd was compiled without support..), so they're still in there (maybe a define or ./configure-option to select what way error-reporting should be done). the diff: http://software.e-mats.org/patches/gd.c-diff-2002-01-30 the source: http://software.e-mats.org/patches/gd.c-cvs-2002-01-30 Previous Comments: [2002-01-30 08:51:11] [EMAIL PROTECTED] I'm +1 on your patch as well, can you make it against the latest CVS version? I'll make sure it gets committed then. regards, Derick [2002-01-30 08:47:03] [EMAIL PROTECTED] This is excactly the point i'm trying to make. To me it seems like the most logical thing would be to not implement the function at all, since this would make function_exists() work as expected. Implementing the function (to give an error message) - even though its not available seems kinda useless, since this also makes it harder to make a general solution. [2002-01-30 08:13:23] [EMAIL PROTECTED] This one seems really a mess to me (declaring function which output not implemented) when we have 'function_exists()'. Reopening for discussion. [2002-01-30 07:39:49] [EMAIL PROTECTED] .. this does however not cover the TTF*-functions. [2002-01-29 23:06:03] [EMAIL PROTECTED] There is already a clean way to check which image formats are supported: http://www.php.net/manual/en/function.imagetypes.php The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/?id=15288 Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] Bug #15288 Updated: Image*-functions being avail even if they're not implemented by gd
ID: 15288 Updated by: cardinal Old Summary: Image*-functions being avail even if they're not implemented by gd Reported By: [EMAIL PROTECTED] Old Status: Open Status: Closed Bug Type: Feature/Change Request Operating System: All PHP Version: 4.1.1 New Comment: There is already a clean way to check which image formats are supported: http://www.php.net/manual/en/function.imagetypes.php Previous Comments: [2002-01-29 20:53:30] [EMAIL PROTECTED] The Image*-functions specific for different formats are available even if they're not supported in GD. Even though this is understandable, a better practice would probably be to disable these functions, since they're not available.(so they can be checked for existance in runtime, instead of relying on errors passed back from gd) It shouldnt be much of a change, since i was able to create the desired effect using a few #ifdef's - and i've only got spare knowledge of c. http://software.e-mats.org/patches/gd_4.1.1.diff contains the diff for the gd.c-file from 4.1.1. that i used for testing. Edit this bug report at http://bugs.php.net/?id=15288edit=1 -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
